[LogiLogi-list] link removal, diff and others...

Hi all,

It's been some time I don't respond to the list, but I've been reading.

== link removal ==
I saw the commits of the link removal and it certainly works very
nice, and very intuitive as Wybo said. I'll soon get down with
crossbrowser (IE) compat of some bits of positioning, but someone else
with JS skils should fix the error preventing logilogi-popover-links
to show up.

== history & diff ==
About the history/diff code, Miguel proposed an in-line aproach to
version comparison, plus it's dynamic display (like good web2.0 LL is
:), which I think both are very interesting... I first thought going
inline for comparison would be a mess and hard to deal with, mostly as
I don't have many examples of inline diff comparison, but after
researching a bit, I found that even it's not a common approach, it
could fit our needs, since we dont want a so technical tool, but more
a more graphical one...

I was looking at how it's working now, and I have some suggestions to make.

=== Tags ===
We should decide whether we will compare the code (including tags) or
the text (output). This I would guess was already decided for the
current alpha version of the diff, and for what I can tell, the choice
was to compare the output text, which I think is the best approach for
our needs, so this way we will get the user away from the code in all
cases, when editing, diffing, adding links, etc.  Right now it's not
working as spected, but I guess this is because of the alpha state of
the code. For example, changing "Original title" by "New title" right
now in the diff looks like this:

<span class="diff_new"><h1>New<span
class="diff_old"></span></h1><h1>Original<span class="diff_both">
title</span></h1>

and a diff of changing "original" by "modified" in the paragraph looks
like this:

<p>This is the </p></span><span class="diff_old">original paragraph
text</span><span class="diff_new">new paragraph text</span>

This is obviously not working as spected right now, and I know it's
because it's not finished, but I just wanted to show who I would deal
with tags.

We should define which tags we are working with, not many by the way,
h1, h2, p, ol, ul, li, em, strong, sup, sub. With this tags, we could
define the following way of diffing. We could diff the plain text
inside structural tags, like headings, paragraphs and lists (items),
and we should deal inside this tags with the text styling tags, like
em, strong, sup, sub. This is the best approach I can imagine, and
maybe, this is already where we are heading to, I didn't talk with
Miguel about this. This way, the previous examples would look like
this:

<h1><span class="diff_new">New</span><span
class="diff_old">Original<span class="diff_both"> title</span></h1>
<p><span class="diff_both">This is the </span><span
class="diff_old">original</span><span class="diff_new">new</span><span
class="diff_both"> paragraph text</span></p>

Also I don't know for which cases is the diff_both tag used for.

=== Version selection ===
For the version selection, I would certainly go the wikipedia style,
which is very intuitive and functional, and it dont have to deal with
3 versions comparison... will we deal with this? do we need it?

Also note, that if we use (like WP) two columns of radio buttons
(instead of checkboxes), we avoid multiple selection.

=== Styles ===
Here are the styles with other colors and I also suggest to add a
white background when a logi is displayed, for better reading and
differentiation. I could add this if you all agree.

#overbox div.overpanel#logi_view {
	background-color:#FFFFFF;
	padding: 8px;
}

/*
Diff colors
*/

.diff_new {
	background-color: #AAFFAA;
}
.diff_old {
	background-color: #FFD2D2;
	text-decoration: line-through;
}
.diff_both {  }


I think the in-line diff approach will look really nifty!

Greetings y'all.

-- 
Bruno