Re: [LogiLogi-list] Public beta updated!
Status: Beta
Brought to you by:
wybow
|
From: S. M. <S.M...@st...> - 2008-05-22 14:27:28
|
> @ Feng & Steffen > The cloud-positions for the link-removing are still not what they > should be in Firefox, and also a link-removal unit-test was broken, > & besides it just was not finished yet, so I also temporarily > commented that out in the menu... About the unit-test; doing the > calculations on the position-ranges should be covered by the > position-ranges lib under libs... So let me know if the old > implementation worked or not... We looked at the PositionRange class and used some methods for remove_links_from_position_ranges and made the unit test work. It is not possible to use the substract method of PositionRange. If you substract a link which begin and end position is smaller than another link from that link, you have to get two new position ranges. (e.g. 1..8 - 2...5 must be 1..2 and 5..8) The old code just substracts the begin and you have only one new position range. |