Re: [liblo] lo_address for TCP or UNIX connection

On Mon, 8 Sep 2008 18:09:53 -0400
"Stephen Sinclair" <rad...@gm...> wrote:
 
> Okay, at first look I can see that it is useful.  I see that a null
> check was missing in lo_address_new.  Also, I guess the memory leak
> you are referring to is the change you made in server.c?  It would be
> nice if you had split up these into different commits so that I can
> see clearly what is what.

Right. I had accidentally committed all patches at once.

Brief summary was written in ChangeLog, and here I wrote detailed docs
about the patches:
Memory leaks were found in server.c and address.c. The leak in dispatch_method()
is that exiting the function without freeing the list of strings. The other leak
in lo_address_new_from_url() is the missing free(a) when an error is occurred.

> I think the name lo_url_get_protocol2 is not very descriptive.
> Perhaps we could call it lo_url_get_protocol_id.
Thanks, I changed.

> Otherwise, I think the patch is quite good, thanks.
> Shall I split it up and apply it with the changed function name?  You
> can then base your changes to oscsend/dump off the new trunk.

Okay, I'm preparing patches.

thanks,

Kentaro