Menu
▾
▴
Code Merge Request #1: Fix condition's boolean logic (rejected)
Merging...
Merged
Something went wrong. Please, merge manually
Checking if merge is possible...
Something went wrong. Please, merge manually
Michael McConville wants to merge 1 commit from /u/mmcco/libcmis/ to master, 2018-12-26
This condition's logic doesn't make sense as it is; it always evaluates to true. I think I've fixed it, but someone who knows the code better should confirm.
| Commit | Date | |
|---|---|---|
| 2017-12-25 02:59:31 | Tree |
The original code doesn't filter out duplicate name property as it is supposed to do. Your variant doesn't guarantee that either. In addition, it drops all other properties. I've pushed a proper fix.
Btw, the development has moved to github: https://github.com/tdf/libcmis.