[go: up one dir, main page]

Menu

GtkSpell Merge Request #1: Patches for #20 and some other issues found in autogen.sh (merged)

Merging...

Merged

Something went wrong. Please, merge manually

Checking if merge is possible...

Something went wrong. Please, merge manually

林博仁(Buo-ren Lin) wants to merge 7 commits from /u/lin-buo-ren/gtkspell/ to master, 2018-06-29

This merge request includes some patches for ticket #20 and some other issues in the autogen script.

Signed-off-by: 林博仁(Buo-ren, Lin) <Buo.Ren.Lin@gmail.com>

Commit Date  
[f7b9b8] (patch-autogen) by 林博仁(Buo-ren Lin) 林博仁(Buo-ren Lin)

Improve gtkdocize command detection in autogen script

Currently gtkdocize command detection relies on non shell built-in
`which` command and string test which is unnecessary and also broken
since commit adeb8ab. This patch improves the detection by using the
built-in `command` utility.

Signed-off-by: 林博仁(Buo-ren Lin) <Buo.Ren.Lin@...>

2018-05-21 22:01:15 Tree
[de8fc1] by 林博仁(Buo-ren Lin) 林博仁(Buo-ren Lin)

Ensure build dir is created before running intltoolize

The intltoolize command expects a directory called `build` to be
exist in the working directory, this patch ensures this by creating
the directory in advance.

Signed-off-by: 林博仁(Buo-ren Lin) <Buo.Ren.Lin@...>

2018-05-21 21:46:40 Tree
[2d4dc1] by 林博仁(Buo-ren Lin) 林博仁(Buo-ren Lin)

Avoid word-splitting when srcdir path contains spaces

Signed-off-by: 林博仁(Buo-ren Lin) <Buo.Ren.Lin@...>

2018-05-21 21:23:39 Tree
[adeb8a] by 林博仁(Buo-ren Lin) 林博仁(Buo-ren Lin)

Let autogen.sh be error aware

Currently the script won't end prematurely when an error is occurred,
this patch enables the errexit shell option to make it bail out once
an error is occurred.

Refer-to: DESCRIPTION - set - Shell Command Language - The Open Group Base Specifications Issue 7, 2018 edition <http://pubs.opengroup.org/onlinepubs/9699919799/utilities/V3_chap02.html#tag_18_25_03>
Signed-off-by: 林博仁(Buo-ren Lin) <Buo.Ren.Lin@...>

2018-05-21 21:00:51 Tree
[dda6a0] by 林博仁(Buo-ren Lin) 林博仁(Buo-ren Lin)

Enable check for intltool in autogen.sh

This patch enables the installation checking of intltool, which was
previously disabled. This patch also uses the new upstream site
address.

Signed-off-by: 林博仁(Buo-ren Lin) <Buo.Ren.Lin@...>

2018-05-21 21:10:22 Tree
[bd44e6] by 林博仁(Buo-ren Lin) 林博仁(Buo-ren Lin)

Use package name instead of command name in autogen.sh

Signed-off-by: 林博仁(Buo-ren Lin) <Buo.Ren.Lin@...>

2018-05-21 21:12:00 Tree
[512894] by 林博仁(Buo-ren Lin) 林博仁(Buo-ren Lin)

Check for Automake installation in autogen.sh

The following misleading error message will appear if `aclocal` is
called before ensuring it's existance:

```
**Error**: You must have the `ax_cxx_compile_stdcxx_11.m4' macro installed-
Download the appropriate package for your distribution,
or get it from http://mirror.switch.ch/ftp/mirror/gnu/autoconf-archive/
```

This patch implements the check.

Signed-off-by: 林博仁(Buo-ren Lin) <Buo.Ren.Lin@...>

2018-05-21 20:46:59 Tree

Discussion

  • Sandro Mani

    Sandro Mani - 2018-05-21

    Thanks! Looks good to me overall, though typically as far as I have seen in other projects, errors always report which executable is missing, not the package (i.e. aclocal vs automake). Indeed, it might be the case that some distro packages the executables in differently named packages.

     
  • Sandro Mani

    Sandro Mani - 2018-06-29
    • Status: open --> merged
     

Log in to post a comment.