galet-devel Mailing List for galet

* fo...@vo... <fo...@vo...> wrote:
> I would be interested in adding a "crypto less" option at compile time, 
> disabled by default, using an option like : make --nocrypto
> So that there is no need for Botan (I only trust VPNs, and there in is always 
> a man in the middle)
> Any objection ?
> David

That would be difficult, as Galet uses cryptography extensively, and not
only for communication (e.g. public-key hash as node ID, file hashes in
file-sharing). This would also defeat its main purpose of providing a
secure means of communication.

Also, Galet can already be used as a VPN, and is only susceptible to
man-in-the-middle attacks during the transmission of the initial
invitation token, which must happen through an external, secure channel.
In normal operation, Galet uses the Station-To-Station protocol for key
exchange, and is not vulnerable to man-in-the-middle attacks.

If the Botan requirement really is a problem, it would be better to ship
a copy of the library with Galet, the Botan license being quite
reasonable.

Jean

I would be interested in adding a "crypto less" option at compile time, 
disabled by default, using an option like : make --nocrypto
So that there is no need for Botan (I only trust VPNs, and there in is always 
a man in the middle)
Any objection ?
David

Commited the 2 patches to make Galet compile with Botan 1.6.x, nice work!
Also it seems to do fine with Qt 4.4.2.

* fo...@vo... <fo...@vo...> wrote:
> last post worked with botan 1.6 not 1.8...
> 
> in DHPrivateKey.cpp, line 29 was originally :
> return new DHPrivateKey(new 
> Botan::DH_PrivateKey(Botan::get_dl_group(DH_DL_GROUP)));
> 
> should be remplaced by one of the two :
> Botan::DH_PrivateKey::DH_PrivateKey ()
> or
> Botan::DH_PrivateKey::DH_PrivateKey(RandomNumberGenerator & rng, 
> 		const DL_Group & 	grp, 
> 		const BigInt & 	x = 0	)
> which one ?
> what about rng variable ?

Hum, not sure. But anyway Botan 1.6.x is the stable version on the
distributions I checked (Gentoo, Debian and Ubuntu(I think)), so we
might as well stick with it for now...

Jean

P.S. I am glad you are very happy :-)

last post worked with botan 1.6 not 1.8...

in DHPrivateKey.cpp, line 29 was originally :
return new DHPrivateKey(new 
Botan::DH_PrivateKey(Botan::get_dl_group(DH_DL_GROUP)));

should be remplaced by one of the two :
Botan::DH_PrivateKey::DH_PrivateKey ()
or
Botan::DH_PrivateKey::DH_PrivateKey(RandomNumberGenerator & rng, 
		const DL_Group & 	grp, 
		const BigInt & 	x = 0	)
which one ?
what about rng variable ?

On Thursday 14 May 2009 12:53:55 fo...@vo... wrote:
> Compilation Successful ! RNG_Quality and get_dl_group problems solved.
>
> Could you please add my last 2 patches to the CVS tree ?
> thanks.
> David
>
> diff on DHPrivateKey.cpp file :
> 29c29
> <       return new DHPrivateKey(new
> Botan::DH_PrivateKey(Botan::get_dl_group(DH_DL_GROUP)));
> ---
>
> >       return new DHPrivateKey(new
>
> Botan::DH_PrivateKey(Botan::DL_Group::DL_Group(DH_DL_GROUP)));
>
> On Thursday 14 May 2009 11:28:45 fo...@vo... wrote:
> > get_dl_group no longer exists
> >
> > At compil time :
> > crypto/DHPrivateKey.cpp: In static member function ‘static DHPrivateKey*
> > DHPrivateKey::generate()’:
> > crypto/DHPrivateKey.cpp:29: error: ‘get_dl_group’ is not a member of
> > ‘Botan’ make[1]: *** [../tmp/src/DHPrivateKey.o] Error 1
> >
> > offical annonce from botan :
> > get_dl_group has been removed. Instead create a DL_Group object directly,
> > passing the same string you would have passed to
> > get_dl_group to the DL_Group constructor
> > source :
> > http://lists.randombit.net/pipermail/botan-announce/2006/000016.html
>

seems to be solved adding in file Cipher.h :
#include <botan/block_cipher.h>


On Thursday 14 May 2009 13:05:06 fo...@vo... wrote:
> I could compile and run Galet using botan 1.6 (I am very happy), but with
> botan 1.8 I have an error :
>
> In file included from CommonFirstConnectionInitialiser.cpp:7:
> crypto/Cipher.h:20: error: ISO C++ forbids declaration of ‘BlockCipher’
> with no type
> crypto/Cipher.h:20: error: invalid use of ‘::’
> crypto/Cipher.h:20: error: expected ‘;’ before ‘*’ token
> make[1]: *** [../tmp/src/CommonFirstConnectionInitialiser.o] Error 1

I could compile and run Galet using botan 1.6 (I am very happy), but with 
botan 1.8 I have an error :

In file included from CommonFirstConnectionInitialiser.cpp:7:
crypto/Cipher.h:20: error: ISO C++ forbids declaration of ‘BlockCipher’ with 
no type
crypto/Cipher.h:20: error: invalid use of ‘::’
crypto/Cipher.h:20: error: expected ‘;’ before ‘*’ token
make[1]: *** [../tmp/src/CommonFirstConnectionInitialiser.o] Error 1

Compilation Successful ! RNG_Quality and get_dl_group problems solved.

Could you please add my last 2 patches to the CVS tree ?
thanks.
David

diff on DHPrivateKey.cpp file :
29c29
<       return new DHPrivateKey(new 
Botan::DH_PrivateKey(Botan::get_dl_group(DH_DL_GROUP)));
---
>       return new DHPrivateKey(new 
Botan::DH_PrivateKey(Botan::DL_Group::DL_Group(DH_DL_GROUP)));


On Thursday 14 May 2009 11:28:45 fo...@vo... wrote:
> get_dl_group no longer exists
>
> At compil time :
> crypto/DHPrivateKey.cpp: In static member function ‘static DHPrivateKey*
> DHPrivateKey::generate()’:
> crypto/DHPrivateKey.cpp:29: error: ‘get_dl_group’ is not a member of
> ‘Botan’ make[1]: *** [../tmp/src/DHPrivateKey.o] Error 1
>
> offical annonce from botan :
> get_dl_group has been removed. Instead create a DL_Group object directly,
> passing the same string you would have passed to
> get_dl_group to the DL_Group constructor
> source :
> http://lists.randombit.net/pipermail/botan-announce/2006/000016.html
>

get_dl_group no longer exists

At compil time :
crypto/DHPrivateKey.cpp: In static member function ‘static DHPrivateKey* 
DHPrivateKey::generate()’:
crypto/DHPrivateKey.cpp:29: error: ‘get_dl_group’ is not a member of ‘Botan’
make[1]: *** [../tmp/src/DHPrivateKey.o] Error 1

offical annonce from botan :
get_dl_group has been removed. Instead create a DL_Group object directly, 
passing the same string you would have passed to
get_dl_group to the DL_Group constructor
source : http://lists.randombit.net/pipermail/botan-announce/2006/000016.html

Here is my diff on PRNG.cpp and PRNG.h

PRNG.cpp :
59c48
< 	Botan::Global_RNG::randomize((unsigned char*)(res.data()), res.size(), 
doQualityToBotan(quality));
---
> 	Botan::Global_RNG::randomize((unsigned char*)(res.data()), res.size());

66c55
< 	Botan::Global_RNG::randomize((unsigned char*)(&res), 4, 
doQualityToBotan(quality));
---
> 	Botan::Global_RNG::randomize((unsigned char*)(&res), 4);

73c62
< 	Botan::Global_RNG::randomize((unsigned char*)(&res), 8, 
doQualityToBotan(quality));
---
> 	Botan::Global_RNG::randomize((unsigned char*)(&res), 8);

12,22d11
< Botan::RNG_Quality PRNG::doQualityToBotan(PRNG::Quality quality) {
< 	switch(quality) {
< 	case Nonce:
< 		return Botan::Nonce;
< 	case Session:
< 		return Botan::SessionKey;
< 	case LongTerm:
< 		return Botan::LongTermKey;
< 	}
< 	Q_ASSERT(false);
< }

PRNG.h :

14c14
< 	static Botan::RNG_Quality doQualityToBotan(PRNG::Quality quality);
---
> 

Original annonce from Botan site :
"the RNG system now uses just a single PRNG object
The now redundant RNG_Quality enum has been removed entirely"
source : http://lists.randombit.net/pipermail/botan-announce/2006/000009.html

On Thursday 14 May 2009 00:12:06 fo...@vo... wrote:
> in PRNG.cpp line 12, RNG_Quality does no longer exist in Botan 1.8
> So compilation fails.
>
> Botan::RNG_Quality PRNG::doQualityToBotan(PRNG::Quality quality) {
> 	switch(quality) {
> 	case Nonce:
> 		return Botan::Nonce;
> 	case Session:
> 		return Botan::SessionKey;
> 	case LongTerm:
> 		return Botan::LongTermKey;
> 	}
>
> in old Botan lib, RNG_Quality was defined as :
> enum RNG_Quality { Nonce = 0, PublicValue = 0, SessionKey, LongTermKey };
>
> In Galet, Quality is :
> enum Quality {Nonce, Session, LongTerm};
>

in PRNG.cpp line 12, RNG_Quality does no longer exist in Botan 1.8
So compilation fails.

Botan::RNG_Quality PRNG::doQualityToBotan(PRNG::Quality quality) {
	switch(quality) {
	case Nonce:
		return Botan::Nonce;
	case Session:
		return Botan::SessionKey;
	case LongTerm:
		return Botan::LongTermKey;
	}

in old Botan lib, RNG_Quality was defined as :
enum RNG_Quality { Nonce = 0, PublicValue = 0, SessionKey, LongTermKey };

In Galet, Quality is :
enum Quality {Nonce, Session, LongTerm};

let's try to re-define RNG_Quality (to be continued)

Hi David!

* fo...@vo... <fo...@vo...> wrote:
> At first I couldn't compile Galet on Mandriva 2008.1 because of QT 3.3.
> I am downloading and building Qt 4.5, is there a chance Galet works ?
I am fairly certain it built with Qt 4.0 and 4.1, and I imagine it
would build with 4.x in general, if with a few small modifications.
Also, I seem to recall it required the crypto library botan 1.5.x .

> Is there a documentation about Galet protocol ?
kinda, there are misc drafts/examples in the doc directory (doc/proto in
particular may be relevant); but the code is the most up-to-date...

> Is there a "donate Paypal" option ?
Nope.

> this is my first post : I work in computers and know a little Qt. The program
> is very well written, very good work !
Thanks! I wrote it a while ago now, but I still think it is a solid
piece of software; its main problem being that it requires a fair amount
of network configuration to be usable : at least one of the nodes in any
one-to-one link must make a TCP port accessible to the other; which
nowadays requires for most people making holes in firewalls, and
setting up port forwarding.

> Maybe there is a lack of /* comments */ . (same for me)
Yes, the source is a bit dense and comment-free at times...

> David, from Lyon (France)
>

Cheers,
Jean

At first I couldn't compile Galet on Mandriva 2008.1 because of QT 3.3.
I am downloading and building Qt 4.5, is there a chance Galet works ?
Is there a documentation about Galet protocol ?
Is there a "donate Paypal" option ?

this is my first post : I work in computers and know a little Qt. The program 
is very well written, very good work !
Maybe there is a lack of /* comments */ . (same for me)
David, from Lyon (France)