[go: up one dir, main page]

Menu

#190 Move to native `unittest`

None
closed-accepted
nobody
None
5
2022-12-01
2022-01-20
Adam Turner
No

From FR81 https://sourceforge.net/p/docutils/feature-requests/81/#fc55/3d8d by Günter Milde

I had a quick look and the work looks promising, so yes, I would like to
give it a try.

What is the effect on the test time and on the output if there are, e.g.,
differences between output and expected in functional tests?

To avoid wasted work (and the sunken-cost fallacy), I propose to split
the project into smaller changesets (of 1 to ca. 7 commits) which we can
discuss and adapt before pushing to origin/master and then move to the
next step.
I expect some rounds of discussion per step, so there is no
need to invest heavily in polishing in the first round.
A link to a patch that I can apply with git am -3 to a local branch
would be fine.
The discussion could move to docutils-develop or a new ticket,
whatever you prefer.

This is the proposed tracking issue for moving to native unittest

A

Discussion

  • Adam  Turner

    Adam Turner - 2022-01-20

    I have done all the work to get this working at https://github.com/AA-Turner/docutils/pull/9 with no noticable impact on time. However this is a massive changeset, so I need to think about how to break this into logical chunks/components.

    A

     
  • Adam  Turner

    Adam Turner - 2022-01-31

    I propose to split the project into smaller changesets

    The linked PR now contains 3 commits -- the first removes quicktest.py, the second removes path hacking in __init.py, and the third is an update to the functional tests.

    Hopefully this is a good place to start, I can work on the next bits whilst the changes here are reviewed.

    https://github.com/AA-Turner/docutils/pull/9 // https://github.com/AA-Turner/docutils/pull/9.patch

     
    • Adam  Turner

      Adam Turner - 2022-01-31

      (sorry, misclicked!)

      All tests pass on each commit, and they should be fairly easy to re-order if need be.

      A

       
  • Günter Milde

    Günter Milde - 2022-11-30
    • status: open --> open-accepted
     
  • Günter Milde

    Günter Milde - 2022-11-30

    With [r9237] the test-suite refactoring patch is committed to the repository.
    Thanks for the work.

     

    Related

    Commit: [r9237]

  • Adam  Turner

    Adam Turner - 2022-12-01
    • status: open-accepted --> closed-accepted
     

Log in to post a comment.