[Colossus-tracker] [ colossus-Bugs-2078529 ] Preferences

Bugs item #2078529, was opened at 2008-08-27 18:22
Message generated for change (Comment added) made by cleka
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=101939&aid=2078529&group_id=1939

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: GUI
Group: None
Status: Open
>Resolution: Fixed
Priority: 5
Private: No
Submitted By: Ben Bishop (benbishop)
Assigned to: Clemens Katzer (cleka)
Summary: Preferences

Initial Comment:
I play abyssal9, and I more or less _have_ to have the window scale set to '8' to play.

Since the new version (20080822) the scale is now set in the Windows tab of the Preferences window.

It may keep during a session, but it reset to 15 when I started a game a few days later.

In addition, when you change the scale, the "Game Status" window also changes scale (but the "caretaker stacks" and "engagement status" windows do not -- i certainly don't think it should)

Ben



----------------------------------------------------------------------

>Comment By: Clemens Katzer (cleka)
Date: 2008-08-28 16:40

Message:
Logged In: YES 
user_id=1717697
Originator: NO

Main issue (value back to 15 each time) now fixed, r3335.

Whether/which windows should use the scale which not... 
remains an open issue.

-CleKa


----------------------------------------------------------------------

Comment By: Clemens Katzer (cleka)
Date: 2008-08-27 23:07

Message:
Logged In: YES 
user_id=1717697
Originator: NO


All right... ok, basically it can be done that it is on start the same as
in previous game.

Only... - for good or bad, this effect then also the pick color and pick
legion marker dialogs (and of course the status window). One can drag some
of them bigger but ... well, interesting effects.

BTW, not to mention the case if there is two boards (more than one human
local player on this computer). If any of them changes it effects to both
players windows ...somehow... (sooner or later. Or then, not). And which
ends up in cf file, and/or during next load... pure randomly. Oh boy. :-(


I think the whole thing needs reconsidering. Someone said already we
should get rid of this scale issue and let Java/Swing take care of all
scaling (based on window drag)... would be better probably, but lot of
work.

To get an usable solution in near future, my idea would be:
Two scales, one for Masterboard and one for everything else.
PickColor, PickMarker and Game status do not care about scale at all -
they remain that big as they were before (that is, status window as high as
before, width adjusting to player count; the pick* should perhaps adapt
their size that way that a marker / color box ("button") is always "same
big" - so if more markers, window grows etc.

*just thinking loudly*

-Clemens


----------------------------------------------------------------------

Comment By: Clemens Katzer (cleka)
Date: 2008-08-27 22:33

Message:
Logged In: YES 
user_id=1717697
Originator: NO


You are right, one a new start in the preferences window it is again 15,
and the board is drawn this size. BUT:...
But even worse, the changed value *is* stored to the file, and if you
change it in preferences first from 15 to same what it was stored,
nothing
will happen... it compares to the value in the options file, it's same,
so it does not repaint. So you have first change to e.g. 9 and apply,
and then to 8 and apply. ... Really room for improvement here.

Right, to me it also looks as if status window is scaled, 
engagement & caretaker are not. Scaling status window does not make
too much sense to me...
[Event viewer *kind of* is: from scale change on they are displayed
 with new size, and on a redraw (e.g. change settings, which type of
events to show),
 all are drawn with new scale, too. ]

Yeah, something to fix here. And having different scales for different
issues
is on the to do list and in feature requests already for ... years.


Thanks for pointing this out. I'll see what I can do. 
(except if someone else is faster *ggg*)

Right now I am hunting why game loading sometimes does not work....

BR,

Clemens


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=101939&aid=2078529&group_id=1939