civil-devel Mailing List for Civil

On Tue, 23 Sep 2003, Marcus Alanen wrote:

> Ok maybe I'm just thick, but Redhat seems to want games
> in /usr/games, and the current
> export BINDIR = $(prefix)/bin
> effectively makes this impossible???
> 
> Why not
> -export BINDIR      = $(prefix)/bin
> +export BINDIR      = @bindir@
> 
> ...and let packagers use ./configure --bindir=whatever
> ?

I agree with this.  Actually, it has been pointed out the Gentoo
Linux isn't FHS complient right now with regard to our game location.
We currently install games to /usr/games/bin but the FHS requires
/usr/games so the change you suggest above I believe is the right way
to go.

I look forward to your next beta release.  If you could put out a
civil_0.82-3.tar.gz or civil_0.83.tar.gz, that would be great.

Michael Sterrett
  -Mr. Bones.-
mst...@ge...

OK, changed the various civilXXX.in files as well. Now it works for me, 
on a RedHat 9. Does it work for you?

On Tue, 23 Sep 2003, Marcus Alanen wrote:

>>>sed -i \
>>>   -e "s/[ 	]*$//" \
>>>   -e "/^export BINDIR/ s:/games$:/bin:" \
>>>   -e "/^export datadir/ s:/games/:/:" Makefile.in
>>>
>>>1. trim trailing white-space (always a good idea)
>>>2. Fix BINDIR
>>>3. Fix datadir
>
>Ok maybe I'm just thick, but Redhat seems to want games
>in /usr/games, and the current
>export BINDIR = $(prefix)/bin
>effectively makes this impossible???
>
>Why not
>-export BINDIR      = $(prefix)/bin
>+export BINDIR      = @bindir@
>
>...and let packagers use ./configure --bindir=whatever

@bindir@ should normally default to $(prefix)/bin, so that change you
suggest should be just fine. Or rather, it's preferable to leave it alone.

--
Voodoo is a very interesting religion for the whole family, even those
    members of it who are dead.
                          -- Terry Pratchett & Neil Gaiman, Good Omens

>>sed -i \
>>   -e "s/[ 	]*$//" \
>>   -e "/^export BINDIR/ s:/games$:/bin:" \
>>   -e "/^export datadir/ s:/games/:/:" Makefile.in
>>
>>1. trim trailing white-space (always a good idea)
>>2. Fix BINDIR
>>3. Fix datadir

Ok maybe I'm just thick, but Redhat seems to want games
in /usr/games, and the current
export BINDIR = $(prefix)/bin
effectively makes this impossible???

Why not
-export BINDIR      = $(prefix)/bin
+export BINDIR      = @bindir@

...and let packagers use ./configure --bindir=whatever
?

Marcus

On Mon, 22 Sep 2003, Marcus Alanen wrote:

> From my limited experience, this seems to be a packager's problem from 
> the LSB side. I.e., ./configure just throws the files into the 
> standard /usr/local/xxx places, and if somebody wants it elsewhere 
> then they have to explicitely give the propert --bindir and --datadir 
> declarations. And this seems to be the case with especially 
> games-related stuff, ./configure by default doesn't give the 
> "LSB-correct" information.

Yes, exactly.

> Btw, does this mean Gentoo will package civil?

We have a request for it.  See: http://bugs.gentoo.org/show_bug.cgi?id=28967
I am working on the ebuild for civil so it seems likely that it will be
added to Gentoo's portage eventually.

Michael Sterrett
  -Mr. Bones.-
mst...@ge...

On Mon, 22 Sep 2003, Michael Sterrett -Mr. Bones.- wrote:

>Wow, thanks for the quick reply...

Oh, I'm at work now, I have all the time in the world for pet projects. :)

>Makefile.in is hand-created, right?  Here is my recommended change to that
>file:
>
>sed -i \
>    -e "s/[ 	]*$//" \
>    -e "/^export BINDIR/ s:/games$:/bin:" \
>    -e "/^export datadir/ s:/games/:/:" Makefile.in
>
>1. trim trailing white-space (always a good idea)
>2. Fix BINDIR
>3. Fix datadir
>
>both 2 and 3 make it the packager's responsibility to get things right -
>as it should be.

Yes, Makefile.in is a labour of some love and significant amounts of pure
hate. I did the changes you suggest, but I haven't yet tried to build and
install something using the new Makefile.

>Yes, exactly.  Getting the install paths right and so forth isn't your
>responsibility as the authors of the software, go ahead and leave that up
>the to packagers.  Just make it possible for the packagers to get it right.

Ok, done. I'm "maintaining" a Debian package, and changing that to fit the
new scheme should be trivial. Not that anyone has ever installed those
packages. :)

-- 
      Real children don't go hoppity-skip unless they are on drugs.
                          -- Susan Sto Helit, in Hogfather (Terry Pratchett)

On Mon, 22 Sep 2003, Jan Ekholm wrote:

> >is also not very nice to work with.  To provide the greatest flexibility
> >to people making packages for civil, I believe it should be
> >
> >datadir = @datadir@/civil
> 
> Ok. This was my interpretation of the LSB so that games related stuff come
> under /usr/share/games/. datadir is usually @prefix@/share/, so if one

From my limited experience, this seems to be a packager's problem from 
the LSB side. I.e., ./configure just throws the files into the 
standard /usr/local/xxx places, and if somebody wants it elsewhere 
then they have to explicitely give the propert --bindir and --datadir 
declarations. And this seems to be the case with especially 
games-related stuff, ./configure by default doesn't give the 
"LSB-correct" information.

> wants to add /games/ in there too it has to be given somewhere so that the
> installation compiles with the LSB even if the user gives *no* --datadir
> when configuring, like:
> 
> 	% ./configure && make install

This, quite naturally, ought to work.

> Yes, you are correct, but I don't really know how to fix it. Any ideas?
> Just leave out the /games/ part and have everyone just supply a proper
> --datadir?

+1, it it works out-of-the-box (./configure && make install) but also
enables packagers to provide suitable directories.

Btw, does this mean Gentoo will package civil?

Marcus

Wow, thanks for the quick reply...

On Mon, 22 Sep 2003, Jan Ekholm wrote:

> On Mon, 22 Sep 2003, Michael Sterrett -Mr. Bones.- wrote:
> 
> >Sorry for the mass email, but the AUTHORS file for civil-0.82 doesn't
> >mention who is responsible for the configure script and related files.
> 
> The guilty one would be me.

Great!  Thanks for stepping forward. ;-)

> >The current setup in Makefile.in makes is difficult to package civil
> >since there doesn't seem to be an easy way to really specify the bindir.
> >Passing --bindir=/usr/games/bin to configure doesn't work since the
> >Makefile.in file shows BINDIR = $(prefix)/games.  This is bad form since
> >it prevents package makers (that's me) from specifying the exact location
> >in which to install the binaries.  BINDIR should be $(prefix)/bin
> 
> Hm, I understand the problem. But I don't really know any other way of
> getting the autoconf variables "into" the Makefile otherwise. The whole
> autoconf thingie is IMNSHO a steaming pile of junk. But I can try to
> change the thing to not make any assumptions other than that @prefix@ is
> set, and not add anything "own" to that.

Makefile.in is hand-created, right?  Here is my recommended change to that
file:

sed -i \
    -e "s/[ 	]*$//" \
    -e "/^export BINDIR/ s:/games$:/bin:" \
    -e "/^export datadir/ s:/games/:/:" Makefile.in

1. trim trailing white-space (always a good idea)
2. Fix BINDIR
3. Fix datadir

both 2 and 3 make it the packager's responsibility to get things right -
as it should be.

> Ok. This was my interpretation of the LSB so that games related stuff come
> under /usr/share/games/. datadir is usually @prefix@/share/, so if one
> wants to add /games/ in there too it has to be given somewhere so that the
> installation compiles with the LSB even if the user gives *no* --datadir
> when configuring, like:
> 
> 	% ./configure && make install

It's true that the FHS and others recommend putting the games stuff in
certain places, but that's up to the packagers for each OS to get right.
The job of the upstream author is to make the packager's job possible.
There should be as little policy as possible in the files as they are
delivered.

For Gentoo Linux, games are configured like so:

    ./configure \
	--prefix=${GAMES_PREFIX} \
	--host=${CHOST} \
	--mandir=/usr/share/man \
	--infodir=/usr/share/info \
	--datadir=${GAMES_DATADIR} \
	--sysconfdir=${GAMES_SYSCONFDIR} \
	--localstatedir=${GAMES_STATEDIR} \

Where:

GAMES_PREFIX="/usr/games"
GAMES_DATADIR="/usr/share/games"
GAMES_SYSCONFDIR="/etc/games"
GAMES_STATEDIR="/var/games"

You can see that most common options probably fit into the FHS pretty well.

> >It shouldn't be assumed that /games/ will appear in the installed paths.
> >It would be nice if these items could be addressed for future releases.
> 
> Yes, you are correct, but I don't really know how to fix it. Any ideas?
> Just leave out the /games/ part and have everyone just supply a proper
> --datadir?

Yes, exactly.  Getting the install paths right and so forth isn't your
responsibility as the authors of the software, go ahead and leave that up
the to packagers.  Just make it possible for the packagers to get it right.

Thanks again,

Michael Sterrett
  -Mr. Bones.-
mst...@ge...

On Mon, 22 Sep 2003, Michael Sterrett -Mr. Bones.- wrote:

>Sorry for the mass email, but the AUTHORS file for civil-0.82 doesn't
>mention who is responsible for the configure script and related files.

The guilty one would be me.

>The current setup in Makefile.in makes is difficult to package civil
>since there doesn't seem to be an easy way to really specify the bindir.
>Passing --bindir=/usr/games/bin to configure doesn't work since the
>Makefile.in file shows BINDIR = $(prefix)/games.  This is bad form since
>it prevents package makers (that's me) from specifying the exact location
>in which to install the binaries.  BINDIR should be $(prefix)/bin

Hm, I understand the problem. But I don't really know any other way of
getting the autoconf variables "into" the Makefile otherwise. The whole
autoconf thingie is IMNSHO a steaming pile of junk. But I can try to
change the thing to not make any assumptions other than that @prefix@ is
set, and not add anything "own" to that.

>While I'm here I should mention that
>
>datadir = @datadir@/games/civil
>
>is also not very nice to work with.  To provide the greatest flexibility
>to people making packages for civil, I believe it should be
>
>datadir = @datadir@/civil

Ok. This was my interpretation of the LSB so that games related stuff come
under /usr/share/games/. datadir is usually @prefix@/share/, so if one
wants to add /games/ in there too it has to be given somewhere so that the
installation compiles with the LSB even if the user gives *no* --datadir
when configuring, like:

	% ./configure && make install

>It shouldn't be assumed that /games/ will appear in the installed paths.
>It would be nice if these items could be addressed for future releases.

Yes, you are correct, but I don't really know how to fix it. Any ideas?
Just leave out the /games/ part and have everyone just supply a proper
--datadir?

-- 
  +++ Divide By Cucumber Error. Please Reinstall Universe And Reboot +++
                                        -- Terry Pratchett, Hogfather

>Heh, maybe we shoul turn Civil into a code repository. There *are* huge
>amounts of pretty sexy stuff in there, after all. :)

Hehe, I think it's a huge repository already ;)

On Thu, 11 Sep 2003, Gareth Noyce wrote:

>>  So thanks for the code :-) I will be using
>>widget/widget_manager/dispatcher. Although I think I will reimplement
>>button and other widgets.
>
>The mighty Chakie code strikes again :D

Heh, maybe we shoul turn Civil into a code repository. There *are* huge
amounts of pretty sexy stuff in there, after all. :)

-- 
  Om began to feel the acute depression that steals over every realist
       in the presence of an optimist.
                                        -- Terry Pratchett, Small Gods

>  So thanks for the code :-) I will be using
>widget/widget_manager/dispatcher. Although I think I will reimplement
>button and other widgets.

The mighty Chakie code strikes again :D

G

Hi,
  I was porting one game to pygame (http://teg.sf.net), but I found that
there was no
  toolkit in pygame, so I started my own toolkit and looking in others
  projects code to borrow some ideas.

  And then I found Civil :-) and realized that there was no point in 
  coding a new toolkit.

  So thanks for the code :-) I will be using
widget/widget_manager/dispatcher. Although I think I will reimplement
button and other widgets.


riq.


-- 
Ricardo Quesada <ri...@ve...>

<html>
<body bgcolor=3D"#ffffff">
<center>
<font face=3D"verdana" size=3D"1" color=3D"#000000"><a href=3D"http://www.=
go-mtg.com/mortgage/conf/rm.html"<font face=3D"verdana" size=3D"1"
color=3D=
"#999999">click here
</a>to be removed from future mailings.</font><br>
<table border=3D"0" cellpadding=3D"3" cellspacing=3D"0">
 <tr>
  <td bgcolor=3D"#000000">
   <table bgcolor=3D"#FFFBE0" border=3D"0" width=3D"470" cellpadding=3D"8"=
 cellspacing=3D"0">
    <tr>
     <td align=3D"center">
      <a href=3D"http://www.go-mtg.com/mortgage/conf/"><font face=3D"verda=
na" size=3D"5" color=3D"#ff0000"><b>Conference Calls</font>
      <br><font face=3D"verdana" size=3D"4" color=3D"#ff0000"><i>Only 15 C=
ents Per Min.</a></i></b>
<br>
(Long Distance Included)
</font></td>
    </tr>
    <tr>
     <td align=3D"left">
      <font face=3D"verdana" size=3D"2" color=3D"#000000">We offer an extr=
emely easy to use conferencing service that only costs a fraction of what
      most companies charge.  
<br>
<br>
<b>No Set-up Fees 
<br>
No Contracts or Monthly Fees
      </font>
     </td>
    </tr>
   </b>
<tr>
  <td align=3D"center">
    <font face=3D"verdana" size=3D"3 color=3D"#000000"><b>Also Broadcast Y=
our Conference Call Over <br>The Internet - Only <u>8 Cents</u> Per Minute=
  <br>Great For International Participants.
</font></td></tr>
<tr>
  <td align=3D"center">
    <a href=3D"http://www.go-mtg.com/mortgage/conf/"><font face=3D"verdana=
" size=3D"4" color=3D"#ff0000"><b>Click Here For More Info</b></font></a>
     </font></td>
    </tr>
   </table>
  </td>
 </tr>
</table>
</center>
</body>
</html>
rzu uuczhmvkodagavpsklgeigvcjfatipr gicllne
nxqkggoot
qnjloy y qk