[go: up one dir, main page]
Menu ▾ ▴

#1025 CDK uses a modified Jumbo library but does not share source

cdk-1.2.x
closed
Egon Willighagen
None
5
2012-11-03
2009-12-07
Egon Willighagen
No

The source of the patch by jonalv is not being distributed as required by the Jumbo Artistic License.

Discussion

  • Andrew Dalke

    Andrew Dalke - 2009-12-12

    To make things all the more fun, LICENSE.txt in CDK says

    Any distribution must acknowledge the origins and also include copies
    of the JUMBO source (see Artistic License for details). You may not
    claim that a modified version is a compliant CML system and may not
    assert that it reads or writes CML.

    which may mean that CDK cannot claim CML support, at least not while using the JUMBO code.

     

  • Egon Willighagen

    Egon Willighagen - 2009-12-12

    Andrew, which version have you checked? Both 1.2.x and 1.3.x use CMLDOM by now, and no longer the patched Jumbo version...

    Meanwhile, I will still dig up the patch.

     

  • Jonathan Alvarsson

    Jonathan Alvarsson - 2009-12-14

    Here is the SVN diff of what I made:

    svn diff
    Index: src/main/java/org/xmlcml/euclid/Util.java
    ===================================================================
    --- src/main/java/org/xmlcml/euclid/Util.java (revision 861)
    +++ src/main/java/org/xmlcml/euclid/Util.java (working copy)
    @@ -%ld,%ld +%ld,%ld @@
    public static URL getResource(String filename) {
    URL url = null;
    if (filename != null) {
    - ClassLoader l = Thread.currentThread().getContextClassLoader();
    + ClassLoader l = Util.class.getClassLoader();
    url = l.getResource(filename);
    if (url == null) {
    throw new RuntimeException("No resource with name " + filename);

     

  • Egon Willighagen

    Egon Willighagen - 2009-12-14

    Andrew, with the patch now dug up (thanx, Jonathan!), I'll consider this bug resolved.