[go: up one dir, main page]
Menu ▾ ▴

#195 Some smaller CMake improvements

0.3.2
done
nobody
None
nobody
2020-08-31
2020-06-11
Ulf Lorenz
No

There are some things that could be improved in the Cmake code

  • CMake offers support to figure out if a compiler needs to link std::filesystem as a separate library. use that in doing so conditionally.
  • Ctest should ensure that a Python test and its equivalent C++ test never run in parallel, otherwise they overwrite each other's output files, leading to spurious failures. Alternatively, the two tests could write to different output directories.

Discussion

  • Ulf Lorenz

    Ulf Lorenz - 2020-07-31
    • Milestone: 0.4 goal --> 0.3.2
     

  • Ulf Lorenz

    Ulf Lorenz - 2020-08-30
    • status: open --> assigned
    • assigned_to: Ulf Lorenz
     

  • Ulf Lorenz

    Ulf Lorenz - 2020-08-31
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -2,3 +2,8 @@

 * CMake offers support to figure out if a compiler needs to link std::filesystem as a separate library. use that in doing so conditionally.
 * Ctest should ensure that a Python test and its equivalent C++ test never run in parallel, otherwise they overwrite each other's output files, leading to spurious failures. Alternatively, the two tests could write to different output directories.
+
+----
+
+* Python tests write to a different output directory; seemed like the cleaner and simpler solution
+* CMake does not offer a good solution for the std::filesystem problem, see https://gitlab.kitware.com/cmake/cmake/-/issues/17834
    • status: assigned --> done
    • assigned_to: Ulf Lorenz --> nobody
     

Log in to post a comment.