[go: up one dir, main page]

Menu

#39 multiple definitions error

1.9
closed-fixed
nobody
None
5
2020-05-28
2020-05-20
No

gcc 10 fails the viking 1.8 build without this patch to make some global vars extern.

1 Attachments

Discussion

  • Rob Norris

    Rob Norris - 2020-05-21

    Thank you for posting this.

    I think however instead of this quick fix (which is quite usable for anyone coming across this issue), I will change it in a more robust manner for inclusion in the source repository.

    I intend to move the data from the header into the .c file and then create and use an accessor function for where data is used in a few places elsewhere.
    i.e. it's not good practice to put data in the header and is not done anywhere else in Viking.
    This appears to be quite straight-forward.

     
  • Rob Norris

    Rob Norris - 2020-05-28

    The fuller fix has been applied in commit: 7883ec0d1d752b1afc1a9a488228711f30657fcf

     
  • Rob Norris

    Rob Norris - 2020-05-28
    • status: open --> closed-fixed
     

Log in to post a comment.