VICE / Patches / #359 PRINTER-DRV: fix crash when initializing 1520

#359 PRINTER-DRV: fix crash when initializing 1520

Milestone: v3.x

Status: pending-accepted

Owner: gpz

Labels: None

Category: bugfix

Updated: 2023-04-08

Created: 2023-04-07

Creator: Carlo Bramini

Private: No

After buiding latest sources, VICE brutally crashes immediately after run on my PC.
This happens because there is a bug into drv-1520.
In function drv_1520_init_resources(), the pointer to drv_select is not initialized and not NULL in debug mode. As result, the emulators tried to call that invalid pointer, causing the crash.
While looking to this issue, I also noticed that also drv-ascii and drv-raw have a redundand initialization of drv_select, so I removed the useless one.
Attached patch fixes the issue.

Discussion

Carlo Bramini - 2023-04-07

The patch.

fix-printer-drv-crash.txt

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Querino - 2023-04-07

yes, i noticed this too, related to

https://sourceforge.net/p/vice-emu/code/43621/

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

gpz - 2023-04-08

applied in r43652, thanks!

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

gpz - 2023-04-08

status: open --> pending-accepted

assigned_to: gpz
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

PRINTER-DRV: fix crash when initializing 1520

Versatile Commodore Emulator

Version

Searches

Help

#359 PRINTER-DRV: fix crash when initializing 1520

Discussion