[go: up one dir, main page]

Menu

#1952 C1541 chain command no last sector length

v3.7
closed-fixed
None
GTK3
c1541
2023-10-12
2023-10-11
No

Use C1541 to open a disk image with a known prg file longer than one block, use the chain command to list the track/sector pairs. The last number displayed should be the number of bytes used in the last block, however there is no number displayed. The bug looks like it's here, that comparison should be ==0 not >0
https://sourceforge.net/p/vice-emu/code/HEAD/tree/trunk/vice/src/c1541.c#l2239

e.g. I see this:

c1541 #8> chain screen3
(12,19) -> (11, 0) -> (11,10) -> c1541 #8>

Discussion

  • Olaf Seibert

    Olaf Seibert - 2023-10-11

    Yep, good catch.
    I'll remove the condition completely, since after the loop we're sure that track > 0 is not true.
    Should be fixed in r44577.

     
    • Martin Piper

      Martin Piper - 2023-10-12

      Cool. There is a rare chance that "cyclic reference found to" will break out so track might be >0, but in that case it really doesn't matter what the final print is, it's going to be wrong anyway.

       
  • Olaf Seibert

    Olaf Seibert - 2023-10-11
    • status: open --> pending-fixed
     
  • Olaf Seibert

    Olaf Seibert - 2023-10-12
    • status: pending-fixed --> closed-fixed
    • assigned_to: Olaf Seibert
     

Log in to post a comment.