VICE / Bugs / #1920 Noise init does not match real 8580 SID chips

Querino - 2023-07-26

https://sourceforge.net/p/vice-emu/code/31615/

👍
1

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

gpz - 2023-07-27

assigned_to: Dag Lem
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

gpz - 2023-07-27

It would be good to have this tested on 6581s too - what does it show on these? AFAIK this part of the chip is all digital, so it should be the same...

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Fredrik - 2023-07-27

I have tested these routines on one real 6581 and 6581 in VICE 2.4 r31587 and it produces the same result as 8580 but I have tested similar routines on other real 6581 and I think there are some 6581 that actually does not produce a stable result.

Last edit: Fredrik 2023-07-27

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

gpz - 2023-07-30

For those unfamiliar with kickass, here are the binaries

👍
2

scan.prg

simple.prg

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Leandro Nini - 2023-08-09

They're not random values, just different from what expected.

From the schematics I'd say that when the test bit is set the writeback actually happens but only affects the latched value which becomes active once the test bit falls. So the code is still wrong as it was before the mentioned change.
Unfortunately all my attempts to fix the shift register writeback and improve the testsuite results have failed miserably up to now.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Found the actual problem. It was there to fix a few tests of the noise writeback suite but it looks like the problem is elsewhere.

--- a/src/resid/wave.cc
+++ b/src/resid/wave.cc
@@ -174,9 +174,11 @@ bool do_pre_writeback(reg8 waveform_prev, reg8 waveform, bool is6581)
     // no writeback without combined waveforms
     if (likely(waveform_prev <= 0x8))
         return false;
+#if 0
     // This need more investigation
     if (waveform == 8)
         return false;
+#endif
     if (waveform_prev == 0xc) {
         if (is6581)
             return false;

Too bad this breaks SID/noisewriteback/D1_+_81_wave_test.sid :(

Last edit: Leandro Nini 2023-08-17

gpz - 2023-08-19

testprog adapted for the testbench (in SID/noiselfsrinit/), patch comitted in r44434

@Fredrik please test again.... and don't hesitate to provide another test program if needed :)

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Fredrik - 2023-10-29
  
  Tested with r44434 and it works great! Good job!
  
  If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

gpz - 2023-08-19

status: open --> pending-fixed

Port: GTK3 -->
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Noise init does not match real 8580 SID chips

Versatile Commodore Emulator

Version

Searches

Help

#1920 Noise init does not match real 8580 SID chips

Discussion