[go: up one dir, main page]

Menu

#62 No more Missile(0) on mounts

SVN
closed-accepted
Klauss++
5
2013-07-27
2013-07-21
No

Fixes "Missile (0)" stuck after missiles are spent (which caused [bug:#638]) - now mounts with all missiles fired are seen as empty - and thus aren't selectable for that matter..

Related

Bugs: #638

Discussion

  • Turbo Beholder

    Turbo Beholder - 2013-07-21

    Mounts need a little overhaul anyway, but hey, this fixes the bug.

    (edit): using the same function prevents weirdness with swarms.

     

    Last edit: Turbo Beholder 2013-07-22
  • Vincent Legoll

    Vincent Legoll - 2013-07-25

    I have not read enough of the surrounding code to make a real review of the patch, but I think mixing whitespace churn within makes the review process harder.

    Don't take me wrong, I am in favor of fixing whitespace damage (I'm a python guy...) but I prefer seeing them in a separate patch that is very obviously not making any other changes.

     
    • Turbo Beholder

      Turbo Beholder - 2013-07-26

      Well, yeah. I just don't always bother to cut out the hunks with "\n " because then they'll pop up every time.

       
  • Klauss++

    Klauss++ - 2013-07-27
    • status: open --> closed-accepted
    • assigned_to: Klauss++
     

Log in to post a comment.