Menu
▾
▴
#508 loading/saving game with SVN r12564 loads you into dumbfire
I've build VS from SVN r12564 on a ubuntu 9.04 32-bit system. The problem is that after loading a saved game, you are flying inside a dumbfire missile with
Steps to reproduce:
1. Delete ~/.vegastrike
2. build VS from SVN r12564
3. launch game and immediately save the game, call it "immediatesave"
4. This creates a savegame file for your game - AND creates an AUTOSAVE file (it probably shouldn't do that either?)
5. Load the savegame.
Discussion
Anonymous
VS screenshot
output for saving the game (then closing VS)
output after loading the saved game
--- savegame.cpp 2009-10-26 22:36:26.000000000 +0100
+++ /tmp/savegame-HEAD.2.cpp 2009-10-26 22:29:15.000000000 +0100
@@ -833,7 +833,7 @@
{
VSFile f;
VSError err = f.OpenCreateWrite( outputsavegame, SaveFile);
- if(err <= Ok)
+ if(err > Ok)
{// check
// WRITE THE SAVEGAME TO THE MISSION SAVENAME
f.Write( savestring.c_str(), savestring.length());
file in the trunk might be as it is for a reason? (can't figure on though)
see the comment of revision 12564 of trunk/vegastrike/src/savegame.cpp (http://vegastrike.svn.sourceforge.net/viewvc/vegastrike?view=rev&revision=12564), which explicitly states the :
>> Note: inconsistent checks of error condition are present. (>Ok vs <= Ok), which may cause consistency issues in the future.
Bug is fix in svn r12565
Probably fixed independently (ie: before I read this report)