Messages in this thread |  | | Date | Wed, 25 Sep 2013 19:27:10 +0200 | | From | Alexander Holler <> | | Subject | Re: [PATCH] checkpatch: Find CamelCase definitions of struct/union/enum |
| |
Am 25.09.2013 18:19, schrieb Al Viro: > On Wed, Sep 25, 2013 at 08:35:44AM -0700, Joe Perches wrote: > >> We disagree. > > Obviously. > >> I think Propercase should be discouraged. >> ie: Qdisc et al. > > Excuse me, but "Joe happens to think that something should be discouraged" > is not a problem. "Joe uses checkpatch.pl as force multiplier, recruiting > hundreds of monkeys to enforce his personal preferences", OTOH, very much is. > > You are calling for ban on any mixed-case identifiers. I see at least three > cases where they can be legitimate: > * labels a-la Enomem, etc. I've been using those and I will > keep doing so, checkpatch.pl and its users be damned. > * enum members, to distinguish those from defines (first letter > capitalized vs. all-caps). > * (local) typedefs for structs; I really don't like their use for > anything non-local, but IMO they have their uses in cases like e.g. > fs/binfmt_misc.c
Besides that CamelCase is one character less long than camel_case.
I'm awaiting kernel developer uniforms. There are too many different black t-shirts around. ;)
Regards,
Alexander Holler
|  |