Messages in this thread |  | | Date | Mon, 16 Sep 2013 11:30:38 -0700 | | From | John Stultz <> | | Subject | Re: [PATCH] Time: Clocksource: fix 'ret' data type of sysfs_override_clocksource() and sysfs_unbind_clocksource() |
| |
On 09/12/2013 03:28 AM, elad.wexler@gmail.com wrote: > From: Elad Wexler <elad.wexler@gmail.com> > > sysfs_override_clocksource(): The expression 'if (ret >= 0)' is always true. > This will cause clocksource_select() to always run. > Thus modified ret to be of type ssize_t. > > sysfs_unbind_clocksource(): The expression 'if (ret < 0)' is always false. > So in case sysfs_get_uname() failed, the expression won't take an effect. > Thus modified ret to be of type ssize_t. > > Signed-off-by: Elad Wexler <elad.wexler@gmail.com>
Queued for 3.13.
thanks -john
|  |