From adc45dd8cdb25f591cdf6f23b28d72a250afbecc Mon Sep 17 00:00:00 2001
From: Hangyi Wu <hangyi.wu@cern.ch>
Date: Thu, 20 Jun 2024 04:36:22 +0200
Subject: [PATCH 1/9] feat: add qmt test for UTTrackResidualMonitor

pre-commit fixes

patch generated by https://gitlab.cern.ch/lhcb/Moore/-/jobs/51252554
---
 Hlt/RecoConf/options/UT_unbiased_residual.py  | 54 +++++++++++++++++++
 .../performance.qms/UT_unbiased_residual.qmt  | 32 +++++++++++
 2 files changed, 86 insertions(+)
 create mode 100644 Hlt/RecoConf/options/UT_unbiased_residual.py
 create mode 100644 Hlt/RecoConf/tests/qmtest/performance.qms/UT_unbiased_residual.qmt

diff --git a/Hlt/RecoConf/options/UT_unbiased_residual.py b/Hlt/RecoConf/options/UT_unbiased_residual.py
new file mode 100644
index 00000000000..d7fa068f723
--- /dev/null
+++ b/Hlt/RecoConf/options/UT_unbiased_residual.py
@@ -0,0 +1,54 @@
+###############################################################################
+# (c) Copyright 2022 CERN for the benefit of the LHCb Collaboration           #
+#                                                                             #
+# This software is distributed under the terms of the GNU General Public      #
+# Licence version 3 (GPL Version 3), copied verbatim in the file "COPYING".   #
+#                                                                             #
+# In applying this licence, CERN does not waive the privileges and immunities #
+# granted to it by virtue of its status as an Intergovernmental Organization  #
+# or submit itself to any jurisdiction.                                       #
+###############################################################################
+
+from Moore import options
+from PyConf.Algorithms import (
+    PrKalmanFilter,
+    UTTrackResidualMonitor_PrKalman,
+    VeloRetinaClusterTrackingSIMD,
+)
+from RecoConf.config import Reconstruction, run_reconstruction
+from RecoConf.hlt2_global_reco import make_light_reco_pr_kf
+from RecoConf.hlt2_global_reco import reconstruction as hlt2_reconstruction
+from RecoConf.legacy_rec_hlt1_tracking import (
+    get_default_ut_clusters,
+    make_PatPV3DFuture_pvs,
+    make_PrStorePrUTHits_hits,
+    make_reco_pvs,
+    make_VeloClusterTrackingSIMD,
+)
+
+options.histo_file = options.getProp("histo_file") or "hlt2_UT_unbiased_residual.root"
+
+
+def ut_unbiased_residual():
+    with (
+        PrKalmanFilter.bind(FillFitResult=True),
+        make_VeloClusterTrackingSIMD.bind(algorithm=VeloRetinaClusterTrackingSIMD),
+        make_reco_pvs.bind(make_pvs_from_velo_tracks=make_PatPV3DFuture_pvs),
+    ):
+        reco = hlt2_reconstruction(make_reconstruction=make_light_reco_pr_kf)
+
+    all_UT_pr_hits = make_PrStorePrUTHits_hits()
+
+    monitorList = []
+    mon_hit_on_track = UTTrackResidualMonitor_PrKalman(
+        name="UTTrackResidualMonitor_HitOnTrack",
+        TracksInContainer=reco["AllTrackHandles"]["BestLong"]["v1"],
+        UTHitsLocation=all_UT_pr_hits,
+        TrueUnbiased=False,  # set to True will use hits which are not on track
+        FullDetail=True,
+    )
+    monitorList.append(mon_hit_on_track)
+    return Reconstruction("ut_unbiased_residual", monitorList, [])
+
+
+run_reconstruction(options, ut_unbiased_residual)
diff --git a/Hlt/RecoConf/tests/qmtest/performance.qms/UT_unbiased_residual.qmt b/Hlt/RecoConf/tests/qmtest/performance.qms/UT_unbiased_residual.qmt
new file mode 100644
index 00000000000..13633f49f85
--- /dev/null
+++ b/Hlt/RecoConf/tests/qmtest/performance.qms/UT_unbiased_residual.qmt
@@ -0,0 +1,32 @@
+<?xml version="1.0" encoding="UTF-8"?><!DOCTYPE extension  PUBLIC '-//QM/2.3/Extension//EN'  'http://www.codesourcery.com/qm/dtds/2.3/-//qm/2.3/extension//en.dtd'>
+<!--
+    (c) Copyright 2022 CERN for the benefit of the LHCb Collaboration
+
+    This software is distributed under the terms of the GNU General Public
+    Licence version 3 (GPL Version 3), copied verbatim in the file "COPYING".
+
+    In applying this licence, CERN does not waive the privileges and immunities
+    granted to it by virtue of its status as an Intergovernmental Organization
+    or submit itself to any jurisdiction.
+-->
+<extension class="GaudiTest.GaudiExeTest" kind="test">
+<argument name="program"><text>gaudirun.py</text></argument>
+<argument name="use_temp_dir"><enumeral>true</enumeral></argument>
+<argument name="timeout"><integer>1200</integer></argument>
+<argument name="args"><set>
+<text>$MOOREROOT/tests/options/default_input_and_conds_hlt2.py</text>
+<text>$RECOCONFROOT/options/UT_unbiased_residual.py</text>
+  </set></argument>
+<argument name="reference"><text>../refs/UT_unbiased_residual.ref</text></argument>
+<argument name="error_reference"><text>../refs/empty.ref</text></argument>
+<argument name="validator"><text>
+
+from Moore.qmtest.exclusions import ref_preprocessor
+validateWithReference(preproc = ref_preprocessor)
+
+from Moore.qmtest.exclusions import remove_known_warnings
+countErrorLines({"FATAL": 0, "ERROR": 0, "WARNING": 0},
+                stdout=remove_known_warnings(stdout))
+
+</text></argument>
+</extension>
-- 
GitLab


From 573f18e13078b77ed875535a26cd893ef3dec0a8 Mon Sep 17 00:00:00 2001
From: Hangyi Wu <hangyi.wu@cern.ch>
Date: Wed, 19 Feb 2025 04:15:53 +0000
Subject: [PATCH 2/9] Apply 1 suggestion(s) to 1 file(s)

Co-authored-by: Miroslav Saur <miroslav.saur@cern.ch>
---
 .../tests/qmtest/performance.qms/UT_unbiased_residual.qmt       | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Hlt/RecoConf/tests/qmtest/performance.qms/UT_unbiased_residual.qmt b/Hlt/RecoConf/tests/qmtest/performance.qms/UT_unbiased_residual.qmt
index 13633f49f85..b7d059bb86f 100644
--- a/Hlt/RecoConf/tests/qmtest/performance.qms/UT_unbiased_residual.qmt
+++ b/Hlt/RecoConf/tests/qmtest/performance.qms/UT_unbiased_residual.qmt
@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?><!DOCTYPE extension  PUBLIC '-//QM/2.3/Extension//EN'  'http://www.codesourcery.com/qm/dtds/2.3/-//qm/2.3/extension//en.dtd'>
 <!--
-    (c) Copyright 2022 CERN for the benefit of the LHCb Collaboration
+    (c) Copyright 2025 CERN for the benefit of the LHCb Collaboration
 
     This software is distributed under the terms of the GNU General Public
     Licence version 3 (GPL Version 3), copied verbatim in the file "COPYING".
-- 
GitLab


From 40dba77cb9167fe380e04e869d599b53dca59cad Mon Sep 17 00:00:00 2001
From: Hangyi Wu <hangyi.wu@cern.ch>
Date: Wed, 19 Feb 2025 04:16:17 +0000
Subject: [PATCH 3/9] Apply 1 suggestion(s) to 1 file(s)

Co-authored-by: Miroslav Saur <miroslav.saur@cern.ch>
---
 Hlt/RecoConf/options/UT_unbiased_residual.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Hlt/RecoConf/options/UT_unbiased_residual.py b/Hlt/RecoConf/options/UT_unbiased_residual.py
index d7fa068f723..b1a4bc502b2 100644
--- a/Hlt/RecoConf/options/UT_unbiased_residual.py
+++ b/Hlt/RecoConf/options/UT_unbiased_residual.py
@@ -1,5 +1,5 @@
 ###############################################################################
-# (c) Copyright 2022 CERN for the benefit of the LHCb Collaboration           #
+# (c) Copyright 2025 CERN for the benefit of the LHCb Collaboration           #
 #                                                                             #
 # This software is distributed under the terms of the GNU General Public      #
 # Licence version 3 (GPL Version 3), copied verbatim in the file "COPYING".   #
-- 
GitLab


From cff6202e85b011e889ffd754038ae59caf5528b7 Mon Sep 17 00:00:00 2001
From: Hangyi Wu <hangyi.wu@cern.ch>
Date: Sun, 13 Apr 2025 16:29:33 +0200
Subject: [PATCH 4/9] fix: remove 1200 seconds timeout

---
 .../tests/qmtest/performance.qms/UT_unbiased_residual.qmt        | 1 -
 1 file changed, 1 deletion(-)

diff --git a/Hlt/RecoConf/tests/qmtest/performance.qms/UT_unbiased_residual.qmt b/Hlt/RecoConf/tests/qmtest/performance.qms/UT_unbiased_residual.qmt
index b7d059bb86f..afc6be63c1b 100644
--- a/Hlt/RecoConf/tests/qmtest/performance.qms/UT_unbiased_residual.qmt
+++ b/Hlt/RecoConf/tests/qmtest/performance.qms/UT_unbiased_residual.qmt
@@ -12,7 +12,6 @@
 <extension class="GaudiTest.GaudiExeTest" kind="test">
 <argument name="program"><text>gaudirun.py</text></argument>
 <argument name="use_temp_dir"><enumeral>true</enumeral></argument>
-<argument name="timeout"><integer>1200</integer></argument>
 <argument name="args"><set>
 <text>$MOOREROOT/tests/options/default_input_and_conds_hlt2.py</text>
 <text>$RECOCONFROOT/options/UT_unbiased_residual.py</text>
-- 
GitLab


From f558f5527df527cae7991f2cb568e800a96bbc60 Mon Sep 17 00:00:00 2001
From: Miroslav Saur <miroslav.saur@cern.ch>
Date: Mon, 14 Apr 2025 13:39:44 +0800
Subject: [PATCH 5/9] Adding empty reference files for UT_unbiased_residual.qmt

---
 Hlt/RecoConf/tests/refs/UT_unbiased_residual.ref               | 0
 Hlt/RecoConf/tests/refs/UT_unbiased_residual.ref.x86_64_v3-opt | 0
 2 files changed, 0 insertions(+), 0 deletions(-)
 create mode 100644 Hlt/RecoConf/tests/refs/UT_unbiased_residual.ref
 create mode 100644 Hlt/RecoConf/tests/refs/UT_unbiased_residual.ref.x86_64_v3-opt

diff --git a/Hlt/RecoConf/tests/refs/UT_unbiased_residual.ref b/Hlt/RecoConf/tests/refs/UT_unbiased_residual.ref
new file mode 100644
index 00000000000..e69de29bb2d
diff --git a/Hlt/RecoConf/tests/refs/UT_unbiased_residual.ref.x86_64_v3-opt b/Hlt/RecoConf/tests/refs/UT_unbiased_residual.ref.x86_64_v3-opt
new file mode 100644
index 00000000000..e69de29bb2d
-- 
GitLab


From eb24af84536bcc7db2e674032ae856b73ce8760e Mon Sep 17 00:00:00 2001
From: Hangyi Wu <hangyi.wu@cern.ch>
Date: Tue, 15 Apr 2025 01:29:20 +0200
Subject: [PATCH 6/9] fix: remove template in UTTrackResidualMonitor

---
 Hlt/RecoConf/options/UT_unbiased_residual.py | 16 +++++++++-------
 1 file changed, 9 insertions(+), 7 deletions(-)

diff --git a/Hlt/RecoConf/options/UT_unbiased_residual.py b/Hlt/RecoConf/options/UT_unbiased_residual.py
index b1a4bc502b2..91ceb8a93f8 100644
--- a/Hlt/RecoConf/options/UT_unbiased_residual.py
+++ b/Hlt/RecoConf/options/UT_unbiased_residual.py
@@ -12,7 +12,7 @@
 from Moore import options
 from PyConf.Algorithms import (
     PrKalmanFilter,
-    UTTrackResidualMonitor_PrKalman,
+    UTTrackResidualMonitor,
     VeloRetinaClusterTrackingSIMD,
 )
 from RecoConf.config import Reconstruction, run_reconstruction
@@ -26,26 +26,28 @@ from RecoConf.legacy_rec_hlt1_tracking import (
     make_VeloClusterTrackingSIMD,
 )
 
-options.histo_file = options.getProp("histo_file") or "hlt2_UT_unbiased_residual.root"
+options.histo_file = options.getProp(
+    "histo_file") or "hlt2_UT_unbiased_residual.root"
 
 
 def ut_unbiased_residual():
     with (
-        PrKalmanFilter.bind(FillFitResult=True),
-        make_VeloClusterTrackingSIMD.bind(algorithm=VeloRetinaClusterTrackingSIMD),
-        make_reco_pvs.bind(make_pvs_from_velo_tracks=make_PatPV3DFuture_pvs),
+            PrKalmanFilter.bind(FillFitResult=True),
+            make_VeloClusterTrackingSIMD.bind(
+                algorithm=VeloRetinaClusterTrackingSIMD),
+            make_reco_pvs.bind(
+                make_pvs_from_velo_tracks=make_PatPV3DFuture_pvs),
     ):
         reco = hlt2_reconstruction(make_reconstruction=make_light_reco_pr_kf)
 
     all_UT_pr_hits = make_PrStorePrUTHits_hits()
 
     monitorList = []
-    mon_hit_on_track = UTTrackResidualMonitor_PrKalman(
+    mon_hit_on_track = UTTrackResidualMonitor(
         name="UTTrackResidualMonitor_HitOnTrack",
         TracksInContainer=reco["AllTrackHandles"]["BestLong"]["v1"],
         UTHitsLocation=all_UT_pr_hits,
         TrueUnbiased=False,  # set to True will use hits which are not on track
-        FullDetail=True,
     )
     monitorList.append(mon_hit_on_track)
     return Reconstruction("ut_unbiased_residual", monitorList, [])
-- 
GitLab


From c7a4cae37dae60a7a9839873bc3fd5b4b09aaca4 Mon Sep 17 00:00:00 2001
From: Hangyi Wu <hangyi.wu@cern.ch>
Date: Thu, 17 Apr 2025 20:17:48 +0200
Subject: [PATCH 7/9] fix: disable test on detdesc platforms

pre-commit fixes

patch generated by https://gitlab.cern.ch/lhcb/Moore/-/jobs/54799073
---
 Hlt/RecoConf/options/UT_unbiased_residual.py          | 11 ++++-------
 .../qmtest/performance.qms/UT_unbiased_residual.qmt   |  1 +
 2 files changed, 5 insertions(+), 7 deletions(-)

diff --git a/Hlt/RecoConf/options/UT_unbiased_residual.py b/Hlt/RecoConf/options/UT_unbiased_residual.py
index 91ceb8a93f8..e36116b446d 100644
--- a/Hlt/RecoConf/options/UT_unbiased_residual.py
+++ b/Hlt/RecoConf/options/UT_unbiased_residual.py
@@ -26,17 +26,14 @@ from RecoConf.legacy_rec_hlt1_tracking import (
     make_VeloClusterTrackingSIMD,
 )
 
-options.histo_file = options.getProp(
-    "histo_file") or "hlt2_UT_unbiased_residual.root"
+options.histo_file = options.getProp("histo_file") or "hlt2_UT_unbiased_residual.root"
 
 
 def ut_unbiased_residual():
     with (
-            PrKalmanFilter.bind(FillFitResult=True),
-            make_VeloClusterTrackingSIMD.bind(
-                algorithm=VeloRetinaClusterTrackingSIMD),
-            make_reco_pvs.bind(
-                make_pvs_from_velo_tracks=make_PatPV3DFuture_pvs),
+        PrKalmanFilter.bind(FillFitResult=True),
+        make_VeloClusterTrackingSIMD.bind(algorithm=VeloRetinaClusterTrackingSIMD),
+        make_reco_pvs.bind(make_pvs_from_velo_tracks=make_PatPV3DFuture_pvs),
     ):
         reco = hlt2_reconstruction(make_reconstruction=make_light_reco_pr_kf)
 
diff --git a/Hlt/RecoConf/tests/qmtest/performance.qms/UT_unbiased_residual.qmt b/Hlt/RecoConf/tests/qmtest/performance.qms/UT_unbiased_residual.qmt
index afc6be63c1b..796a556de14 100644
--- a/Hlt/RecoConf/tests/qmtest/performance.qms/UT_unbiased_residual.qmt
+++ b/Hlt/RecoConf/tests/qmtest/performance.qms/UT_unbiased_residual.qmt
@@ -18,6 +18,7 @@
   </set></argument>
 <argument name="reference"><text>../refs/UT_unbiased_residual.ref</text></argument>
 <argument name="error_reference"><text>../refs/empty.ref</text></argument>
+<argument name="unsupported_platforms"><set><text>detdesc</text></set></argument>
 <argument name="validator"><text>
 
 from Moore.qmtest.exclusions import ref_preprocessor
-- 
GitLab


From 5333fb0ea2b27790032290dc8aeca7bb917a7e44 Mon Sep 17 00:00:00 2001
From: Hangyi Wu <hangyi.wu@cern.ch>
Date: Wed, 14 May 2025 19:31:43 +0200
Subject: [PATCH 8/9] fix: disable test on arm platform

---
 .../tests/qmtest/performance.qms/UT_unbiased_residual.qmt    | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/Hlt/RecoConf/tests/qmtest/performance.qms/UT_unbiased_residual.qmt b/Hlt/RecoConf/tests/qmtest/performance.qms/UT_unbiased_residual.qmt
index 796a556de14..7060eaf701a 100644
--- a/Hlt/RecoConf/tests/qmtest/performance.qms/UT_unbiased_residual.qmt
+++ b/Hlt/RecoConf/tests/qmtest/performance.qms/UT_unbiased_residual.qmt
@@ -18,7 +18,10 @@
   </set></argument>
 <argument name="reference"><text>../refs/UT_unbiased_residual.ref</text></argument>
 <argument name="error_reference"><text>../refs/empty.ref</text></argument>
-<argument name="unsupported_platforms"><set><text>detdesc</text></set></argument>
+<argument name="unsupported_platforms"><set>
+<text>detdesc</text>
+<text>arm</text>
+</set></argument>
 <argument name="validator"><text>
 
 from Moore.qmtest.exclusions import ref_preprocessor
-- 
GitLab


From 3fdd10a4155b9ed617201bc6b07570fdccea5170 Mon Sep 17 00:00:00 2001
From: Hangyi Wu <hangyi.wu@cern.ch>
Date: Mon, 23 Jun 2025 15:29:07 +0200
Subject: [PATCH 9/9] fix: re-enable arm platform for testing

---
 .../tests/qmtest/performance.qms/UT_unbiased_residual.qmt        | 1 -
 1 file changed, 1 deletion(-)

diff --git a/Hlt/RecoConf/tests/qmtest/performance.qms/UT_unbiased_residual.qmt b/Hlt/RecoConf/tests/qmtest/performance.qms/UT_unbiased_residual.qmt
index 7060eaf701a..07aff50a99c 100644
--- a/Hlt/RecoConf/tests/qmtest/performance.qms/UT_unbiased_residual.qmt
+++ b/Hlt/RecoConf/tests/qmtest/performance.qms/UT_unbiased_residual.qmt
@@ -20,7 +20,6 @@
 <argument name="error_reference"><text>../refs/empty.ref</text></argument>
 <argument name="unsupported_platforms"><set>
 <text>detdesc</text>
-<text>arm</text>
 </set></argument>
 <argument name="validator"><text>
 
-- 
GitLab