From 9508659f34bd3eff88e7c3cb54d2e0bdb9c84971 Mon Sep 17 00:00:00 2001 From: Miroslav Saur Date: Wed, 12 Jun 2024 22:55:20 +0200 Subject: [PATCH 1/3] Changing number of events selected by full stream to 5 in Hlt/Moore/tests/qmtest/test_lbexec_hlt2_pp_2022_reprocessing_data.qmt --- .../tests/qmtest/test_lbexec_hlt2_pp_2022_reprocessing_data.qmt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Hlt/Moore/tests/qmtest/test_lbexec_hlt2_pp_2022_reprocessing_data.qmt b/Hlt/Moore/tests/qmtest/test_lbexec_hlt2_pp_2022_reprocessing_data.qmt index d52c588671b..a616f64a251 100644 --- a/Hlt/Moore/tests/qmtest/test_lbexec_hlt2_pp_2022_reprocessing_data.qmt +++ b/Hlt/Moore/tests/qmtest/test_lbexec_hlt2_pp_2022_reprocessing_data.qmt @@ -40,7 +40,7 @@ out_files = tree.findall("./output/file") if len(out_files) != 4: causes.append(f"expected exactly 4 output files, got {out_files}") -expected_min_events = {"turcal": 5, "lumi": 5, "full": 6, "turboraw": 6} +expected_min_events = {"turcal": 5, "lumi": 5, "full": 5, "turboraw": 6} for out_file in out_files: m = re.match("^PFN:(hlt2_pp_2022_reprocessing_data_output_([a-z]+).mdf)$", out_file.attrib["name"]) -- GitLab From 16c13af99581863a1b24316f5788e7fa5bc52f94 Mon Sep 17 00:00:00 2001 From: Miroslav Saur Date: Wed, 12 Jun 2024 23:50:55 +0200 Subject: [PATCH 2/3] Changing threshold at mc_cheated_pattern_recognition to 95.5% --- Hlt/RecoConf/tests/qmtest/mc_cheated_pattern_recognition.qmt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Hlt/RecoConf/tests/qmtest/mc_cheated_pattern_recognition.qmt b/Hlt/RecoConf/tests/qmtest/mc_cheated_pattern_recognition.qmt index af4ba8e0b6b..c44bf211753 100644 --- a/Hlt/RecoConf/tests/qmtest/mc_cheated_pattern_recognition.qmt +++ b/Hlt/RecoConf/tests/qmtest/mc_cheated_pattern_recognition.qmt @@ -27,12 +27,12 @@ from PyConf.components import findCounters countersForAllAlgos = findCounters(extract_counters(stdout), 'PrTrackAssociator', 999) upstream_check = False for counters in countersForAllAlgos: - if counters['Efficiency'][0] == counters['Efficiency'][1]: + if float(counters['Efficiency'][1]) / float(counters['Efficiency'][0]) > 0.955 continue elif float(counters['Efficiency'][1]) / float(counters['Efficiency'][0]) > 0.975 and not upstream_check: upstream_check = True continue else: - causes.append('PrTrackAssociator Efficiency is less than 100%') + causes.append('PrTrackAssociator Efficiency is less than threshold 95.5%') -- GitLab From 913c87bc52ff1642aed3465c25005825abf338cb Mon Sep 17 00:00:00 2001 From: Maarten Van Veghel Date: Thu, 13 Jun 2024 00:38:09 +0200 Subject: [PATCH 3/3] restrict change to upstream --- .../tests/qmtest/mc_cheated_pattern_recognition.qmt | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Hlt/RecoConf/tests/qmtest/mc_cheated_pattern_recognition.qmt b/Hlt/RecoConf/tests/qmtest/mc_cheated_pattern_recognition.qmt index c44bf211753..a54d1f119e4 100644 --- a/Hlt/RecoConf/tests/qmtest/mc_cheated_pattern_recognition.qmt +++ b/Hlt/RecoConf/tests/qmtest/mc_cheated_pattern_recognition.qmt @@ -27,12 +27,12 @@ from PyConf.components import findCounters countersForAllAlgos = findCounters(extract_counters(stdout), 'PrTrackAssociator', 999) upstream_check = False for counters in countersForAllAlgos: - if float(counters['Efficiency'][1]) / float(counters['Efficiency'][0]) > 0.955 + if counters['Efficiency'][0] == counters['Efficiency'][1]: continue - elif float(counters['Efficiency'][1]) / float(counters['Efficiency'][0]) > 0.975 and not upstream_check: + elif float(counters['Efficiency'][1]) / float(counters['Efficiency'][0]) > 0.955 and not upstream_check: upstream_check = True continue else: - causes.append('PrTrackAssociator Efficiency is less than threshold 95.5%') + causes.append('PrTrackAssociator Efficiency is less than 100%') -- GitLab