diff --git a/common/log/Logger.cpp b/common/log/Logger.cpp index 65f069e8a45ae948504bf53a5d13533845dfd1b6..ac17564c3bb6e9ccb27767a4c7001c790fac1989 100644 --- a/common/log/Logger.cpp +++ b/common/log/Logger.cpp @@ -276,7 +276,7 @@ std::string Logger::createMsgBody(std::string_view logLevel, std::string_view ms << "\"" << stringFormattingJSON(param.getName()) << "\":"; if (param.getValueVariant().has_value()) { std::visit( - [&os](auto&& arg) { + [&os](const auto& arg) { using T = std::decay_t; if constexpr (std::is_same_v) { os << (arg ? "true" : "false"); diff --git a/common/log/Param.cpp b/common/log/Param.cpp index 34934fe77670978c025cbfdc2ccb6c9a4b39497c..5868888ecf4feaa190a806f349f8fc8595f609d4 100644 --- a/common/log/Param.cpp +++ b/common/log/Param.cpp @@ -42,7 +42,7 @@ const ParamValType &Param::getValueVariant() const noexcept { std::string Param::getValueStr() const noexcept { std::ostringstream oss; if (m_value.has_value()) { - std::visit([&oss](auto &&arg) { + std::visit([&oss](const auto &arg) { using T = std::decay_t; if constexpr (std::is_floating_point_v) { oss << floatingPointFormatting(arg); diff --git a/common/telemetry/CtaTelemetryLogHandler.cpp b/common/telemetry/CtaTelemetryLogHandler.cpp index 9fb38799c397e5d6611cdafb55bd7c8f4f9dfe53..a5af7c0a60995ad405dbaac2f50dd5d9c11a436e 100644 --- a/common/telemetry/CtaTelemetryLogHandler.cpp +++ b/common/telemetry/CtaTelemetryLogHandler.cpp @@ -64,7 +64,7 @@ void CtaTelemetryLogHandler::Handle(opentelemetry::sdk::common::internal_log::Lo const auto& attrs = attributes.GetAttributes(); for (const auto& [key, ownedAttribute] : attrs) { std::visit( - [&](auto&& val) { + [&](const auto& val) { if constexpr (is_supported_scalar_v>) { params.add(key, val); } else { diff --git a/plugin-manager/PluginInterface.hpp b/plugin-manager/PluginInterface.hpp index 7c64f5e0851536c205912fc2190bbd06c5389514..a0071eced8deb6e7eaf77850dc06dd254a8ab774 100644 --- a/plugin-manager/PluginInterface.hpp +++ b/plugin-manager/PluginInterface.hpp @@ -60,16 +60,16 @@ public: template Interface& CLASS(const std::string& strClassName) { static_assert(std::is_base_of::value, "Plugin type not supported."); - - m_umapFactories.emplace(strClassName, [](const std::variant& varaintPluginArgs) -> std::unique_ptr { + + m_umapFactories.emplace(strClassName, [](const std::variant& variantPluginArgs) -> std::unique_ptr { try { std::unique_ptr upType = std::visit([](auto&& tuplePluginArgs) -> std::unique_ptr { - // unpack parameter pack (IARGS...) + // unpack parameter pack (IARGS...) return std::apply([](auto&&... unpackedPluginArgs) -> std::unique_ptr { - return make(unpackedPluginArgs...); - }, tuplePluginArgs); - }, varaintPluginArgs); + return make(std::forward(unpackedPluginArgs)...); + }, std::forward(tuplePluginArgs)); + }, variantPluginArgs); return upType; @@ -107,7 +107,7 @@ private: } /** * A static partial specialized template for instantiating a class - * to be captured by the lambda function if a class cannot be constructible + * to be captured by the lambda function if a class cannot be constructible */ template static std::enable_if_t, std::unique_ptr> make(ARGS&&... ) { @@ -115,5 +115,5 @@ private: } }; - + } // namespace cta::plugin