[go: up one dir, main page]
Closed
Milestone Feb 12, 2024–Mar 19, 2024

Adaptive issuance - P finalisation

Follow-up of %Adaptive Issuance - P

Some work might also be attached to %Protocol P

Task on Adaptive issuance that can be handled after the beginning of the stabilization period, mainly testing and documenting.

Tests (protocol's integration tests framework)

https://docs.google.com/document/d/1F1HHH44_4CPTHTkcQ05dl5mj6KY1WmiIaBCdwG4NH1U/edit#heading=h.xik88gt2ekoa

  • Refactor the code to make tests more reliable and easier to write

  • classify the existing tests -- what feature is tested (directly and indirectly) (days)

    • Basic functionalities
    • Autostaking
    • Rewards
    • Slashing
    • Stake/Unstake
    • Unit tests

  • Clean and Write missing tests

    • Basic functionalities

    • Autostaking @polubelova

      • after delegation decreases, autostaking leads to 10% frozen stakes !12484 (merged) (soon undraft)
      • test deactivation @lrand

    • Rewards

    • denunciation

    • Slashing @MBourgoin

      • Any slash with delegator stakers (hours) !12465 (merged)

      • Multiple misbehaviours before denunciation (days) !12465 (merged) under-review

        • From single delegate (day)
          • In different blocks (level+round)
          • In the same block
        • From several delegates (2 or 3 scenarios with branches, ~2 days ?)
          • In different blocks | In the same block
          • With Multiple denunciations
          • in a single block | in different blocks with different order
          • for each misbehavior | same misbehavior
          • with quick injection <- should forbid fast | with late injection <- multiple slashings
          • Test slash > 100%
            • over 100%: denunciation ignored? With no effect?
          • Last slash: check partial amount

      • unit test adaptive slashing !12340 (merged)

    • Stake @dianegalloiswong & @lrand

      • merging some clean-up and comments (hours) !12418 (merged)
      • add roundtrips with multiple stakers (hours) !12458 (merged)
      • in stake from unstake, finalization, forbidden operations, change delegate tests: add some noise from other stakers doing operations too (hours)
      • add a test on staking from unstake with multiple unstake operations and/or multiple re-stake operations (hours) !12458 (merged)
      • test overstaking (hours) !12458 (merged)
      • For each stake operation, check the retained "staking balances" are properly affected at cycle-end. (hours) !12564 (merged)

    • do automated protocol migration test in protocol's test (if time permits) (days)

migration

  • test migration (~2 days)
    • check snapshot-removal's works as expected
    • check consensus-rights-delay change works as expected
  • Tezt migration test with pre-stitching denunciations @dianegalloiswong !12473 (merged)
    • Tezt test forbiding activation/deactivation @MBourgoin

documentation and dissemination

  • update all public documentation to make it clear that AI do not change LB issuance !12162 (merged) waiting for a consensus on how to reflect this change in the published blog posts (update the post, publish an errata, announce the diff with Paris, ...)

Public testnet demo

Tezos documentation

Advertized specifications (mostly google docs advertized on tezos agora)

simulator

Fix backported to paris