From a3c2a69e29bc204d89c6d370a6b3cad2496dce0f Mon Sep 17 00:00:00 2001 From: Sylvain Ribstein Date: Wed, 28 Jun 2023 09:56:32 +0200 Subject: [PATCH 1/2] proto/soru: fix json reveal encoding --- src/proto_alpha/lib_protocol/sc_rollup_PVM_sig.ml | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/proto_alpha/lib_protocol/sc_rollup_PVM_sig.ml b/src/proto_alpha/lib_protocol/sc_rollup_PVM_sig.ml index af7ae4dd848d..2dd23363ecd5 100644 --- a/src/proto_alpha/lib_protocol/sc_rollup_PVM_sig.ml +++ b/src/proto_alpha/lib_protocol/sc_rollup_PVM_sig.ml @@ -217,7 +217,7 @@ let reveal_encoding = case ~title:"Reveal_metadata" (Tag 1) - (obj1 (kind "reveal_kind")) + (obj1 (kind "reveal_metadata")) (function Reveal_metadata -> Some () | _ -> None) (fun () -> Reveal_metadata) in @@ -225,7 +225,9 @@ let reveal_encoding = case ~title:"Request_dal_page" (Tag 2) - (obj2 (kind "reveal_kind") (req "page_id" Dal_slot_repr.Page.encoding)) + (obj2 + (kind "request_dal_page") + (req "page_id" Dal_slot_repr.Page.encoding)) (function Request_dal_page s -> Some ((), s) | _ -> None) (fun ((), s) -> Request_dal_page s) in -- GitLab From f0ee0072064d91a56ca6c5e293f1ced032988a0e Mon Sep 17 00:00:00 2001 From: Sylvain Ribstein Date: Wed, 5 Jul 2023 14:51:07 +0200 Subject: [PATCH 2/2] doc/proto: add line for fixing the encoding --- docs/protocols/alpha.rst | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/docs/protocols/alpha.rst b/docs/protocols/alpha.rst index bf444cc5d428..8c6c5795a9be 100644 --- a/docs/protocols/alpha.rst +++ b/docs/protocols/alpha.rst @@ -56,6 +56,10 @@ Operation receipts Bug Fixes --------- +- Fix the JSON field ``kind`` of the smart rollup preveal + encoding. This constant field was wrongfully set for the + ``metadata`` and ``request_dal_page`` case. (MR :gl:`!9307`) + Minor Changes ------------- -- GitLab