From 3a593e3d13225050da8f6e8f5d7a1c248e9faeb8 Mon Sep 17 00:00:00 2001 From: Danny Willems Date: Mon, 20 Feb 2023 14:19:08 +0100 Subject: [PATCH 1/2] Cryptobox: fix typo comment --- src/lib_crypto_dal/test/test_dal_cryptobox.ml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lib_crypto_dal/test/test_dal_cryptobox.ml b/src/lib_crypto_dal/test/test_dal_cryptobox.ml index ffdbecdc6386..26eaa7b64b5b 100644 --- a/src/lib_crypto_dal/test/test_dal_cryptobox.ml +++ b/src/lib_crypto_dal/test/test_dal_cryptobox.ml @@ -1,5 +1,5 @@ module Test = struct - (* Samples k random integers within the range [0, bound]. *) + (* Samples k random integers within the range [0, bound[. *) let random_indices bound k = let indices = Array.init k (fun _ -> -1) in for i = 0 to k - 1 do -- GitLab From fdbe66736d03c845107737d5c2baac9928c2f896 Mon Sep 17 00:00:00 2001 From: Danny Willems Date: Mon, 20 Feb 2023 14:25:07 +0100 Subject: [PATCH 2/2] Cryptobox: fix wrong bound given Random.int is used in random_indices, and before it was the interval [0, number_of_shards - 1[, but we want [0, number_of_shards[. --- src/lib_crypto_dal/test/test_dal_cryptobox.ml | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/src/lib_crypto_dal/test/test_dal_cryptobox.ml b/src/lib_crypto_dal/test/test_dal_cryptobox.ml index 26eaa7b64b5b..6fdc9d0ec455 100644 --- a/src/lib_crypto_dal/test/test_dal_cryptobox.ml +++ b/src/lib_crypto_dal/test/test_dal_cryptobox.ml @@ -124,9 +124,7 @@ module Test = struct let* p = Cryptobox.polynomial_from_slot t slot in let enc_shards = Cryptobox.shards_from_polynomial t p in let c_indices = - random_indices - (number_of_shards - 1) - (number_of_shards / redundancy_factor) + random_indices number_of_shards (number_of_shards / redundancy_factor) in let c = Seq.filter @@ -160,9 +158,7 @@ module Test = struct let* p = Cryptobox.polynomial_from_slot t slot in let enc_shards = Cryptobox.shards_from_polynomial t p in let c_indices = - random_indices - (number_of_shards - 1) - (number_of_shards / redundancy_factor) + random_indices number_of_shards (number_of_shards / redundancy_factor) in let c = Seq.filter @@ -202,7 +198,7 @@ module Test = struct let enc_shards = Cryptobox.shards_from_polynomial t p in let c_indices = random_indices - (number_of_shards - 1) + number_of_shards ((number_of_shards / redundancy_factor) - 1) in let c = -- GitLab