From bb0a06a3389319cdb21fdf38949660ca12b756a4 Mon Sep 17 00:00:00 2001 From: Nic Volanschi Date: Thu, 16 Jun 2022 11:09:48 +0200 Subject: [PATCH 01/12] doc: minor fixes in ppx_expect doc --- docs/developer/ppx_expect.rst | 14 +++++++------- docs/developer/testing.rst | 8 ++++---- 2 files changed, 11 insertions(+), 11 deletions(-) diff --git a/docs/developer/ppx_expect.rst b/docs/developer/ppx_expect.rst index cb8001a08ded..b9349574bd28 100644 --- a/docs/developer/ppx_expect.rst +++ b/docs/developer/ppx_expect.rst @@ -1,7 +1,7 @@ Ppx_expect ========== -`Ppx_expect :ref:` is a framework for writing tests for OCaml +:ref:`Ppx_expect :ref:` is a framework for writing tests for OCaml code printing textual output. There is pretty comprehensive documentation about ``Inline expectation tests`` and the ``ppx_expect`` tool for writing them: @@ -13,12 +13,12 @@ Here, we will just cover enough to get started using them inside the Tezos codeb How to run tests ---------------- -If you want to run tests and see whether they succeed, build the standard runtest alias :: +If you want to run tests and see whether they succeed, build the standard ``runtest`` alias:: dune runtest src/lib_stdlib # or dune build @@src/lib_stdlib/runtest -The result would look like this :: +The result would look like this:: File "src/lib_stdlib/bloomer.ml", line 97, characters 0-817: random_read_writes (0.006 sec) File "src/lib_stdlib/bloomer.ml", line 123, characters 0-1339: peek and poke work with bits = [1 .. Sys.int_size - 7] (0.012 sec) @@ -29,7 +29,7 @@ The result would look like this :: File "src/lib_stdlib/bloomer.ml", line 456, characters 4-137 (11.966 sec) File "src/lib_stdlib/bloomer.ml", line 461, characters 4-1695: <> (0.000 sec) -A test can fail because it generates an output different from what is expeceted or because it raises an exception. +A test can fail because it generates an output different from what is expected or because it raises an exception. Failures are reported as a diff in both cases. Different output:: @@ -120,7 +120,7 @@ In the manifest, just add the following argument to the library containing expec ~inline_tests:ppx_expect -Adding new tests is then just a matter of adding ``let%expect_test`` at toplevel:: +Adding new tests is then just a matter of adding ``let%expect_test`` at top level:: let%expect_test "optional name" = print_endline "hello world"; @@ -141,9 +141,9 @@ Where to put the tests ---------------------- Expect tests can live next to the implementation or in a different library dedicated to tests -(e.g. if you don't want to polute your source/binary or if your want to only test the exposed api). +(e.g. if you don't want to polute your source/binary or if your want to only test the exposed API). -Intergration with Lwt +Integration with Lwt --------------------- Ppx_expect can be used in combination with Lwt, see the diff --git a/docs/developer/testing.rst b/docs/developer/testing.rst index d847a8ec71dd..1c6d152bf8b6 100644 --- a/docs/developer/testing.rst +++ b/docs/developer/testing.rst @@ -127,7 +127,7 @@ References: - `Alcotest README `_. .. _ppx_expect_section: - + Ppx_expect ~~~~~~~~~~ @@ -136,8 +136,8 @@ framework for writing tests for OCaml code generating textual output, similar to `Cram `_ which is used for testing command line applications. Typical use cases: - - Unit test, integration test leveraging existing printers instead of checking properties. - - Test that change on purpose over time. One can easily make tests + - Unit tests and integration tests leveraging existing printers instead of checking properties. + - Tests that change on purpose over time. One can easily make tests pass again with a single dune invocation ``dune runtest --auto-promote`` Example tests: @@ -151,7 +151,7 @@ References: - `Ppx_expect README `_. - `Dune documentation about inline expectation tests `_. - `Ppx_inline_test README `_. - + .. _property_based_test: QCheck -- GitLab From 53d70af8ed48d741406bd9973513780894aa45c0 Mon Sep 17 00:00:00 2001 From: Nic Volanschi Date: Sat, 18 Jun 2022 11:51:26 +0200 Subject: [PATCH 02/12] doc: warn on mandatory option for baker --- docs/CHANGES.rst | 2 ++ docs/introduction/howtorun.rst | 3 ++- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/docs/CHANGES.rst b/docs/CHANGES.rst index 81ca3a22f2a7..76c0e565f5c8 100644 --- a/docs/CHANGES.rst +++ b/docs/CHANGES.rst @@ -124,6 +124,8 @@ Client cast invalid ballots (unexpected voting period, missing voting rights, ...) +.. _changes_13_0_rc1_baker: + Baker ----- diff --git a/docs/introduction/howtorun.rst b/docs/introduction/howtorun.rst index 709f2d2f2837..a1299cf91ef1 100644 --- a/docs/introduction/howtorun.rst +++ b/docs/introduction/howtorun.rst @@ -178,6 +178,7 @@ baking for user *bob*:: Note that the baker needs direct access to the node data directory for performance reasons (to reduce the number of RPC calls to the node). +Note also that since version 13.0, option ``--liquidity-baking-toggle-vote`` is mandatory, see :ref:`the changelog `. .. warning:: @@ -203,7 +204,7 @@ chains and looks for: Upon finding such irregularity, it will emit respectively a double-baking, double-pre-endorsing, or double-endorsing denunciation operation, which will -cause the offender to be :ref:`slashed`, that is, to lose part of its security deposit. +cause the offender to be :ref:`slashed`, that is, to lose part of its security deposit. :: -- GitLab From e62090a2321636904807de30680ebfcc747b45d7 Mon Sep 17 00:00:00 2001 From: Nic Volanschi Date: Fri, 17 Jun 2022 12:24:40 +0200 Subject: [PATCH 03/12] doc: linkcheck only displays problems --- docs/.gitignore | 2 ++ docs/Makefile | 7 +++++-- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/docs/.gitignore b/docs/.gitignore index aa1eab1d8a31..76dcd20616a3 100644 --- a/docs/.gitignore +++ b/docs/.gitignore @@ -18,3 +18,5 @@ tezos-client.html /user/node-config.json /CHANGES-dev.rst /developer/metrics.csv + +/linkcheck diff --git a/docs/Makefile b/docs/Makefile index 9bf4677f1900..93cc799e650c 100644 --- a/docs/Makefile +++ b/docs/Makefile @@ -83,8 +83,11 @@ odoc-lite: main docexes @mkdir -p _build/api @cp -r $(TMPDOCDIR)/_build/default/_doc _build/api/odoc +.PHONY: linkcheck linkcheck: html - @$(SPHINXBUILD) -b linkcheck "$(SOURCEDIR)" "$(BUILDDIR)" $(SPHINXOPTS) + @echo "Running linkcheck, outputs messages to $(BUILDDIR)/output.txt" + @$(SPHINXBUILD) -b linkcheck "$(SOURCEDIR)" "$(BUILDDIR)" $(SPHINXOPTS) >$@;\ + RESULT=$$?; cat $(BUILDDIR)/output.txt; exit $$RESULT .PHONY: redirectcheck redirectcheck: html @@ -192,6 +195,6 @@ pycodestyle: lint: pylint pycodestyle lint_black clean: - @-rm -Rf "$(BUILDDIR)" + @-rm -Rf "$(BUILDDIR)" linkcheck @-rm -Rf api/errors.rst developer/metrics.csv user/node-config.json active/rpc.rst ithaca/rpc.rst jakarta/rpc.rst alpha/rpc.rst shell/rpc.rst shell/p2p_api.rst user/default-acl.json CHANGES-dev.rst @-rm -Rf api/tezos-*.html api/tezos-*.txt active/tezos-*.html ithaca/tezos-*.html jakarta/tezos-*.html alpha/tezos-*.html -- GitLab From f9cfc5a34aa74661af37c9fabb95e2d821a98bae Mon Sep 17 00:00:00 2001 From: Nic Volanschi Date: Mon, 20 Jun 2022 13:15:54 +0300 Subject: [PATCH 04/12] doc: configure linkcheck_allowed_redirects --- docs/conf.py | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) diff --git a/docs/conf.py b/docs/conf.py index 162c187f15c4..850adc462e1a 100644 --- a/docs/conf.py +++ b/docs/conf.py @@ -212,6 +212,28 @@ linkcheck_ignore = [ # (interpreted by linkcheck as external links, generating false positives) r'^\.\./', ] +linkcheck_allowed_redirects = dict( + [ + # 1. inocuous redirections (redirected with See Other / Found) + ( + r'https://www\.sphinx-doc\.org/.*', + r'https://www\.sphinx-doc\.org/en/master/.*', + ), + (r'https://docs\.pytest\.org/', r'https://docs\.pytest\.org/en/.*'), + ( + r'https://tools\.ietf\.org/html/.*', + r'https://datatracker\.ietf\.org/doc/.*', + ), + (r'https://ocaml\.org/.*', r'https://v2\.ocaml\.org/.*'), + ( + r'https://github\.com/serokell/tezos-packaging/releases/latest', + r'https://github\.com/serokell/tezos-packaging/releases/tag/.*', + ), + # 2. permanent redidections, maybe fix one day + (r'https://bitheap\.org/cram/', r'https://github\.com/aiiie/cram'), + ] +) + # Python module index generation is broken, deactivate it. html_domain_indices = False -- GitLab From 3fd9b8cdf21fb161de629b9b3e92e7f38c0697c4 Mon Sep 17 00:00:00 2001 From: Nic Volanschi Date: Fri, 17 Jun 2022 18:13:18 +0200 Subject: [PATCH 05/12] doc: fix broken links --- docs/alpha/consensus.rst | 2 +- docs/alpha/proof_of_stake.rst | 2 +- docs/alpha/timelock.rst | 2 +- docs/conf.py | 2 ++ docs/developer/ppx_expect.rst | 2 +- docs/ithaca/consensus.rst | 2 +- docs/ithaca/proof_of_stake.rst | 2 +- docs/ithaca/timelock.rst | 2 +- docs/jakarta/consensus.rst | 2 +- docs/jakarta/proof_of_stake.rst | 2 +- docs/jakarta/timelock.rst | 2 +- docs/user/fa12.rst | 2 +- 12 files changed, 13 insertions(+), 11 deletions(-) diff --git a/docs/alpha/consensus.rst b/docs/alpha/consensus.rst index 2c93683262d8..b21248fce865 100644 --- a/docs/alpha/consensus.rst +++ b/docs/alpha/consensus.rst @@ -10,7 +10,7 @@ History Before Tenderbake, there was `Emmy* `_, a Nakamoto-style consensus consisting of a series of improvements of the one in -the `Tezos whitepaper `_. +the `Tezos whitepaper `_. Emmy*, like any Nakamoto-style consensus algorithm (such as `Bitcoin `_ or `Ouroboros diff --git a/docs/alpha/proof_of_stake.rst b/docs/alpha/proof_of_stake.rst index 3ccddf8a820c..a1fdef70dc02 100644 --- a/docs/alpha/proof_of_stake.rst +++ b/docs/alpha/proof_of_stake.rst @@ -175,7 +175,7 @@ Further External Resources The original design of the proof-of-stake mechanism in Tezos can be found in the `whitepaper -`_. +`_. Another presentation of the Tezos' proof-of-stake mechanism can be found in the `Tezos agora wiki entry diff --git a/docs/alpha/timelock.rst b/docs/alpha/timelock.rst index f756fe77047c..9fc225ee4c5d 100644 --- a/docs/alpha/timelock.rst +++ b/docs/alpha/timelock.rst @@ -134,5 +134,5 @@ allows a user to create chests and chest keys to interact with a smart contract. Example ------- -The Raffle contract on Open Tezos (look for "raffle contract" using the search engine on ``https://opentezos.com/``) +The raffle contract on Open Tezos `here `__ gives a concrete example of using time-lock. diff --git a/docs/conf.py b/docs/conf.py index 850adc462e1a..d55c4728b4c4 100644 --- a/docs/conf.py +++ b/docs/conf.py @@ -211,6 +211,8 @@ linkcheck_ignore = [ # local files, e.g. ../api/api-inline.html#*', \.\./CHANGES.html#version-* # (interpreted by linkcheck as external links, generating false positives) r'^\.\./', + # flaky servers, to remove one day if they got more predictable + r'^https://opentezos\.com/' ] linkcheck_allowed_redirects = dict( [ diff --git a/docs/developer/ppx_expect.rst b/docs/developer/ppx_expect.rst index b9349574bd28..726e51cb545d 100644 --- a/docs/developer/ppx_expect.rst +++ b/docs/developer/ppx_expect.rst @@ -1,7 +1,7 @@ Ppx_expect ========== -:ref:`Ppx_expect :ref:` is a framework for writing tests for OCaml +:ref:`Ppx_expect` is a framework for writing tests for OCaml code printing textual output. There is pretty comprehensive documentation about ``Inline expectation tests`` and the ``ppx_expect`` tool for writing them: diff --git a/docs/ithaca/consensus.rst b/docs/ithaca/consensus.rst index a13883ed9901..695c48f461c2 100644 --- a/docs/ithaca/consensus.rst +++ b/docs/ithaca/consensus.rst @@ -10,7 +10,7 @@ History Before Tenderbake, there was `Emmy* `_, a Nakamoto-style consensus consisting of a series of improvements of the one in -the `Tezos whitepaper `_. +the `Tezos whitepaper `_. Emmy*, like any Nakamoto-style consensus algorithm (such as `Bitcoin `_ or `Ouroboros diff --git a/docs/ithaca/proof_of_stake.rst b/docs/ithaca/proof_of_stake.rst index f25e2dfe7382..730c120bf533 100644 --- a/docs/ithaca/proof_of_stake.rst +++ b/docs/ithaca/proof_of_stake.rst @@ -230,7 +230,7 @@ Further External Resources The original design of the proof-of-stake mechanism in Tezos can be found in the `whitepaper -`_. +`_. Another presentation of the Tezos' proof-of-stake mechanism can be found in the `Tezos agora wiki entry diff --git a/docs/ithaca/timelock.rst b/docs/ithaca/timelock.rst index f756fe77047c..9fc225ee4c5d 100644 --- a/docs/ithaca/timelock.rst +++ b/docs/ithaca/timelock.rst @@ -134,5 +134,5 @@ allows a user to create chests and chest keys to interact with a smart contract. Example ------- -The Raffle contract on Open Tezos (look for "raffle contract" using the search engine on ``https://opentezos.com/``) +The raffle contract on Open Tezos `here `__ gives a concrete example of using time-lock. diff --git a/docs/jakarta/consensus.rst b/docs/jakarta/consensus.rst index 72358a9366c5..972d65a4169d 100644 --- a/docs/jakarta/consensus.rst +++ b/docs/jakarta/consensus.rst @@ -10,7 +10,7 @@ History Before Tenderbake, there was `Emmy* `_, a Nakamoto-style consensus consisting of a series of improvements of the one in -the `Tezos whitepaper `_. +the `Tezos whitepaper `_. Emmy*, like any Nakamoto-style consensus algorithm (such as `Bitcoin `_ or `Ouroboros diff --git a/docs/jakarta/proof_of_stake.rst b/docs/jakarta/proof_of_stake.rst index 3825f09d8530..ce95e4b3e7b0 100644 --- a/docs/jakarta/proof_of_stake.rst +++ b/docs/jakarta/proof_of_stake.rst @@ -225,7 +225,7 @@ Further External Resources The original design of the proof-of-stake mechanism in Tezos can be found in the `whitepaper -`_. +`_. Another presentation of the Tezos' proof-of-stake mechanism can be found in the `Tezos agora wiki entry diff --git a/docs/jakarta/timelock.rst b/docs/jakarta/timelock.rst index f756fe77047c..9fc225ee4c5d 100644 --- a/docs/jakarta/timelock.rst +++ b/docs/jakarta/timelock.rst @@ -134,5 +134,5 @@ allows a user to create chests and chest keys to interact with a smart contract. Example ------- -The Raffle contract on Open Tezos (look for "raffle contract" using the search engine on ``https://opentezos.com/``) +The raffle contract on Open Tezos `here `__ gives a concrete example of using time-lock. diff --git a/docs/user/fa12.rst b/docs/user/fa12.rst index a1f8c8beb878..263494824864 100644 --- a/docs/user/fa12.rst +++ b/docs/user/fa12.rst @@ -25,7 +25,7 @@ supply. The Michelson interface is then described by the following entrypoints: Multiple implementations of such a standard exist within the ecosystem. For example, one is provided with the `TZIP-007 specification `_. -`Edukera `_ and +`Edukera `_ and `camlCase `_ both provide a contract that implements the standard, and both have been verified using the `Mi-Cho-Coq `_ framework (see related :gl:`merge -- GitLab From cd31b15b31d3ddbc4748ee632ade3b27b8929f3d Mon Sep 17 00:00:00 2001 From: Nic Volanschi Date: Mon, 20 Jun 2022 18:32:37 +0300 Subject: [PATCH 06/12] doc: ignore flaky links on opentezos --- docs/conf.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/conf.py b/docs/conf.py index d55c4728b4c4..eb38e090414f 100644 --- a/docs/conf.py +++ b/docs/conf.py @@ -212,7 +212,7 @@ linkcheck_ignore = [ # (interpreted by linkcheck as external links, generating false positives) r'^\.\./', # flaky servers, to remove one day if they got more predictable - r'^https://opentezos\.com/' + r'^https://opentezos\.com/', ] linkcheck_allowed_redirects = dict( [ -- GitLab From ff42e09f0aa323dba2e913c35c1c409388174401 Mon Sep 17 00:00:00 2001 From: "sol.lederer" Date: Mon, 20 Jun 2022 11:06:12 -0400 Subject: [PATCH 07/12] doc: lowercase voting flags --- docs/jakarta/liquidity_baking.rst | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/docs/jakarta/liquidity_baking.rst b/docs/jakarta/liquidity_baking.rst index e7ee01a29293..dfbff4d5f9c2 100644 --- a/docs/jakarta/liquidity_baking.rst +++ b/docs/jakarta/liquidity_baking.rst @@ -44,13 +44,13 @@ mechanism called the Liquidity Baking Toggle Vote. At every block, the baker producing the block includes a flag that requests ending the subsidy or on the contrary continuing or restarting it. The context maintains an exponential moving average of that flag. The baker has -three options for this flag: ``Off`` to request ending the subsidy, -``On`` to request continuing or restarting the subsidy, and ``Pass`` +three options for this flag: ``off`` to request ending the subsidy, +``on`` to request continuing or restarting the subsidy, and ``pass`` to abstain. -``e[n+1] = e[n]`` if the flag is set to ``Pass``. -``e[n+1] = (1999 * e[n] // 2000) + 1_000_000`` if the flag is set to ``Off``. -``e[n+1] = (1999 * e[n] // 2000)`` if the flag is set to ``On``. +``e[n+1] = e[n]`` if the flag is set to ``pass``. +``e[n+1] = (1999 * e[n] // 2000) + 1_000_000`` if the flag is set to ``off``. +``e[n+1] = (1999 * e[n] // 2000)`` if the flag is set to ``on``. When computing ``e[n+1]``, the division is rounded toward ``1_000_000_000```. If at any block ``e[n] >= 1_000_000_000`` then it means that an -- GitLab From 46b826b2bbe05136968a1249721efcf55e4c2b5c Mon Sep 17 00:00:00 2001 From: Arvid Jakobsson Date: Tue, 21 Jun 2022 09:23:47 +0200 Subject: [PATCH 08/12] scripts/snapshot_alpha.sh: fix typo --- scripts/snapshot_alpha.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/snapshot_alpha.sh b/scripts/snapshot_alpha.sh index ade43a8af9db..af02a6a854d7 100755 --- a/scripts/snapshot_alpha.sh +++ b/scripts/snapshot_alpha.sh @@ -150,7 +150,7 @@ sed -i.old -e "s,tezos\.gitlab\.io/alpha/,tezos.gitlab.io/${version}_${label}/,g -e "s/_alpha\b/_${version}/g" \ -e "s/\balpha\b/${version}/g" \ $(find . -name \*.py) -echo "Fixing python regtests ouputs" +echo "Fixing python regtests outputs" cd _regtest_outputs sed -i.old -e "s/_alpha\b/_${version}/g" *.out cd ../.. -- GitLab From 84979052283d58130bdeb3cabc9aa93986b37393 Mon Sep 17 00:00:00 2001 From: Valentin Chaboche Date: Tue, 21 Jun 2022 11:44:32 +0200 Subject: [PATCH 09/12] Tx_rolup,Client: fix commands typo --- .../client_proto_context_commands.ml | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/proto_alpha/lib_client_commands/client_proto_context_commands.ml b/src/proto_alpha/lib_client_commands/client_proto_context_commands.ml index da6a9c4f9680..06cf66a0930c 100644 --- a/src/proto_alpha/lib_client_commands/client_proto_context_commands.ml +++ b/src/proto_alpha/lib_client_commands/client_proto_context_commands.ml @@ -2042,7 +2042,7 @@ let commands_rw () = >>=? fun _res -> return_unit); command ~group - ~desc:"Finalize a commitment of an transaction rollup." + ~desc:"Finalize a commitment of a transaction rollup." (args7 fee_arg dry_run_switch @@ -2053,7 +2053,7 @@ let commands_rw () = counter_arg) (prefixes ["finalize"; "commitment"; "of"; "tx"; "rollup"] @@ Tx_rollup.tx_rollup_address_param - ~usage:"Tx rollup that have his commitment finalized." + ~usage:"Tx rollup that have its commitment finalized." @@ prefix "from" @@ ContractAlias.destination_param ~name:"src" @@ -2094,7 +2094,7 @@ let commands_rw () = >>=? fun _res -> return_unit); command ~group - ~desc:"Recover commitment bond from an transaction rollup." + ~desc:"Recover commitment bond from a transaction rollup." (args7 fee_arg dry_run_switch @@ -2145,7 +2145,7 @@ let commands_rw () = >>=? fun _res -> return_unit); command ~group - ~desc:"Remove a commitment from an transaction rollup." + ~desc:"Remove a commitment from a transaction rollup." (args7 fee_arg dry_run_switch @@ -2156,7 +2156,7 @@ let commands_rw () = counter_arg) (prefixes ["remove"; "commitment"; "of"; "tx"; "rollup"] @@ Tx_rollup.tx_rollup_address_param - ~usage:"Tx rollup that have his commitment removed." + ~usage:"Tx rollup that have its commitment removed." @@ prefix "from" @@ ContractAlias.destination_param ~name:"src" @@ -2197,7 +2197,7 @@ let commands_rw () = >>=? fun _res -> return_unit); command ~group - ~desc:"Reject a commitment of an transaction rollup." + ~desc:"Reject a commitment of a transaction rollup." (args7 fee_arg dry_run_switch @@ -2208,7 +2208,7 @@ let commands_rw () = counter_arg) (prefixes ["reject"; "commitment"; "of"; "tx"; "rollup"] @@ Tx_rollup.tx_rollup_address_param - ~usage:"Tx rollup that have one of his commitment rejected." + ~usage:"Tx rollup that have one of its commitment rejected." @@ prefixes ["at"; "level"] @@ Tx_rollup.level_param ~usage:"Level of the commitment disputed." @@ prefixes ["with"; "result"; "hash"] -- GitLab From dcea11f2e75a534a0ecd89d1b008c1fbe56408f9 Mon Sep 17 00:00:00 2001 From: Eugen Zalinescu Date: Wed, 22 Jun 2022 15:54:02 +0200 Subject: [PATCH 10/12] doc: fix typo --- docs/ithaca/proof_of_stake.rst | 2 +- docs/jakarta/proof_of_stake.rst | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/ithaca/proof_of_stake.rst b/docs/ithaca/proof_of_stake.rst index 730c120bf533..2d7a78200704 100644 --- a/docs/ithaca/proof_of_stake.rst +++ b/docs/ithaca/proof_of_stake.rst @@ -95,7 +95,7 @@ previous cycle, they first commit to nonces and they only reveal their committed nonces later, in the current cycle. We make the assumption that at least one participant is honest, that -is, it has indeed chosen a random value and this values was revealed. This is a necessary +is, it has indeed chosen a random value and this value was revealed. This is a necessary condition for the seed to be random. The randomness could however be biased as this protocol suffers from the following low-impact weakness: if a malicious participant can make sure she is the last revealer, diff --git a/docs/jakarta/proof_of_stake.rst b/docs/jakarta/proof_of_stake.rst index ce95e4b3e7b0..01706c881b0e 100644 --- a/docs/jakarta/proof_of_stake.rst +++ b/docs/jakarta/proof_of_stake.rst @@ -93,7 +93,7 @@ previous cycle, they first commit to nonces and they only reveal their committed nonces later, in the current cycle. We make the assumption that at least one participant is honest, that -is, it has indeed chosen a random value and this values was revealed. This is a necessary +is, it has indeed chosen a random value and this value was revealed. This is a necessary condition for the seed to be random. The randomness could however be biased as this protocol suffers from the following low-impact weakness: if a malicious participant can make sure she is the last revealer, -- GitLab From 718805611e8335e3ffaee59e50bf497aa690863d Mon Sep 17 00:00:00 2001 From: Nic Volanschi Date: Thu, 23 Jun 2022 16:30:45 +0300 Subject: [PATCH 11/12] doc: port typo from POS.rst to randomness*.rst --- docs/alpha/randomness_generation.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/alpha/randomness_generation.rst b/docs/alpha/randomness_generation.rst index 190a284258fc..374cdcb71285 100644 --- a/docs/alpha/randomness_generation.rst +++ b/docs/alpha/randomness_generation.rst @@ -39,7 +39,7 @@ commitment publication. In the case of a rolling RANDAO, the previous seed may be used to initilialise the hash. We make the assumption that at least one participant is honest, that is, it -has indeed chosen a random value and this values was revealed. This is a +has indeed chosen a random value and this value was revealed. This is a necessary condition for the seed to be random. The randomness could however be biased as this protocol suffers from the following low-impact weakness: if a malicious participant can make sure she is the last revealer, then she -- GitLab From 60a0738b89dd189f528c7a920d0032c84845c7f2 Mon Sep 17 00:00:00 2001 From: Nic Volanschi Date: Thu, 23 Jun 2022 16:31:43 +0300 Subject: [PATCH 12/12] doc: remove link to stopped server teztracker --- docs/index.rst | 1 - 1 file changed, 1 deletion(-) diff --git a/docs/index.rst b/docs/index.rst index f87b54692787..4949261f6154 100644 --- a/docs/index.rst +++ b/docs/index.rst @@ -50,7 +50,6 @@ The Community - https://tzstats.com - https://tezblock.io - - https://teztracker.com/ - https://tzkt.io (Baking focused explorer) - https://arronax.io (Analytics-oriented explorer) - https://mininax.io -- GitLab