From 0c7eae2b0ea11b273d862a4a5f23dc5798819b17 Mon Sep 17 00:00:00 2001 From: Alain Mebsout Date: Tue, 16 Dec 2025 15:33:37 +0100 Subject: [PATCH 1/2] Rollup node: fix RPC global/monitor_finalized_blocks The streaming RPC was not working when --l1-finalized-blocks was used because finalized blocks were never notified because notification was attempted before the block was saved. --- src/lib_smart_rollup_node/rollup_node_daemon.ml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lib_smart_rollup_node/rollup_node_daemon.ml b/src/lib_smart_rollup_node/rollup_node_daemon.ml index 01443d56da9b..3c82da3fea12 100644 --- a/src/lib_smart_rollup_node/rollup_node_daemon.ml +++ b/src/lib_smart_rollup_node/rollup_node_daemon.ml @@ -203,6 +203,7 @@ let process_unseen_head ({node_ctxt; _} as state) ~catching_up ~predecessor let l2_block = Sc_rollup_block.{header; content = (); num_ticks; initial_tick} in + let* () = Node_context.save_l2_block node_ctxt l2_block in let* () = if finalized then Node_context.set_finalized node_ctxt header.block_hash header.level @@ -212,7 +213,6 @@ let process_unseen_head ({node_ctxt; _} as state) ~catching_up ~predecessor let finalized_hash = predecessor.header.predecessor in Node_context.set_finalized node_ctxt finalized_hash finalized_level) in - let* () = Node_context.save_l2_block node_ctxt l2_block in let end_timestamp = Time.System.now () in let total_time = Ptime.diff end_timestamp start_timestamp in let process_time = Ptime.diff end_timestamp fetch_timestamp in -- GitLab From e0aa831f7f705769555fbf365856b74d1b69f176 Mon Sep 17 00:00:00 2001 From: Alain Mebsout Date: Tue, 16 Dec 2025 15:37:03 +0100 Subject: [PATCH 2/2] Doc: changelog --- CHANGES.rst | 2 ++ 1 file changed, 2 insertions(+) diff --git a/CHANGES.rst b/CHANGES.rst index 9bf5e3280eeb..e5217b803795 100644 --- a/CHANGES.rst +++ b/CHANGES.rst @@ -64,6 +64,8 @@ Smart Rollup node - Fix issue where setting for ``l1_monitor_finalized`` would be ignored from the configuration file. (MR :gl:`!20239`) +- Fix issue where finalized blocks would not be notified when using + ``--l1-monitor-finalized``. (MR :gl:`!20256`) Smart Rollup WASM Debugger -------------------------- -- GitLab