From 69a25b0303399eb53120a94ff308d86e1a32c618 Mon Sep 17 00:00:00 2001
From: Rodi-Can Bozman <rodi.bozman@functori.com>
Date: Thu, 11 Dec 2025 09:42:59 +0100
Subject: [PATCH] Etherlink/Kernel: remove NoOp inspector

---
 etherlink/kernel_latest/kernel/src/apply.rs   |  1 -
 .../kernel_latest/revm/src/inspectors/mod.rs  |  3 --
 .../kernel_latest/revm/src/inspectors/noop.rs | 32 -------------------
 etherlink/kernel_latest/revm/src/lib.rs       |  4 ---
 4 files changed, 40 deletions(-)
 delete mode 100644 etherlink/kernel_latest/revm/src/inspectors/noop.rs

diff --git a/etherlink/kernel_latest/kernel/src/apply.rs b/etherlink/kernel_latest/kernel/src/apply.rs
index 793c91d5eded..3bde29786db3 100644
--- a/etherlink/kernel_latest/kernel/src/apply.rs
+++ b/etherlink/kernel_latest/kernel/src/apply.rs
@@ -351,7 +351,6 @@ pub fn revm_run_transaction<Host: Runtime>(
                     transaction_hash: transaction_hash.map(|hash| B256::from(hash.0)),
                 },
             ),
-            TracerInput::NoOp => revm_etherlink::inspectors::TracerInput::NoOp,
         }),
         is_simulation,
     )
diff --git a/etherlink/kernel_latest/revm/src/inspectors/mod.rs b/etherlink/kernel_latest/revm/src/inspectors/mod.rs
index 1c76ebd9594c..5683828d8ffb 100644
--- a/etherlink/kernel_latest/revm/src/inspectors/mod.rs
+++ b/etherlink/kernel_latest/revm/src/inspectors/mod.rs
@@ -23,7 +23,6 @@ use struct_logger::StructLoggerInput;
 use tezos_evm_runtime::runtime::Runtime;
 
 pub mod call_tracer;
-pub mod noop;
 pub mod storage;
 pub mod struct_logger;
 
@@ -140,7 +139,6 @@ impl<'a, Host: Runtime, INSP: EtherlinkInspector<'a, Host>> InspectEvm
 
 #[derive(Debug, Clone, Copy)]
 pub enum TracerInput {
-    NoOp,
     CallTracer(CallTracerInput),
     StructLogger(StructLoggerInput),
 }
@@ -150,7 +148,6 @@ impl TracerInput {
         match self {
             TracerInput::StructLogger(input) => input.transaction_hash,
             TracerInput::CallTracer(input) => input.transaction_hash,
-            TracerInput::NoOp => None,
         }
     }
 }
diff --git a/etherlink/kernel_latest/revm/src/inspectors/noop.rs b/etherlink/kernel_latest/revm/src/inspectors/noop.rs
deleted file mode 100644
index 9e9b929127ad..000000000000
--- a/etherlink/kernel_latest/revm/src/inspectors/noop.rs
+++ /dev/null
@@ -1,32 +0,0 @@
-// SPDX-FileCopyrightText: 2025 Functori <contact@functori.com>
-//
-// SPDX-License-Identifier: MIT
-
-use revm::{
-    context::ContextTr,
-    interpreter::{interpreter_types::StackTr, InterpreterTypes},
-    primitives::B256,
-    Inspector,
-};
-use tezos_evm_runtime::runtime::Runtime;
-
-use crate::inspectors::EtherlinkInspector;
-
-pub struct NoInspector;
-
-impl<CTX, INTR> Inspector<CTX, INTR> for NoInspector
-where
-    CTX: ContextTr,
-    INTR: InterpreterTypes<Stack: StackTr>,
-{
-}
-
-impl<'a, Host: Runtime + 'a> EtherlinkInspector<'a, Host> for NoInspector {
-    fn is_struct_logger(&self) -> bool {
-        false
-    }
-
-    fn get_transaction_hash(&self) -> Option<B256> {
-        None
-    }
-}
diff --git a/etherlink/kernel_latest/revm/src/lib.rs b/etherlink/kernel_latest/revm/src/lib.rs
index 0df1af77c4cc..ee6f3df4f759 100644
--- a/etherlink/kernel_latest/revm/src/lib.rs
+++ b/etherlink/kernel_latest/revm/src/lib.rs
@@ -12,7 +12,6 @@ use database::EtherlinkVMDB;
 use helpers::storage::u256_to_le_bytes;
 use inspectors::{
     call_tracer::{CallTracer, CallTracerInput},
-    noop::NoInspector,
     struct_logger::{StructLogger, StructLoggerInput},
     EvmInspection, TracerInput,
 };
@@ -220,9 +219,6 @@ fn get_inspector_from<'a, Host: Runtime + 'a>(
             transaction_hash,
         }) => Box::new(StructLogger::new(config, transaction_hash))
             as Box<dyn EtherlinkInspector<'a, Host>>,
-        TracerInput::NoOp => {
-            Box::new(NoInspector) as Box<dyn EtherlinkInspector<'a, Host>>
-        }
     }
 }
 
-- 
GitLab