From dc71a12f37022f7e1d1abc5b707005938bcb6478 Mon Sep 17 00:00:00 2001 From: Eugen Zalinescu Date: Tue, 17 Jun 2025 09:22:31 +0200 Subject: [PATCH 1/2] Tests/DAL: put some logs at Debug level --- tezt/tests/dal.ml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tezt/tests/dal.ml b/tezt/tests/dal.ml index 718eb533f654..e1df88add729 100644 --- a/tezt/tests/dal.ml +++ b/tezt/tests/dal.ml @@ -249,7 +249,7 @@ let wait_for_shards_promises ~dal_node ~shards ~published_level ~slot_index = in let () = incr count in let () = - Log.info + Log.debug "Dal node %s has received %d/%d shards" (Dal_node.name dal_node) !count @@ -6028,7 +6028,7 @@ module Amplification = struct wait_for_shards_promises ~dal_node ~shards ~published_level ~slot_index in let () = - Log.info "Dal node %s has received its shards" (Dal_node.name dal_node) + Log.debug "Dal node %s has received its shards" (Dal_node.name dal_node) in unit in @@ -6073,7 +6073,7 @@ module Amplification = struct unit in - (* Wait until everyone has reveived the needed shards (first the + (* Wait until everyone has received the needed shards (first the non-banned attesters, then the observer, and finally the banned attesters). *) let wait_slot ~published_level ~slot_index = -- GitLab From 11981c751374d15957ccdf5ad9ab50fd1f1082e9 Mon Sep 17 00:00:00 2001 From: Eugen Zalinescu Date: Tue, 17 Jun 2025 10:03:17 +0200 Subject: [PATCH 2/2] Tests/DAL: use a higher block delay for amplification test --- tezt/tests/dal.ml | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/tezt/tests/dal.ml b/tezt/tests/dal.ml index e1df88add729..4c9976d199d2 100644 --- a/tezt/tests/dal.ml +++ b/tezt/tests/dal.ml @@ -10768,6 +10768,13 @@ let register ~protocols = ~tags:["amplification"; "simple"] ~bootstrap_profile:true ~l1_history_mode:Default_with_refutation + (* In this test, receiving all shards should happen before amplification + starts. With [minimal_block_delay = 1], it may start 1 second after the + first shard is received, which results in flakiness. With + [minimal_block_delay = 3], it may start only after 4s (see !18139), + which should be enough time for the observer to receive all the + shards. *) + ~minimal_block_delay:"3" "observer triggers amplification (without lost shards)" Amplification.test_amplification_without_lost_shards protocols ; -- GitLab