diff --git a/tezt/lib_tezos/accuser.ml b/tezt/lib_tezos/accuser.ml index 5140b8257269dceaed0237b0a71371b6aa1c242f..ba02d7d4cde6db3643bdaad2486c6674cca081a7 100644 --- a/tezt/lib_tezos/accuser.ml +++ b/tezt/lib_tezos/accuser.ml @@ -60,8 +60,8 @@ let set_ready accuser = let handle_raw_stdout accuser line = if line =~ rex "^Waiting for protocol .+ to start...$" then set_ready accuser -let create ~protocol ?(path = Uses.path (Protocol.accuser protocol)) ?name - ?color ?event_pipe ?base_dir ?runner ?preserved_levels node = +let create ?(path = Uses.path Constant.octez_accuser) ?name ?color ?event_pipe + ?base_dir ?runner ?preserved_levels node = let name = match name with None -> fresh_name () | Some name -> name in let base_dir = match base_dir with None -> Temp.dir name | Some dir -> dir @@ -126,13 +126,12 @@ let wait_for_ready accuser = resolver :: accuser.persistent_state.pending_ready ; check_event accuser "Accuser started." promise -let init ~protocol ?path ?name ?color ?event_pipe ?event_level ?base_dir ?runner +let init ?path ?name ?color ?event_pipe ?event_level ?base_dir ?runner ?preserved_levels node = let* () = Node.wait_for_ready node in let accuser = create ?path - ~protocol ?name ?color ?event_pipe diff --git a/tezt/lib_tezos/accuser.mli b/tezt/lib_tezos/accuser.mli index 46a0d4b2ba5b87ce0cd089c496c8c8c51fc7eddb..f3ebdbcd7474fad32f6e6f7cd886e97985e41a45 100644 --- a/tezt/lib_tezos/accuser.mli +++ b/tezt/lib_tezos/accuser.mli @@ -35,8 +35,7 @@ type event = {name : string; value : JSON.t; timestamp : float} This function just creates the [t] value, it does not call [run]. - [path] provides the path to the accuser binary, the default being the one - derived from the [protocol]. + [path] provides the path to the accuser binary. The standard output and standard error output of the accuser will be logged with prefix [name] and color [color]. @@ -58,7 +57,6 @@ type event = {name : string; value : JSON.t; timestamp : float} [preserved_levels] is the number of effective levels kept in the accuser's memory*) val create : - protocol:Protocol.t -> ?path:string -> ?name:string -> ?color:Log.Color.t -> @@ -134,8 +132,7 @@ val log_events : ?max_length:int -> t -> unit does not want to wait for the node to be ready, it is necessary to use [create] and then [run]. - [path] is the path to accuser binary. By default, it is chosen - from the [protocol] and is assumed to be at the root. + [path] is the path to accuser binary. The standard output and standard error output of the accuser will be logged with prefix [name] and color [color]. @@ -160,7 +157,6 @@ val log_events : ?max_length:int -> t -> unit [preserved_levels] is the number of effective levels kept in the accuser's memory *) val init : - protocol:Protocol.t -> ?path:string -> ?name:string -> ?color:Log.Color.t -> diff --git a/tezt/lib_tezos/agnostic_baker.ml b/tezt/lib_tezos/agnostic_baker.ml index a0dcb92b3a5c74680621556ebfc731fcf81e91f3..6fed64b76c650bb60b26a72b148d0350cad860b2 100644 --- a/tezt/lib_tezos/agnostic_baker.ml +++ b/tezt/lib_tezos/agnostic_baker.ml @@ -18,10 +18,6 @@ let liquidity_baking_vote_of_string_opt = function | "pass" -> Some Pass | _ -> None -type protocol_status = Active | Frozen | Ignore - -let protocol_status = function Protocol.Alpha -> Ignore | _ -> Active - (* This is hard-coded after the same value from [Daemon] module from [src/lib_agnostic_baker]. *) let extra_levels_for_old_baker = 3 diff --git a/tezt/lib_tezos/agnostic_baker.mli b/tezt/lib_tezos/agnostic_baker.mli index 7344da7aeb8b6f0406e15737b8e6af06e544df6b..a8b95c9e5b90c8ebf903fc8f30ca69cebdd502ff 100644 --- a/tezt/lib_tezos/agnostic_baker.mli +++ b/tezt/lib_tezos/agnostic_baker.mli @@ -78,12 +78,6 @@ val liquidity_baking_vote_of_string_opt : string -> liquidity_baking_vote option Returns the path to the file that was written. *) val liquidity_baking_votefile : ?path:string -> liquidity_baking_vote -> string -(** Protocol status values. *) -type protocol_status = Active | Frozen | Ignore - -(** Returns the protocol status given the full protocol value. *) -val protocol_status : Protocol.t -> protocol_status - (** Number of extra levels to keep the old baker alive before shutting it down. This extra time is used to avoid halting the chain in cases such as reorganization or high round migration blocks. *) diff --git a/tezt/lib_tezos/constant.ml b/tezt/lib_tezos/constant.ml index d1108954dfd5a33121c9d93c8f6aae20f979f8a0..e6b8940c56cc6f86953a07af1380d02e0bb2ac51 100644 --- a/tezt/lib_tezos/constant.ml +++ b/tezt/lib_tezos/constant.ml @@ -89,20 +89,30 @@ let _teztale_snitch = Uses.make ~tag:"teztale_snitch" ~path:"./octez-teztale-snitch" () (* TODO: Remove these once the binaries are completely removed from - [released-executables]. (issue : https://gitlab.com/tezos/tezos/-/issues/7763) *) + [released-executables] or [experimental-executables]. + (issue : https://gitlab.com/tezos/tezos/-/issues/7763) *) -let octez_baker_quebec = - Uses.make ~tag:"baker_psquebec" ~path:"./octez-baker-PsQuebec" () - -let octez_baker_rio = +let _octez_baker_rio = Uses.make ~tag:"baker_psriotum" ~path:"./octez-baker-PsRiotum" () -let octez_baker_seoul = +let _octez_baker_seoul = Uses.make ~tag:"baker_ptseoulo" ~path:"./octez-baker-PtSeouLo" () -let octez_baker_alpha = +let _octez_baker_alpha = Uses.make ~tag:"baker_alpha" ~path:"./octez-baker-alpha" () +let octez_agnostic_baker = + Uses.make ~tag:"agnostic_baker" ~path:"./octez-baker" () + +let _octez_accuser_rio = + Uses.make ~tag:"accuser_psriotum" ~path:"./octez-accuser-PsRiotum" () + +let _octez_accuser_seoul = + Uses.make ~tag:"accuser_ptseoulo" ~path:"./octez-accuser-PtSeouLo" () + +let _octez_accuser_alpha = + Uses.make ~tag:"accuser_alpha" ~path:"./octez-accuser-alpha" () + let octez_accuser = Uses.make ~tag:"accuser" ~path:"./octez-accuser" () let yes_wallet = @@ -164,9 +174,6 @@ module WASM = struct Uses.make ~tag:"tx_kernel_dal" ~path:"tx_kernel_dal.wasm" () end -let octez_agnostic_baker = - Uses.make ~tag:"agnostic_baker" ~path:"./octez-baker" () - let octez_p2p_node = Uses.make ~tag:"p2p_node" diff --git a/tezt/lib_tezos/protocol.ml b/tezt/lib_tezos/protocol.ml index e5cc9c6e8c308ffae2a84593e5f6bb20bc610ac7..8d128eeca3d8497a71f67ee3c7918fb191d54e26 100644 --- a/tezt/lib_tezos/protocol.ml +++ b/tezt/lib_tezos/protocol.ml @@ -80,23 +80,6 @@ let parameter_file ?(constants = default_constants) protocol = let name = constants_to_string constants in sf "src/%s/parameters/%s-parameters.json" (directory protocol) name -let daemon_name = function Alpha -> "alpha" | p -> String.sub (hash p) 0 8 - -let protocol_dependent_uses ~tag ~path = - let make protocol = - let protocol = daemon_name protocol in - Uses.make - ~tag:(tag ^ String.lowercase_ascii protocol) - ~path:(path ^ protocol) - () - in - (* Make sure [Uses.lookup] knows about all executables even before tests - actually registers themselves. *) - let _ = List.map make all in - make - -let accuser = protocol_dependent_uses ~tag:"accuser_" ~path:"./octez-accuser-" - let encoding_prefix = function | Alpha -> "alpha" | p -> sf "%03d-%s" (number p) (String.sub (hash p) 0 8) diff --git a/tezt/lib_tezos/protocol.mli b/tezt/lib_tezos/protocol.mli index 9e5ce4965e5689595cac12af7e7ac6de98ffae6d..579112dcaf3042d937adad422f63c9d8522bc1f2 100644 --- a/tezt/lib_tezos/protocol.mli +++ b/tezt/lib_tezos/protocol.mli @@ -85,14 +85,6 @@ val protocol_zero_hash : string directory of the protocol, relative to the root of the repository. *) val parameter_file : ?constants:constants -> t -> string -(** Get the path of the accuser of a protocol, such as ["./octez-accuser-alpha"]. *) -val accuser : t -> Uses.t - -(** Get the part of the daemon name that is specific to a protocol (e.g. ["PtEdo2Zk"]). - - This should not be used for anything except to compute the name of executables. *) -val daemon_name : t -> string - (** Get the part which is added at the beginning of all encoding names. *) val encoding_prefix : t -> string diff --git a/tezt/lib_wrapper/expected/tezt_wrapper.ml/runtime-dependency-tags.out b/tezt/lib_wrapper/expected/tezt_wrapper.ml/runtime-dependency-tags.out index d06d56ee55dcb6e0c9ea86429ec8e739f48ba81e..e7eb95d96cc6792a7d96411ff62b95a75a5832e3 100644 --- a/tezt/lib_wrapper/expected/tezt_wrapper.ml/runtime-dependency-tags.out +++ b/tezt/lib_wrapper/expected/tezt_wrapper.ml/runtime-dependency-tags.out @@ -14,7 +14,6 @@ accuser_ptseoulo: octez-accuser-PtSeouLo accuser_alpha: octez-accuser-alpha admin_client: octez-admin-client agnostic_baker: octez-baker -baker_psquebec: octez-baker-PsQuebec baker_psriotum: octez-baker-PsRiotum baker_ptseoulo: octez-baker-PtSeouLo baker_alpha: octez-baker-alpha diff --git a/tezt/remote_tests/double_bake.ml b/tezt/remote_tests/double_bake.ml index a872cd5c68481ebc2a821bcb2ba4d2f31fe58f2f..7ef703e78328cfefbd92c058fca5a28777b54719 100644 --- a/tezt/remote_tests/double_bake.ml +++ b/tezt/remote_tests/double_bake.ml @@ -113,7 +113,9 @@ let double_bake = in let endpoint_3 = Client.(Node node_3) in let* client_3 = Client.init ~endpoint:endpoint_3 () in - let* accuser_3 = Accuser.init ~protocol node_3 in + (* Need to know the protocol for the agnostic accuser to start. *) + let* () = Client.activate_protocol ~protocol client_3 in + let* accuser_3 = Accuser.init node_3 in let denunciation = wait_for_denunciation accuser_3 in let denunciation_injection = wait_for_denunciation_injection node_3 client_3 denunciation diff --git a/tezt/tests/adaptive_issuance.ml b/tezt/tests/adaptive_issuance.ml index c2dad5c14c17524164f582ce8c1927d236f1613b..841ff29f6702df87925a626a960bd8f01cfbc204 100644 --- a/tezt/tests/adaptive_issuance.ml +++ b/tezt/tests/adaptive_issuance.ml @@ -307,7 +307,7 @@ let test_staking = "rewards"; "slashing"; ] - ~uses:(fun protocol -> [Protocol.accuser protocol]) + ~uses:(fun _protocol -> [Constant.octez_accuser]) @@ fun protocol -> let overrides = (* TODO: https://gitlab.com/tezos/tezos/-/issues/7576 use a @@ -894,7 +894,9 @@ let test_staking = log_step 16 "Run Node 3, bake one block and wait for the accuser to be ready." ; let* node_3 = Node.init [Synchronisation_threshold 0; Private_mode] in let* client_3 = Client.init ~endpoint:(Node node_3) () in - let* accuser_3 = Accuser.init ~protocol node_3 in + (* Need to know the protocol for the agnostic accuser to start. *) + let* () = Client.activate_protocol ~protocol client_3 in + let* accuser_3 = Accuser.init node_3 in let denunciation_injection = wait_for_denunciation_injection node_3 client_3 accuser_3 in diff --git a/tezt/tests/agnostic_baker_test.ml b/tezt/tests/agnostic_baker_test.ml index 6d85078e84cf58c1c0fcdc1cef0ef15460aadf25..6b57df0768a747dc20aa003b7337c890559defba 100644 --- a/tezt/tests/agnostic_baker_test.ml +++ b/tezt/tests/agnostic_baker_test.ml @@ -272,11 +272,8 @@ let test_keep_alive = let register ~protocols = test_keep_alive protocols let register_migration ~migrate_from ~migrate_to = - (* We want to migrate only from Active protocols *) - if Agnostic_baker.protocol_status migrate_from = Active then ( - migrate ~migrate_from ~migrate_to ~use_remote_signer:false ; - migrate ~migrate_from ~migrate_to ~use_remote_signer:true) - else () + migrate ~migrate_from ~migrate_to ~use_remote_signer:false ; + migrate ~migrate_from ~migrate_to ~use_remote_signer:true let register_protocol_independent () = test_start_and_stop () ; diff --git a/tezt/tests/cloud/tezos.ml b/tezt/tests/cloud/tezos.ml index 95f13426680d161fddba4a9598c3f5ba123383e3..962d28bd8ea3f6d8179080767eb7789df275a763 100644 --- a/tezt/tests/cloud/tezos.ml +++ b/tezt/tests/cloud/tezos.ml @@ -580,8 +580,8 @@ module Accuser = struct include Accuser module Agent = struct - let init ?(group = "L1") ?name ~protocol - ?(path = Uses.path (Protocol.accuser protocol)) node cloud agent = + let init ?(group = "L1") ?name ?(path = Uses.path Constant.octez_accuser) + node cloud agent = let* path = Agent.copy agent ~source:path in let* () = Cloud.register_binary @@ -592,7 +592,7 @@ module Accuser = struct () in let runner = Agent.runner agent in - init ?name ~event_level:`Notice ?runner ~path ~protocol node + init ?name ~event_level:`Notice ?runner ~path node end end diff --git a/tezt/tests/double_bake.ml b/tezt/tests/double_bake.ml index 1c6ab3f93ebb60f729814f956e36b538954e7c2d..8a4530d67f5dfef937fced85926bcb98b71c9ddf 100644 --- a/tezt/tests/double_bake.ml +++ b/tezt/tests/double_bake.ml @@ -137,7 +137,7 @@ let double_bake = ~__FILE__ ~title:"double baking with accuser" ~tags:[team; "double"; "baking"; "accuser"; "node"] - ~uses:(fun protocol -> [Protocol.accuser protocol]) + ~uses:(fun _protocol -> [Constant.octez_accuser]) @@ fun protocol -> let log_step counter msg = let color = Log.Color.(bold ++ FG.blue) in @@ -206,7 +206,9 @@ let double_bake = log_step 4 "Run Node 3, bake one block and wait for the accuser to be ready." ; let* node_3 = Node.init [Synchronisation_threshold 0; Private_mode] in let* client_3 = Client.init ~endpoint:(Node node_3) () in - let* accuser_3 = Accuser.init ~protocol node_3 in + (* Need to know the protocol for the agnostic accuser to start. *) + let* () = Client.activate_protocol ~protocol client_3 in + let* accuser_3 = Accuser.init node_3 in let denunciation_injection = wait_for_denunciation_injection node_3 client_3 accuser_3 in diff --git a/tezt/tests/double_consensus.ml b/tezt/tests/double_consensus.ml index d0f77292debe598127489348637b014e78171e8b..ee43bab927f190203bf9fdb2433e8044bd524206 100644 --- a/tezt/tests/double_consensus.ml +++ b/tezt/tests/double_consensus.ml @@ -92,7 +92,7 @@ let double_consensus_init let* node, client = Client.init_with_protocol ?parameter_file ~protocol `Client () in - let* accuser = Accuser.init ~event_level:`Debug ~protocol node in + let* accuser = Accuser.init ~event_level:`Debug node in let* () = repeat 5 (fun () -> Client.bake_for_and_wait client) in Log.info "Recover available slots for %s." Constant.bootstrap1.alias ; let* slots = @@ -198,7 +198,7 @@ let double_attestation_wrong_block_payload_hash = ~title:"double attestation using wrong block_payload_hash" ~tags: [team; "double"; "attestation"; "accuser"; "block_payload_hash"; "node"] - ~uses:(fun protocol -> [Protocol.accuser protocol]) + ~uses:(fun _protocol -> [Constant.octez_accuser]) @@ fun protocol -> double_consensus_wrong_block_payload_hash attest_utils protocol @@ -210,7 +210,7 @@ let double_preattestation_wrong_block_payload_hash = [ team; "double"; "preattestation"; "accuser"; "block_payload_hash"; "node"; ] - ~uses:(fun protocol -> [Protocol.accuser protocol]) + ~uses:(fun _protocol -> [Constant.octez_accuser]) @@ fun protocol -> double_consensus_wrong_block_payload_hash preattest_utils protocol @@ -265,7 +265,7 @@ let double_attestation_wrong_branch = ~__FILE__ ~title:"double attestation using wrong branch" ~tags:[team; "double"; "attestation"; "accuser"; "branch"; "node"] - ~uses:(fun protocol -> [Protocol.accuser protocol]) + ~uses:(fun _protocol -> [Constant.octez_accuser]) @@ fun protocol -> double_consensus_wrong_branch attest_utils protocol let double_preattestation_wrong_branch = @@ -273,7 +273,7 @@ let double_preattestation_wrong_branch = ~__FILE__ ~title:"double preattestation using wrong branch" ~tags:[team; "double"; "preattestation"; "accuser"; "branch"; "node"] - ~uses:(fun protocol -> [Protocol.accuser protocol]) + ~uses:(fun _protocol -> [Constant.octez_accuser]) @@ fun protocol -> double_consensus_wrong_branch preattest_utils protocol let consensus_operation_too_old_waiter accuser = @@ -284,14 +284,14 @@ let operation_too_old = ~__FILE__ ~title:"operation too old" ~tags:[team; "accuser"; "old"; "operation"] - ~uses:(fun protocol -> [Protocol.accuser protocol]) + ~uses:(fun _protocol -> [Constant.octez_accuser]) @@ fun protocol -> let* node, client = Client.init_with_protocol ~protocol `Client () in let* accuser = (* We set the preserved_levels to 0 to ensure that an operation for the previous level is accepted by the mempool and discarded by the accuser. *) - Accuser.init ~preserved_levels:0 ~event_level:`Debug ~protocol node + Accuser.init ~preserved_levels:0 ~event_level:`Debug node in let* () = repeat 2 (fun () -> Client.bake_for_and_wait client) in Log.info "Inject valid attestation." ; @@ -347,12 +347,10 @@ let operation_too_far_in_future = ~__FILE__ ~title:"operation too far in the future" ~tags:[team; "accuser"; "future"; "operation"] - ~uses:(fun protocol -> [Protocol.accuser protocol]) + ~uses:(fun _protocol -> [Constant.octez_accuser]) @@ fun protocol -> let* node, client = Client.init_with_protocol ~protocol `Client () in - let* accuser = - Accuser.init ~preserved_levels:2 ~event_level:`Debug ~protocol node - in + let* accuser = Accuser.init ~preserved_levels:2 ~event_level:`Debug node in let* () = repeat 2 (fun () -> Client.bake_for_and_wait client) in Log.info "Inject valid attestation." ; let waiter = Node.wait_for_request ~request:`Inject node in @@ -523,7 +521,7 @@ let attestation_and_aggregation_wrong_payload_hash = ~title:"attestation and aggregation wrong payload hash" ~tags:[team; "attestation"; "aggregation"] ~supports:Protocol.(From_protocol 023) - ~uses:(fun protocol -> [Protocol.accuser protocol]) + ~uses:(fun _protocol -> [Constant.octez_accuser]) @@ fun protocol -> let consensus_rights_delay = 1 in let* parameter_file = @@ -544,10 +542,9 @@ let attestation_and_aggregation_wrong_payload_hash = Client.init_with_protocol `Client ~protocol ~parameter_file () in let* _ = Node.wait_for_level node 1 in - (* Run accusers (simulates a network were multiple denunciations are received + (* Run accuser (simulates a network were multiple denunciations are received simultaneously) *) - let* _accuser1 = Accuser.init ~protocol node in - let* _accuser2 = Accuser.init ~protocol node in + let* _accuser = Accuser.init node in (* Set a BLS consensus key for some bootstrap accounts *) let* ck1 = Client.update_fresh_consensus_key ~algo:"bls" bootstrap1 client in let* ck2 = Client.update_fresh_consensus_key ~algo:"bls" bootstrap2 client in @@ -632,7 +629,7 @@ let double_aggregation_wrong_payload_hash = ~title:"double aggregation wrong payload hash" ~tags:[team; "double"; "aggregation"] ~supports:Protocol.(From_protocol 023) - ~uses:(fun protocol -> [Protocol.accuser protocol]) + ~uses:(fun _protocol -> [Constant.octez_accuser]) @@ fun protocol -> let consensus_rights_delay = 1 in let* parameter_file = @@ -669,9 +666,8 @@ let double_aggregation_wrong_payload_hash = let* () = Client.Admin.connect_address ~peer:node1 client2 in let* () = Client.Admin.connect_address ~peer:node2 client1 in let* _ = Node.wait_for_level node2 1 in - (* Run accusers *) - let* _accuser1 = Accuser.init ~protocol node1 in - let* _accuser2 = Accuser.init ~protocol node2 in + (* Run accuser *) + let* _accuser = Accuser.init node1 in (* Set BLS consensus key for some bootstrap accounts *) let* ck1 = Client.update_fresh_consensus_key ~algo:"bls" bootstrap1 client1 in let* ck2 = Client.update_fresh_consensus_key ~algo:"bls" bootstrap2 client1 in @@ -794,27 +790,23 @@ let accusers_migration_test ~migrate_from ~migrate_to = (Protocol.tag migrate_to)) ~tags: [team; "migration"; Protocol.tag migrate_from; Protocol.tag migrate_to] - ~uses:[Protocol.accuser migrate_from; Protocol.accuser migrate_to] + ~uses:[Constant.octez_accuser] @@ fun () -> let* client, node = Protocol_migration.user_migratable_node_init ~migration_level ~migrate_to () in let* () = Client.activate_protocol ~protocol:migrate_from client in - Log.info "Initialise accusers for the two protocols" ; - let* accuser1 = - Accuser.init ~protocol:migrate_from ~event_level:`Debug node - in - let accuser1_processed_block = accuser_processed_block accuser1 in - let accuser1_stop = daemon_stop accuser1 in - let* accuser2 = Accuser.init ~protocol:migrate_to ~event_level:`Debug node in - let accuser2_processed_block = accuser_processed_block accuser2 in + Log.info "Initialise accuser" ; + let* accuser = Accuser.init ~event_level:`Debug node in + let accuser_processed_block = accuser_processed_block accuser in + let accuser_stop = daemon_stop accuser in Log.info "Bake %d levels" (migration_level - 1) ; let* () = repeat (migration_level - 1) (fun () -> let* () = Client.bake_for_and_wait client in - accuser1_processed_block) + accuser_processed_block) in Log.info @@ -824,7 +816,7 @@ let accusers_migration_test ~migrate_from ~migrate_to = let* () = Client.bake_for_and_wait client in Log.info "After migration, old protocol accuser should have stopped" ; - let* () = accuser1_stop in + let* () = accuser_stop in Log.info "Bake a few more levels into the new protocol" ; let* () = @@ -837,9 +829,9 @@ let accusers_migration_test ~migrate_from ~migrate_to = client in let* () = Client.bake_for_and_wait client in - accuser2_processed_block) + accuser_processed_block) in - let* () = Accuser.terminate accuser2 in + let* () = Accuser.terminate accuser in unit let register_migration ~migrate_from ~migrate_to = diff --git a/tezt/tests/voting.ml b/tezt/tests/voting.ml index 23e5bfde41d82449c557e26362b780f69f472e12..192f39543cbd3995eb49ba527521fcb5f739535f 100644 --- a/tezt/tests/voting.ml +++ b/tezt/tests/voting.ml @@ -888,7 +888,7 @@ let test_user_activated_protocol_override_baker_vote ~from_protocol ~to_protocol "from_" ^ Protocol.tag from_protocol; "to_" ^ Protocol.tag to_protocol; ] - ~uses:[Protocol.accuser to_protocol; Constant.octez_agnostic_baker] + ~uses:[Constant.octez_accuser; Constant.octez_agnostic_baker] @@ fun () -> let node_arguments = [Node.Synchronisation_threshold 0] in let to_protocol_hash = Protocol.hash to_protocol in @@ -1223,7 +1223,7 @@ let test_user_activated_protocol_override_baker_vote ~from_protocol ~to_protocol (* We also start an accuser for the [to_protocol] protocol. After the protocol switch, we verify that it starts registering blocks. *) - let to_protocol_accuser = Accuser.create ~protocol:to_protocol node in + let to_protocol_accuser = Accuser.create node in let to_protocol_accuser_received_block = Accuser.wait_for to_protocol_accuser