From 83a20f53fe8666b61759e283b8d9a1f04c90142d Mon Sep 17 00:00:00 2001 From: Paul Laforgue Date: Wed, 26 Mar 2025 07:47:29 +0100 Subject: [PATCH 1/3] DAL/Node: deprecate the experimental feature flag `sqlite3-backend` --- src/bin_dal_node/cli.ml | 5 ++--- src/bin_dal_node/configuration_file.ml | 3 +++ 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/src/bin_dal_node/cli.ml b/src/bin_dal_node/cli.ml index d6cc8d17391c..2137e6ecffcf 100644 --- a/src/bin_dal_node/cli.ml +++ b/src/bin_dal_node/cli.ml @@ -358,9 +358,8 @@ module Term = struct the default one. *) let open Cmdliner in let doc = - "Experimental feature, please dont use it unless you know what you are \ - doing. Configure the DAL node store to use SQLite3 as a storage \ - backend. " + "DEPRECATED as SQLite is now the default storage backend for storing \ + skip list cells for DAL slots." in Arg.(value & flag & info ~docs ~doc ["sqlite3-backend"]) diff --git a/src/bin_dal_node/configuration_file.ml b/src/bin_dal_node/configuration_file.ml index 732a6bd3d342..2729a3ddd14c 100644 --- a/src/bin_dal_node/configuration_file.ml +++ b/src/bin_dal_node/configuration_file.ml @@ -176,6 +176,9 @@ let experimental_features_encoding : experimental_features Data_encoding.t = (obj1 (dft "sqlite3-backend" + ~description: + "DEPRECATED as SQLite is now the default storage backend for \ + storing skip list cells for DAL slots." bool default_experimental_features.sqlite3_backend)) -- GitLab From ec021bad92a8a1acc933c8bb56190c1971e2398b Mon Sep 17 00:00:00 2001 From: Paul Laforgue Date: Wed, 26 Mar 2025 06:37:21 +0100 Subject: [PATCH 2/3] CHANGES: deprecate the experimental feature flag `sqlite3-backend` --- CHANGES.rst | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/CHANGES.rst b/CHANGES.rst index 4efc744afa1f..565b80d20a1c 100644 --- a/CHANGES.rst +++ b/CHANGES.rst @@ -292,6 +292,11 @@ DAL node the connection attempt failed. However, this MR fixes the timing when those attempts were made. (MR :gl:`!16466`) +- **Deprecation** The CLI experimental flag ``--sqlite3-backend`` and its + corresponding configuration file field have been deprecated since + SQLite is now the default storage backend for storing skip list + cells for DAL slots. + - **Feature** The DAL node stores now a peers.json file in its directory when it is shutdown with SIGINT. This file is read if it exists when starting the DAL node to restore previous known -- GitLab From 45f01d63c8de5da108b531a6d32a93a6694c069e Mon Sep 17 00:00:00 2001 From: Paul Laforgue Date: Wed, 26 Mar 2025 07:56:52 +0100 Subject: [PATCH 3/3] DAL/Node: update issue description --- src/bin_dal_node/cli.ml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/bin_dal_node/cli.ml b/src/bin_dal_node/cli.ml index 2137e6ecffcf..6dedc75ce162 100644 --- a/src/bin_dal_node/cli.ml +++ b/src/bin_dal_node/cli.ml @@ -354,8 +354,7 @@ module Term = struct let sqlite3_backend = (* FIXME: https://gitlab.com/tezos/tezos/-/issues/7527 - Remove this command line argument once the SQLite3 backend is - the default one. *) + Remove this command line argument in the next release. *) let open Cmdliner in let doc = "DEPRECATED as SQLite is now the default storage backend for storing \ -- GitLab