From 925665232185b027f54aca4e75f0850c67c0f0a8 Mon Sep 17 00:00:00 2001 From: "iguerNL@Functori" Date: Thu, 12 Dec 2024 14:14:22 +0100 Subject: [PATCH] DAL/GS/P2P: remove the expected_peer_id check --- src/lib_dal_node/gossipsub/gs_transport_connection.ml | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/src/lib_dal_node/gossipsub/gs_transport_connection.ml b/src/lib_dal_node/gossipsub/gs_transport_connection.ml index bfb604af4c4e..bce3ae0c6206 100644 --- a/src/lib_dal_node/gossipsub/gs_transport_connection.ml +++ b/src/lib_dal_node/gossipsub/gs_transport_connection.ml @@ -185,8 +185,17 @@ let try_connect ?expected_peer_id p2p_layer ~trusted point = be delayed. *) Lwt.dont_wait (fun () -> + (* We don't check [expected_peer_id] anymore because people frequently + wipe / regenerate their peer identities while keeping the same IP + addresses. The [expected_peer_id] check, if enabled, will make + Octez-p2p reject any other connection with a different identity. *) + (* DAL/TODO: https://gitlab.com/tezos/tezos/-/issues/7646 + + Implement a better PX exchange. + *) + ignore expected_peer_id ; let* (_ : _ P2p.connection tzresult) = - P2p.connect ?expected_peer_id ~trusted p2p_layer point + P2p.connect ~trusted p2p_layer point in return_unit) (fun exn -> -- GitLab