[go: up one dir, main page]

Profiler: Remove CPU time and delta from columns in profiling outputs

Gabriel Moiserequested to merge
gabriel@profiling-remove-columns into master

What

Closes #7626 (closed)

Here, I advocate that by removing the confusing columns, the other columns are quite trivial to understand.

I tried to add a line at the beginning, but I could only add in a way that the following line:

PROFILING_OUTPUT_ID ......................................................... COUNTER .... WALL TIME (ms)

gets added before every block section, which is undesirable, in my opinion.

Why

How

Manually testing the MR

Check any profiling file, it should have only 3 columns, like this:

2024-12-04T11:52:18.111-00:00
locked compute live blocks with cache .......................................... 1           59.942ms
  compute live blocks with alternative branch .................................. 1           59.940ms
compute_live_blocks ............................................................ 1            0.001ms
2024-12-04T11:52:18.758-00:00
BLH52fkLw8VWdogpEwtBkEdsH9WNXK9CDF779JtFpGyPjtSw2XU ............................ 1           38.406ms
  compute_live_blocks .......................................................... 1            0.001ms
  store_block .................................................................. 1            0.444ms
  set_head ..................................................................... 1            0.926ms
    get_pred_block ............................................................. 1            0.002ms
    may_split_context .......................................................... 1            0.001ms
    finalize_set_head .......................................................... 1            0.913ms
      write_new_head ........................................................... 1            0.306ms
      write_new_target ......................................................... 1            0.001ms
      updating live blocks ..................................................... 1            0.120ms
        locked compute live blocks with cache .................................. 1            0.119ms
          compute live blocks with new head .................................... 1            0.117ms

Checklist

  • Document the interface of any function added or modified (see the coding guidelines)
  • Document any change to the user interface, including configuration parameters (see node configuration)
  • Provide automatic testing (see the testing guide).
  • For new features and bug fixes, add an item in the appropriate changelog (docs/protocols/alpha.rst for the protocol and the environment, CHANGES.rst at the root of the repository for everything else).
  • Select suitable reviewers using the Reviewers field below.
  • Select as Assignee the next person who should take action on that MR

Merge request reports