From 9f09b61c0c7713421a9cc35915aeda14c1227daf Mon Sep 17 00:00:00 2001
From: Valentin Chaboche <valentin.chaboche@nomadic-labs.com>
Date: Mon, 16 Sep 2024 11:14:14 +0200
Subject: [PATCH] EVM/Kernel: fail on FA withdrawal if there's no transfer
 object

---
 .../kernel_evm/evm_execution/src/precompiles/fa_bridge.rs | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/etherlink/kernel_evm/evm_execution/src/precompiles/fa_bridge.rs b/etherlink/kernel_evm/evm_execution/src/precompiles/fa_bridge.rs
index a244e6879d12..cfb4c22c9d99 100644
--- a/etherlink/kernel_evm/evm_execution/src/precompiles/fa_bridge.rs
+++ b/etherlink/kernel_evm/evm_execution/src/precompiles/fa_bridge.rs
@@ -121,7 +121,7 @@ pub fn fa_bridge_precompile<Host: Runtime>(
     if transfer
         .as_ref()
         .map(|t| !t.value.is_zero())
-        .unwrap_or(false)
+        .unwrap_or(true)
     {
         return Ok(precompile_outcome_error!(
             "FA withdrawal: unexpected value transfer {:?}",
@@ -219,7 +219,7 @@ mod tests {
             &mut mock_runtime,
             &mut evm_account_storage,
             H160::from_low_u64_be(1),
-            None,
+            Some(U256::zero()),
             vec![0x00, 0x01, 0x02, 0x03],
             None,
             false,
@@ -351,7 +351,7 @@ mod tests {
             &mut mock_runtime,
             &mut evm_account_storage,
             H160::from_low_u64_be(1),
-            None,
+            Some(U256::zero()),
             vec![0x80, 0xfc, 0x1f, 0xe3],
             None,
             false,
@@ -404,7 +404,7 @@ mod tests {
             &mut mock_runtime,
             &mut evm_account_storage,
             ticket_owner,
-            None,
+            Some(U256::zero()),
             input,
             Some(30_000_000),
             false,
-- 
GitLab