From d06c276de973bf0059567877568596013df1a40a Mon Sep 17 00:00:00 2001 From: Albin Coquereau Date: Fri, 18 Aug 2023 10:12:57 +0200 Subject: [PATCH 1/2] plugin: increase RPC version default value --- src/proto_alpha/lib_plugin/RPC.ml | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/src/proto_alpha/lib_plugin/RPC.ml b/src/proto_alpha/lib_plugin/RPC.ml index aa2a40100595..a8636332df76 100644 --- a/src/proto_alpha/lib_plugin/RPC.ml +++ b/src/proto_alpha/lib_plugin/RPC.ml @@ -38,16 +38,15 @@ let version_of_string = function | "1" -> Ok Version_1 | _ -> Error "Cannot parse version (supported versions \"0\" and \"1\")" -let default_operations_version = Version_0 +let default_operations_version = Version_1 let version_arg = let open RPC_arg in make ~descr: - "Supported RPC versions are version '0' (default but deprecated) that \ - will output attestation operations as \"endorsement\" in the \"kind\" \ - field and version '1' that will output \"attestation\" in the \"kind\" \ - field" + "Supported RPC versions are version '1' (default) that will output \ + \"attestation\" in the \"kind\" field and version '0' (deprecated) that \ + will output \"endorsement\"" ~name:"version" ~destruct:version_of_string ~construct:string_of_version -- GitLab From 0f757b589c35de44647c4ab79dafcd6beeee7d50 Mon Sep 17 00:00:00 2001 From: Albin Coquereau Date: Fri, 18 Aug 2023 10:16:42 +0200 Subject: [PATCH 2/2] changes: add entry for RPC version bumping --- CHANGES.rst | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/CHANGES.rst b/CHANGES.rst index a9b29e3cb125..0e4aff560270 100644 --- a/CHANGES.rst +++ b/CHANGES.rst @@ -45,6 +45,11 @@ Node ``2``. Version ``0`` has been removed and version ``1`` can still be used with ``?version=1`` argument. (MR :gl:`!11872`) +- Bump RPCs ``POST ../helpers/parse/operations``, ``POST + ../helpers/scripts/run_operation`` and ``POST + ../helpers/scripts/simulate_operation`` default version to version ``1``. + Version ``0`` can still be used with ``?version=0`` argument. (MR :gl:`!11889`) + Client ------ -- GitLab