From 93b9553f14b14eabe75cd66edc98e64c2142a82c Mon Sep 17 00:00:00 2001 From: Peter Leitzen Date: Wed, 20 Nov 2024 09:58:08 +0000 Subject: [PATCH 1/4] Update README.md --- README.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/README.md b/README.md index 4bd36a4..28902da 100644 --- a/README.md +++ b/README.md @@ -1,5 +1,7 @@ # `danger-review` component +Just a test. + The component generates a `danger-review` job which posts an automated comment after running the Danger rules from the project. ## Usage -- GitLab From a8fbe95e227a95a4dd605ca12193841ecf2ca44c Mon Sep 17 00:00:00 2001 From: Peter Leitzen Date: Wed, 20 Nov 2024 10:15:53 +0000 Subject: [PATCH 2/4] Use other token name --- .gitlab-ci.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index e951782..c2596b6 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -43,5 +43,6 @@ include: - component: "gitlab.com/gitlab-org/components/danger-review/danger-review@$CI_COMMIT_SHA" inputs: dry_run: true + gitlab_api_token_variable_name: "DANGER_API_TOKEN" rules: - if: '$CI_MERGE_REQUEST_IID' -- GitLab From 4c279c9fce17e7eac566fda5f20cf7a0bdc62125 Mon Sep 17 00:00:00 2001 From: Peter Leitzen Date: Wed, 20 Nov 2024 10:17:10 +0000 Subject: [PATCH 3/4] Refer to main --- .gitlab-ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index c2596b6..f854716 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -40,7 +40,7 @@ create-release: include: - template: "Workflows/MergeRequest-Pipelines.gitlab-ci.yml" - - component: "gitlab.com/gitlab-org/components/danger-review/danger-review@$CI_COMMIT_SHA" + - component: "gitlab.com/gitlab-org/components/danger-review/danger-review@main" inputs: dry_run: true gitlab_api_token_variable_name: "DANGER_API_TOKEN" -- GitLab From 81cfb4171b146cdbee60ff888d446a58cb42bf89 Mon Sep 17 00:00:00 2001 From: Peter Leitzen Date: Wed, 20 Nov 2024 11:30:26 +0100 Subject: [PATCH 4/4] debug2 --- .gitlab-ci.yml | 2 +- templates/danger-review/template.yml | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index f854716..b6cf7ca 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -40,7 +40,7 @@ create-release: include: - template: "Workflows/MergeRequest-Pipelines.gitlab-ci.yml" - - component: "gitlab.com/gitlab-org/components/danger-review/danger-review@main" + - component: "gitlab.com/splattael/danger-review/danger-review@$CI_COMMIT_SHA" inputs: dry_run: true gitlab_api_token_variable_name: "DANGER_API_TOKEN" diff --git a/templates/danger-review/template.yml b/templates/danger-review/template.yml index e0f775a..9717a5a 100644 --- a/templates/danger-review/template.yml +++ b/templates/danger-review/template.yml @@ -41,6 +41,9 @@ danger-review: - runner_system_failure - stuck_or_timeout_failure before_script: + - echo "var" + - echo $[[ inputs.gitlab_api_token_variable_name ]] + - echo $$[[ inputs.gitlab_api_token_variable_name ]] # If we have a `Gemfile`, then we're good (we assume `danger`/`gitlab-dangerfiles` is part of the `Gemfile`), otherwise, we create a `Gemfile` and add `gitlab-dangerfiles` to it. - '[[ -f "Gemfile" ]] || (bundle init && bundle add gitlab-dangerfiles --version "$[[ inputs.gitlab_dangerfiles_version ]]")' # If we have no `Gemfile.lock`, then we're good (because we don't have a precise list of gem versions to install anyway), otherwise, we freeze the gems, just in case. -- GitLab