From 6dae9574cd4d08d8cd281dc5c42ea7c17f6ce839 Mon Sep 17 00:00:00 2001
From: OyyoDams <oyyodams@recalbox.com>
Date: Thu, 7 Nov 2019 15:50:18 +0100
Subject: [PATCH] feat: replace ext4 by exfat for internal share

---
 CHANGELOG.md                                               | 1 +
 RELEASE-NOTES.md                                           | 1 +
 board/recalbox/fsoverlay/etc/init.d/S11share               | 7 ++-----
 .../recalbox/fsoverlay/recalbox/scripts/recalbox-mount.sh  | 1 +
 4 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 526d782cd8..c4db8db7dd 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -70,6 +70,7 @@ This project adheres to [Semantic Versioning](http://semver.org/).
 - Add support for mp3, opus, midi, modules, wave and flac in EmulationStation
 - Bump Amiberry to v3.1.3
 - Add naomigd as a separate system
+- Share partition now created with exfat instead of ext4
 
 ## [6.1.1]
 - Add zfast shaders
diff --git a/RELEASE-NOTES.md b/RELEASE-NOTES.md
index da94491942..849ee78113 100644
--- a/RELEASE-NOTES.md
+++ b/RELEASE-NOTES.md
@@ -22,6 +22,7 @@
 - Prboom system has been renamed to Doom
 - Libretro puae emulates amigacd32 now
 - Bump Amiberry to v3.1.3
+- Share partition on fresh install is now in extfat instead of ext4
 
 ### Improvements
 - Improve internal Scraper (ScreenScraper):
diff --git a/board/recalbox/fsoverlay/etc/init.d/S11share b/board/recalbox/fsoverlay/etc/init.d/S11share
index 150b7783a9..ab57b5ce7d 100755
--- a/board/recalbox/fsoverlay/etc/init.d/S11share
+++ b/board/recalbox/fsoverlay/etc/init.d/S11share
@@ -47,7 +47,7 @@ getMaxTryConfig() {
     echo 7 # default value
 }
 
-INTERNALDEVICETYPE="ext4" # faster than waiting udev to initialize to get the type
+INTERNALDEVICETYPE="exfat" # faster than waiting udev to initialize to get the type
 MAXTRY=$(getMaxTryConfig "${SHARECONFFILE}")
 NTRY=0
 
@@ -73,10 +73,7 @@ then
 	    parted -s "${PARTPREFIX}" -m unit b mkpart primary "${PSTART}" 100%
 	    if test -e "${INTERNALDEVICE}"
 	    then
-		#mkfs.vfat -F 32 -n SHARE /dev/mmcblk0p3 # if you replace this line, please change the INTERNALDEVICETYPE variable too in consequence
-		#fsck.fat /dev/mmcblk0p3 -a
-		mkfs.ext4 "${INTERNALDEVICE}" -q -F -L SHARE
-		e2fsck -f -p "${INTERNALDEVICE}"
+		mkexfatfs -n SHARE "${INTERNALDEVICE}"
 	    fi
 	fi
     fi
diff --git a/board/recalbox/fsoverlay/recalbox/scripts/recalbox-mount.sh b/board/recalbox/fsoverlay/recalbox/scripts/recalbox-mount.sh
index 849b40b9cf..a3f849edaa 100755
--- a/board/recalbox/fsoverlay/recalbox/scripts/recalbox-mount.sh
+++ b/board/recalbox/fsoverlay/recalbox/scripts/recalbox-mount.sh
@@ -44,6 +44,7 @@ case "${FSTYPE}" in
 	# required for exfat
 	# note that we can't just put in /etc/modules.conf because it is loaded too late after udev and share mounting
 	modprobe fuse
+	FSMOUNTOPT="${FSMOUNTOPT},nonempty"
 	;;
 esac
 
-- 
GitLab