From 594e80769d9c17d40c8046c83fdcc51b14f12421 Mon Sep 17 00:00:00 2001 From: Adrien Beudin Date: Sat, 22 Nov 2025 19:04:39 +0100 Subject: [PATCH 1/5] feat: can override shader in retroarch.cfg --- .../generators/libretro/libretroConfigurations.py | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/projects/configgen/configgen/generators/libretro/libretroConfigurations.py b/projects/configgen/configgen/generators/libretro/libretroConfigurations.py index 797a0b0aba..4f14ba15c0 100644 --- a/projects/configgen/configgen/generators/libretro/libretroConfigurations.py +++ b/projects/configgen/configgen/generators/libretro/libretroConfigurations.py @@ -89,7 +89,7 @@ class LibretroConfiguration: return retroarchOverrides @staticmethod - def getCommandLineArguments(retroarchConfig: keyValueSettings, _): + def getCommandLineArguments(self, retroarchConfig: keyValueSettings, _): # No result yet result = [] @@ -99,11 +99,15 @@ class LibretroConfiguration: # That way the users can use both system: # - Internal Retroarch configuration/override # - Recalbox configuration and overrides - if retroarchConfig.hasOption("video_shader"): + shader = "" + retroarchOverrides = self.loadRetroarchOverrides() + if retroarchOverrides.hasOption("video_shader"): + shader = retroarchOverrides.getString("video_shader", "") + elif retroarchConfig.hasOption("video_shader"): shader = retroarchConfig.getString("video_shader", "") - if len(shader) != 0: - result.append("--set-shader") - result.append(shader) + if len(shader) != 0: + result.append("--set-shader") + result.append(shader) return result -- GitLab From 7986e9e221ba3872eafbcb4de92c8456977ed865 Mon Sep 17 00:00:00 2001 From: Adrien Beudin Date: Sat, 22 Nov 2025 19:11:50 +0100 Subject: [PATCH 2/5] fix: load override file --- .../configgen/generators/libretro/libretroConfigurations.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/projects/configgen/configgen/generators/libretro/libretroConfigurations.py b/projects/configgen/configgen/generators/libretro/libretroConfigurations.py index 4f14ba15c0..9e128346b4 100644 --- a/projects/configgen/configgen/generators/libretro/libretroConfigurations.py +++ b/projects/configgen/configgen/generators/libretro/libretroConfigurations.py @@ -89,7 +89,7 @@ class LibretroConfiguration: return retroarchOverrides @staticmethod - def getCommandLineArguments(self, retroarchConfig: keyValueSettings, _): + def getCommandLineArguments(retroarchConfig: keyValueSettings, _): # No result yet result = [] @@ -100,7 +100,7 @@ class LibretroConfiguration: # - Internal Retroarch configuration/override # - Recalbox configuration and overrides shader = "" - retroarchOverrides = self.loadRetroarchOverrides() + retroarchOverrides = LibretroConfiguration.loadRetroarchOverrides() if retroarchOverrides.hasOption("video_shader"): shader = retroarchOverrides.getString("video_shader", "") elif retroarchConfig.hasOption("video_shader"): -- GitLab From c60c6cd47518836d627748beb0b867301c734b51 Mon Sep 17 00:00:00 2001 From: Adrien Beudin Date: Sat, 22 Nov 2025 20:15:09 +0100 Subject: [PATCH 3/5] fix: load override file --- .../configgen/generators/libretro/libretroConfigurations.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/projects/configgen/configgen/generators/libretro/libretroConfigurations.py b/projects/configgen/configgen/generators/libretro/libretroConfigurations.py index 9e128346b4..e4844b4219 100644 --- a/projects/configgen/configgen/generators/libretro/libretroConfigurations.py +++ b/projects/configgen/configgen/generators/libretro/libretroConfigurations.py @@ -100,7 +100,7 @@ class LibretroConfiguration: # - Internal Retroarch configuration/override # - Recalbox configuration and overrides shader = "" - retroarchOverrides = LibretroConfiguration.loadRetroarchOverrides() + retroarchOverrides = LibretroConfiguration.loadRetroarchOverrides(LibretroConfiguration) if retroarchOverrides.hasOption("video_shader"): shader = retroarchOverrides.getString("video_shader", "") elif retroarchConfig.hasOption("video_shader"): -- GitLab From 38938b7c9ce64d30da9fb944d6eced51b0e93e61 Mon Sep 17 00:00:00 2001 From: Adrien Beudin Date: Sat, 22 Nov 2025 20:17:55 +0100 Subject: [PATCH 4/5] fix: load override file --- .../configgen/generators/libretro/libretroConfigurations.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/projects/configgen/configgen/generators/libretro/libretroConfigurations.py b/projects/configgen/configgen/generators/libretro/libretroConfigurations.py index e4844b4219..4f14ba15c0 100644 --- a/projects/configgen/configgen/generators/libretro/libretroConfigurations.py +++ b/projects/configgen/configgen/generators/libretro/libretroConfigurations.py @@ -89,7 +89,7 @@ class LibretroConfiguration: return retroarchOverrides @staticmethod - def getCommandLineArguments(retroarchConfig: keyValueSettings, _): + def getCommandLineArguments(self, retroarchConfig: keyValueSettings, _): # No result yet result = [] @@ -100,7 +100,7 @@ class LibretroConfiguration: # - Internal Retroarch configuration/override # - Recalbox configuration and overrides shader = "" - retroarchOverrides = LibretroConfiguration.loadRetroarchOverrides(LibretroConfiguration) + retroarchOverrides = self.loadRetroarchOverrides() if retroarchOverrides.hasOption("video_shader"): shader = retroarchOverrides.getString("video_shader", "") elif retroarchConfig.hasOption("video_shader"): -- GitLab From 7c22d409ea030c19de24721a7b4f1fedaa074f08 Mon Sep 17 00:00:00 2001 From: Adrien Beudin Date: Sun, 23 Nov 2025 10:36:45 +0100 Subject: [PATCH 5/5] fix: load override file --- .../configgen/generators/libretro/libretroConfigurations.py | 1 - 1 file changed, 1 deletion(-) diff --git a/projects/configgen/configgen/generators/libretro/libretroConfigurations.py b/projects/configgen/configgen/generators/libretro/libretroConfigurations.py index 4f14ba15c0..36700aa646 100644 --- a/projects/configgen/configgen/generators/libretro/libretroConfigurations.py +++ b/projects/configgen/configgen/generators/libretro/libretroConfigurations.py @@ -88,7 +88,6 @@ class LibretroConfiguration: return retroarchOverrides - @staticmethod def getCommandLineArguments(self, retroarchConfig: keyValueSettings, _): # No result yet result = [] -- GitLab