[go: up one dir, main page]

load_soln_spec_from_dict: checks bool without taking action

This code in SolnSpecService.py seems to compute a bool but not act on the result:

    serializer = SolnSpecSerializer(data=soln_spec_dict)
    serializer.is_valid()   # <----- ????

    return serializer.create(serializer.validated_data)

should that be assert serializer.is_valid()?