From 9deb8ada2d0d4d7c1381a8290ea6c2cfae763998 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=BCrgen=20E=2E=20Fischer?= Date: Wed, 10 Sep 2025 18:52:18 +0000 Subject: [PATCH 1/2] docs: fix various typo --- docs/cli.rst | 4 ++-- py3dtiles/convert.py | 4 ++-- py3dtiles/export.py | 8 ++++---- py3dtiles/tilers/base_tiler/tiler.py | 2 +- py3dtiles/tilers/point/point_tiler.py | 2 +- py3dtiles/tileset/content/gltf_utils.py | 2 +- site/index.html | 2 +- 7 files changed, 12 insertions(+), 12 deletions(-) diff --git a/docs/cli.rst b/docs/cli.rst index ad182ed2..a3b27fe9 100644 --- a/docs/cli.rst +++ b/docs/cli.rst @@ -4,7 +4,7 @@ Command line usage info ~~~~ -The info sub-command outputs informations from a 3DTiles file in the .pnts or .b3dm format. +The info sub-command outputs information from a 3DTiles file in the .pnts or .b3dm format. Here is an example on how to retrieve basic information about a tile binary content, in this case *pointCloudRGB.pnts*: @@ -72,7 +72,7 @@ correctly placed. Usage example: $ export_tileset -d my_directory -o 10000 10000 0 -The database export requires a connexion info string, the name of the table and its +The database export requires a connection info string, the name of the table and its column that contains the geometry and (optionally) the name of the column that contains the object's ID. Usage example: diff --git a/py3dtiles/convert.py b/py3dtiles/convert.py index 192b0a66..9e7b6e72 100644 --- a/py3dtiles/convert.py +++ b/py3dtiles/convert.py @@ -266,7 +266,7 @@ def convert( :param extra_fields: Extra fields names to include in this conversion. These field names should be present in each input files. Currently vlrs and evlrs are not supported for las files. :param color_scale: Scale the color with the specified amount. Useful to lighten or darken black pointclouds with only intensity. - :raises SrsInMissingException: if py3dtiles couldn't find srs informations in input files and srs_in is not specified + :raises SrsInMissingException: if py3dtiles couldn't find srs information in input files and srs_in is not specified :raises SrsInMixinException: if the input files have different CRS """ @@ -382,7 +382,7 @@ class Converter: :param outfolder: The folder where the resulting tileset will be written. :param overwrite: Overwrite the ouput folder if it already exists. - :raises SrsInMissingException: if py3dtiles couldn't find srs informations in input files and srs_in is not specified + :raises SrsInMissingException: if py3dtiles couldn't find srs information in input files and srs_in is not specified :raises SrsInMixinException: if the input files have different CRS """ diff --git a/py3dtiles/export.py b/py3dtiles/export.py index 18dcba44..37633b76 100644 --- a/py3dtiles/export.py +++ b/py3dtiles/export.py @@ -172,7 +172,7 @@ def arrays2tileset( tree.add(node) divide( tile, - geoms[features_per_tile : len(geoms)], + geoms[features_per_tile: len(geoms)], i * 2, j * 2, max_tile_size / 2.0, @@ -243,7 +243,7 @@ def divide( parent.add(node) divide( tile, - geoms[features_per_tile : len(geoms)], + geoms[features_per_tile: len(geoms)], (x_offset + i) * 2, (y_offset + j) * 2, tile_size / 2.0, @@ -266,7 +266,7 @@ def wkbs_to_tileset( def build_secure_conn(db_conn_info: str) -> psycopg2.extensions.connection: - """Get a psycopg2 connexion securely, e.g. without writing the password explicitely + """Get a psycopg2 connection securely, e.g. without writing the password explicitely in the terminal Parameters @@ -370,7 +370,7 @@ def _init_parser( parser.add_argument("-o", nargs=3, metavar=("X", "Y", "Z"), type=float, help=o_help) D_help = """ - Database connexion info (e.g. 'service=py3dtiles' or \ + Database connection info (e.g. 'service=py3dtiles' or \ 'dbname=py3dtiles host=localhost port=5432 user=yourname password=yourpwd') """ group.add_argument("-D", metavar="DB_CONNINFO", type=str, help=D_help) diff --git a/py3dtiles/tilers/base_tiler/tiler.py b/py3dtiles/tilers/base_tiler/tiler.py index 71be2b84..a11486ec 100644 --- a/py3dtiles/tilers/base_tiler/tiler.py +++ b/py3dtiles/tilers/base_tiler/tiler.py @@ -86,7 +86,7 @@ class Tiler(ABC, Generic[_SharedMetadataT, _TilerWorkerT]): ) -> None: """ This method will be called first by convert to initialize the conversion - process. Tilers will receive all the paths informations as argument to + process. Tilers will receive all the paths information as argument to this method. Only files supported by this tiler will be in the files argument. Tilers are expected to gather metadata from those input files so that subsequent call to `get_tasks` can generate some diff --git a/py3dtiles/tilers/point/point_tiler.py b/py3dtiles/tilers/point/point_tiler.py index ac409ad7..accd2c30 100644 --- a/py3dtiles/tilers/point/point_tiler.py +++ b/py3dtiles/tilers/point/point_tiler.py @@ -75,7 +75,7 @@ class PointTiler(Tiler[PointSharedMetadata, PointTilerWorker]): This tiler is able to reproject pointclouds, and can embed arbitrary fields in the resulting 3dtiles - :param crs_in: crs to use for files that don't have crs informations in their metadata, or for all files if `force_crs_in` is used + :param crs_in: crs to use for files that don't have crs information in their metadata, or for all files if `force_crs_in` is used :param crs_out: output crs :param force_crs_in: whether or not to apply crs_in for all files. :param pyproj_always_xy: some crs defines an axis order, but some dataset still use xy order nonetheless. This boolean allows to support this case. diff --git a/py3dtiles/tileset/content/gltf_utils.py b/py3dtiles/tileset/content/gltf_utils.py index 6b7459ca..5f349213 100644 --- a/py3dtiles/tileset/content/gltf_utils.py +++ b/py3dtiles/tileset/content/gltf_utils.py @@ -80,7 +80,7 @@ class GltfMesh: This is intended for higher-level usage than pygltflib.Mesh, which are an exact translation of the specification. - This is intented to be easier to construct by keeping a more hierarchical and logical organization. `GltfMesh` are constructed with all the vertices, normals, uvs and additional attributes, and an optional list of `GltfPrimitive` that contains indices and material informations. + This is intented to be easier to construct by keeping a more hierarchical and logical organization. `GltfMesh` are constructed with all the vertices, normals, uvs and additional attributes, and an optional list of `GltfPrimitive` that contains indices and material information. Use `gltf_from_meshes` or `populate_gltf_from_mesh` to convert it to GLTF format. diff --git a/site/index.html b/site/index.html index 074c146f..65c15d3f 100644 --- a/site/index.html +++ b/site/index.html @@ -263,7 +263,7 @@

Py3dtiles icludes a command line tool to quickly get - informations about 3dtiles files or convert datasets. + information about 3dtiles files or convert datasets. 


py3dtiles convert --out="3dtiles" pointcloud.las
-- GitLab From fda0ad5dc0e2629c3773de92029098500b6262c5 Mon Sep 17 00:00:00 2001 From: Augustin Trancart Date: Thu, 11 Sep 2025 11:25:58 +0200 Subject: [PATCH 2/2] fix(export.py): use black on this file --- py3dtiles/export.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/py3dtiles/export.py b/py3dtiles/export.py index 37633b76..84d136a0 100644 --- a/py3dtiles/export.py +++ b/py3dtiles/export.py @@ -172,7 +172,7 @@ def arrays2tileset( tree.add(node) divide( tile, - geoms[features_per_tile: len(geoms)], + geoms[features_per_tile : len(geoms)], i * 2, j * 2, max_tile_size / 2.0, @@ -243,7 +243,7 @@ def divide( parent.add(node) divide( tile, - geoms[features_per_tile: len(geoms)], + geoms[features_per_tile : len(geoms)], (x_offset + i) * 2, (y_offset + j) * 2, tile_size / 2.0, -- GitLab