From 50e5e232dd8d3b329a9dad4c0475f77cbf129794 Mon Sep 17 00:00:00 2001 From: Everton Constantino Date: Tue, 17 Mar 2020 11:59:35 -0500 Subject: [PATCH 1/2] Disabling unsigned tests for ppc. --- test/packetmath.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/test/packetmath.cpp b/test/packetmath.cpp index 3548eb481..84e7e6104 100644 --- a/test/packetmath.cpp +++ b/test/packetmath.cpp @@ -732,9 +732,11 @@ EIGEN_DECLARE_TEST(packetmath) CALL_SUBTEST_5( test::runner::run() ); CALL_SUBTEST_6( test::runner::run() ); CALL_SUBTEST_7( test::runner::run() ); +#ifndef __PPC__ CALL_SUBTEST_8( test::runner::run() ); - CALL_SUBTEST_9( test::runner::run() ); CALL_SUBTEST_10( test::runner::run() ); +#endif + CALL_SUBTEST_9( test::runner::run() ); CALL_SUBTEST_11( test::runner >::run() ); CALL_SUBTEST_12( test::runner >::run() ); CALL_SUBTEST_13(( packetmath::type>() )); -- GitLab From 0a4efffe7a25743b1023239b55ad6e5e75dd36ce Mon Sep 17 00:00:00 2001 From: Everton Constantino Date: Thu, 19 Mar 2020 13:01:56 -0300 Subject: [PATCH 2/2] Reenabling packetmath unsigned tests, adding dummy pabs for relevant unsigned types. --- Eigen/src/Core/GenericPacketMath.h | 6 ++++++ test/packetmath.cpp | 4 +--- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/Eigen/src/Core/GenericPacketMath.h b/Eigen/src/Core/GenericPacketMath.h index 42d1eb077..13c639f7e 100644 --- a/Eigen/src/Core/GenericPacketMath.h +++ b/Eigen/src/Core/GenericPacketMath.h @@ -195,6 +195,12 @@ pmax(const Packet& a, const Packet& b) { return numext::maxi(a, b); } /** \internal \returns the absolute value of \a a */ template EIGEN_DEVICE_FUNC inline Packet pabs(const Packet& a) { using std::abs; return abs(a); } +template<> EIGEN_DEVICE_FUNC inline unsigned int +pabs(const unsigned int& a) { return a; } +template<> EIGEN_DEVICE_FUNC inline unsigned long +pabs(const unsigned long& a) { return a; } +template<> EIGEN_DEVICE_FUNC inline unsigned long long +pabs(const unsigned long long& a) { return a; } /** \internal \returns the phase angle of \a a */ template EIGEN_DEVICE_FUNC inline Packet diff --git a/test/packetmath.cpp b/test/packetmath.cpp index 84e7e6104..3548eb481 100644 --- a/test/packetmath.cpp +++ b/test/packetmath.cpp @@ -732,11 +732,9 @@ EIGEN_DECLARE_TEST(packetmath) CALL_SUBTEST_5( test::runner::run() ); CALL_SUBTEST_6( test::runner::run() ); CALL_SUBTEST_7( test::runner::run() ); -#ifndef __PPC__ CALL_SUBTEST_8( test::runner::run() ); - CALL_SUBTEST_10( test::runner::run() ); -#endif CALL_SUBTEST_9( test::runner::run() ); + CALL_SUBTEST_10( test::runner::run() ); CALL_SUBTEST_11( test::runner >::run() ); CALL_SUBTEST_12( test::runner >::run() ); CALL_SUBTEST_13(( packetmath::type>() )); -- GitLab