From 4a4e363dafa25112ab4640dd24ada78c2d8762a0 Mon Sep 17 00:00:00 2001 From: joan_s Date: Thu, 27 Feb 2020 10:09:48 +0100 Subject: [PATCH] Clean up cURL client options after closing the handle --- composer.json | 2 +- src/AzureDevOps/Api/Core.php | 2 +- src/AzureDevOps/Api/Core/Projects.php | 2 +- src/AzureDevOps/Api/Core/Teams.php | 2 +- src/AzureDevOps/Api/Work.php | 2 +- src/AzureDevOps/Api/Work/Iterations.php | 2 +- src/AzureDevOps/Api/WorkItemTracking.php | 2 +- src/AzureDevOps/Api/WorkItemTracking/Attachments.php | 2 +- src/AzureDevOps/Api/WorkItemTracking/ClassificationNodes.php | 2 +- src/AzureDevOps/Api/WorkItemTracking/Fields.php | 2 +- src/AzureDevOps/Api/WorkItemTracking/WorkItemTypes.php | 2 +- src/AzureDevOps/Api/WorkItemTracking/WorkItemTypesField.php | 2 +- src/AzureDevOps/Api/WorkItemTracking/WorkItems.php | 2 +- src/AzureDevOps/Client.php | 2 +- src/AzureDevOps/CreateExceptionTrait.php | 2 +- src/AzureDevOps/HttpClient/CurlClient.php | 3 +++ src/AzureDevOps/OAuthClient.php | 2 +- 17 files changed, 19 insertions(+), 16 deletions(-) diff --git a/composer.json b/composer.json index dbd1722..3d363dd 100644 --- a/composer.json +++ b/composer.json @@ -7,7 +7,7 @@ "license": "MIT", "authors": [{ "name": "Joan SOULIARD", - "email": "joan.souliard@gmail.com" + "email": "joan.souliard@pm.me" }], "require": { "php": ">=7.3", diff --git a/src/AzureDevOps/Api/Core.php b/src/AzureDevOps/Api/Core.php index 1addae7..24f832b 100644 --- a/src/AzureDevOps/Api/Core.php +++ b/src/AzureDevOps/Api/Core.php @@ -10,7 +10,7 @@ namespace AzureDevOps\Api; * @method AbstractApi $projects * @method AbstractApi $teams * - * @author Joan Souliard + * @author Joan Souliard */ class Core extends AbstractService { diff --git a/src/AzureDevOps/Api/Core/Projects.php b/src/AzureDevOps/Api/Core/Projects.php index 9f479be..3c94e1d 100644 --- a/src/AzureDevOps/Api/Core/Projects.php +++ b/src/AzureDevOps/Api/Core/Projects.php @@ -10,7 +10,7 @@ use AzureDevOps\Api\AbstractApi; * @method array list * @method array getProject * - * @author Joan Souliard + * @author Joan Souliard */ class Projects extends AbstractApi { diff --git a/src/AzureDevOps/Api/Core/Teams.php b/src/AzureDevOps/Api/Core/Teams.php index d4bc326..fb37e2d 100644 --- a/src/AzureDevOps/Api/Core/Teams.php +++ b/src/AzureDevOps/Api/Core/Teams.php @@ -13,7 +13,7 @@ use AzureDevOps\Api\AbstractApi; * @method array getProjectTeams * @method array getTeamMembers * - * @author Joan Souliard + * @author Joan Souliard */ class Teams extends AbstractApi { diff --git a/src/AzureDevOps/Api/Work.php b/src/AzureDevOps/Api/Work.php index a4773be..2c0a5b3 100644 --- a/src/AzureDevOps/Api/Work.php +++ b/src/AzureDevOps/Api/Work.php @@ -9,7 +9,7 @@ namespace AzureDevOps\Api; * * @method AbstractApi $iterations * - * @author Joan Souliard + * @author Joan Souliard */ class Work extends AbstractService { diff --git a/src/AzureDevOps/Api/Work/Iterations.php b/src/AzureDevOps/Api/Work/Iterations.php index 760926a..0d1f89c 100644 --- a/src/AzureDevOps/Api/Work/Iterations.php +++ b/src/AzureDevOps/Api/Work/Iterations.php @@ -9,7 +9,7 @@ use AzureDevOps\Api\AbstractApi; * * @method array list * - * @author Joan Souliard + * @author Joan Souliard */ class Iterations extends AbstractApi { diff --git a/src/AzureDevOps/Api/WorkItemTracking.php b/src/AzureDevOps/Api/WorkItemTracking.php index d8d8d1a..1b8bf1a 100644 --- a/src/AzureDevOps/Api/WorkItemTracking.php +++ b/src/AzureDevOps/Api/WorkItemTracking.php @@ -14,7 +14,7 @@ namespace AzureDevOps\Api; * @method AbstractApi $workItemTypes * @method AbstractApi $workItemTypesField * - * @author Joan Souliard + * @author Joan Souliard */ class WorkItemTracking extends AbstractService { diff --git a/src/AzureDevOps/Api/WorkItemTracking/Attachments.php b/src/AzureDevOps/Api/WorkItemTracking/Attachments.php index d18b88e..db58369 100644 --- a/src/AzureDevOps/Api/WorkItemTracking/Attachments.php +++ b/src/AzureDevOps/Api/WorkItemTracking/Attachments.php @@ -12,7 +12,7 @@ use AzureDevOps\Client; * * @method array create * - * @author Joan Souliard + * @author Joan Souliard */ class Attachments extends AbstractApi { diff --git a/src/AzureDevOps/Api/WorkItemTracking/ClassificationNodes.php b/src/AzureDevOps/Api/WorkItemTracking/ClassificationNodes.php index ea8449c..adab7d6 100644 --- a/src/AzureDevOps/Api/WorkItemTracking/ClassificationNodes.php +++ b/src/AzureDevOps/Api/WorkItemTracking/ClassificationNodes.php @@ -9,7 +9,7 @@ use AzureDevOps\Api\AbstractApi; * * @method array getClassificationNodes * - * @author Joan Souliard + * @author Joan Souliard */ class ClassificationNodes extends AbstractApi { diff --git a/src/AzureDevOps/Api/WorkItemTracking/Fields.php b/src/AzureDevOps/Api/WorkItemTracking/Fields.php index 8dbcc76..4a42300 100644 --- a/src/AzureDevOps/Api/WorkItemTracking/Fields.php +++ b/src/AzureDevOps/Api/WorkItemTracking/Fields.php @@ -12,7 +12,7 @@ use AzureDevOps\Api\AbstractApi; * @method array list * @method array getField * - * @author Joan Souliard + * @author Joan Souliard */ class Fields extends AbstractApi { diff --git a/src/AzureDevOps/Api/WorkItemTracking/WorkItemTypes.php b/src/AzureDevOps/Api/WorkItemTracking/WorkItemTypes.php index 9b6abbf..109831f 100644 --- a/src/AzureDevOps/Api/WorkItemTracking/WorkItemTypes.php +++ b/src/AzureDevOps/Api/WorkItemTracking/WorkItemTypes.php @@ -12,7 +12,7 @@ use AzureDevOps\Api\AbstractApi; * @method array list * @method array getWorkItemType * - * @author Joan Souliard + * @author Joan Souliard */ class WorkItemTypes extends AbstractApi { diff --git a/src/AzureDevOps/Api/WorkItemTracking/WorkItemTypesField.php b/src/AzureDevOps/Api/WorkItemTracking/WorkItemTypesField.php index 682e1f3..1a4b371 100644 --- a/src/AzureDevOps/Api/WorkItemTracking/WorkItemTypesField.php +++ b/src/AzureDevOps/Api/WorkItemTracking/WorkItemTypesField.php @@ -12,7 +12,7 @@ use AzureDevOps\Api\AbstractApi; * @method array list * @method array getWorkItemTypesField * - * @author Joan Souliard + * @author Joan Souliard */ class WorkItemTypesField extends AbstractApi { diff --git a/src/AzureDevOps/Api/WorkItemTracking/WorkItems.php b/src/AzureDevOps/Api/WorkItemTracking/WorkItems.php index 14f6811..bb9a2c0 100644 --- a/src/AzureDevOps/Api/WorkItemTracking/WorkItems.php +++ b/src/AzureDevOps/Api/WorkItemTracking/WorkItems.php @@ -16,7 +16,7 @@ use AzureDevOps\Client; * @method array getWorkItem * @method array getWorkItemTemplate * - * @author Joan Souliard + * @author Joan Souliard */ class WorkItems extends AbstractApi { diff --git a/src/AzureDevOps/Client.php b/src/AzureDevOps/Client.php index d264bc3..3f1fa1d 100644 --- a/src/AzureDevOps/Client.php +++ b/src/AzureDevOps/Client.php @@ -14,7 +14,7 @@ use AzureDevOps\HttpClient\HttpClientInterface; * * @see https://gitlab.com/joan_s/php-azure-devops-api * - * @author Joan Souliard + * @author Joan Souliard */ class Client { diff --git a/src/AzureDevOps/CreateExceptionTrait.php b/src/AzureDevOps/CreateExceptionTrait.php index ea1906e..651d204 100644 --- a/src/AzureDevOps/CreateExceptionTrait.php +++ b/src/AzureDevOps/CreateExceptionTrait.php @@ -7,7 +7,7 @@ namespace AzureDevOps; * * @method \Exception createException * - * @author Joan Souliard + * @author Joan Souliard */ trait CreateExceptionTrait { diff --git a/src/AzureDevOps/HttpClient/CurlClient.php b/src/AzureDevOps/HttpClient/CurlClient.php index 47081b6..caa2b98 100644 --- a/src/AzureDevOps/HttpClient/CurlClient.php +++ b/src/AzureDevOps/HttpClient/CurlClient.php @@ -19,6 +19,9 @@ class CurlClient implements HttpClientInterface public function close() { curl_close($this->handle); + + $this->curlOptions = []; + $this->handle = null; } /** diff --git a/src/AzureDevOps/OAuthClient.php b/src/AzureDevOps/OAuthClient.php index 5ba45ce..e5fc8f0 100644 --- a/src/AzureDevOps/OAuthClient.php +++ b/src/AzureDevOps/OAuthClient.php @@ -8,7 +8,7 @@ namespace AzureDevOps; * @method array getTokens * @method array refreshTokens * - * @author Joan Souliard + * @author Joan Souliard */ class OAuthClient extends Client { -- GitLab