From 47191706c3daccd94263ee67837f38bc577f1071 Mon Sep 17 00:00:00 2001 From: Christian Rohlfs Date: Sat, 11 Mar 2023 00:47:40 +0500 Subject: [PATCH] Fix crash on output extension fail If 'Save As' extension fails, then `(SPDocument*)->document_filename` is `nullptr` and Inkscape crashes in `SPDesktopWidget::updateTitle()`. --- src/document.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/document.cpp b/src/document.cpp index ded7602a87..92b69720d1 100644 --- a/src/document.cpp +++ b/src/document.cpp @@ -1104,7 +1104,9 @@ void SPDocument::do_change_filename(gchar const *const filename, bool const reba this->document_base = new_document_base; this->document_filename = new_document_filename; - this->filename_set_signal.emit(this->document_filename); + // In case of new document the filename is nullptr + gchar *new_filename = this->document_filename ? this->document_filename : this->document_name; + this->filename_set_signal.emit(new_filename); } /** -- GitLab