From dc2a4bb7c15dbb79bd129d0f40b16ebd05548e58 Mon Sep 17 00:00:00 2001 From: Andrew Newdigate Date: Mon, 2 Nov 2020 12:42:59 +0200 Subject: [PATCH 1/2] Add reviewer process to README.md --- README.md | 22 +++++++++++++++++++++- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/README.md b/README.md index e5631f9..e8a1f02 100644 --- a/README.md +++ b/README.md @@ -60,7 +60,9 @@ import ( Anyone can contribute! -Please be aware of the following however. +### Architectural guidelines + +Please be aware of the following architectural guidelines. ### Public APIs in LabKit should be stable @@ -94,3 +96,21 @@ This book is recommended reading. * Separate general-purpose and special-purpose code * Design it twice * Comments should describe things that are not obvious from the code + +### Review Process + +Please assign your MR to a reviewer for a first review, followed by a maintainer review. + +Currently, the reviewers are: + +1. [@igorwwwwwwwwwwwwwwwwwwww](https://gitlab.com/igorwwwwwwwwwwwwwwwwwwww) +1. [@jdrpereira](https://gitlab.com/jdrpereira) + +The maintainers are: + +1. [@andrewn](https://gitlab.com/andrewn) +1. [@hphilipps](https://gitlab.com/hphilipps) +1. [@steveazz](https://gitlab.com/steveazz) +1. [@zj-gitlab](https://gitlab.com/zj-gitlab) + +While not strictly neccessary, it is preferred for the author of changes to also send downstream MRs to Gitaly, Workhorse, GitLab-Pages and KAS to update those clients to the latest LabKit version. -- GitLab From 99c0ec153e3344b9fd9f61d27a56725fa92df9a8 Mon Sep 17 00:00:00 2001 From: Andrew Newdigate Date: Wed, 11 Nov 2020 14:41:19 +0000 Subject: [PATCH 2/2] Apply 1 suggestion(s) to 1 file(s) --- README.md | 1 + 1 file changed, 1 insertion(+) diff --git a/README.md b/README.md index e8a1f02..4d9ec4b 100644 --- a/README.md +++ b/README.md @@ -105,6 +105,7 @@ Currently, the reviewers are: 1. [@igorwwwwwwwwwwwwwwwwwwww](https://gitlab.com/igorwwwwwwwwwwwwwwwwwwww) 1. [@jdrpereira](https://gitlab.com/jdrpereira) +1. [@8bitlife](https://gitlab.com/8bitlife) The maintainers are: -- GitLab