From 2e0f058771e78564977118b005751e36b0820d31 Mon Sep 17 00:00:00 2001 From: Siddharth Asthana Date: Fri, 5 Aug 2022 17:40:29 +0530 Subject: [PATCH] RuboCop: Enable previously disabled Style/RedundantSelf Changelog: other --- .rubocop_todo/style/redundant_self.yml | 31 +++++++++++++++++++------- 1 file changed, 23 insertions(+), 8 deletions(-) diff --git a/.rubocop_todo/style/redundant_self.yml b/.rubocop_todo/style/redundant_self.yml index 9951160ae02838..65f2ea327d7e14 100644 --- a/.rubocop_todo/style/redundant_self.yml +++ b/.rubocop_todo/style/redundant_self.yml @@ -1,12 +1,11 @@ --- # Cop supports --auto-correct. Style/RedundantSelf: - # Offense count: 1222 - # Temporarily disabled due to too many offenses - Enabled: false Exclude: + - 'app/channels/awareness_channel.rb' - 'app/controllers/application_controller.rb' - 'app/finders/security/jobs_finder.rb' + - 'app/graphql/types/permission_types/base_permission_type.rb' - 'app/models/abuse_report.rb' - 'app/models/analytics/usage_trends/measurement.rb' - 'app/models/application_record.rb' @@ -74,6 +73,7 @@ Style/RedundantSelf: - 'app/models/concerns/merge_request_reviewer_state.rb' - 'app/models/concerns/noteable.rb' - 'app/models/concerns/packages/debian/distribution.rb' + - 'app/models/concerns/participable.rb' - 'app/models/concerns/pg_full_text_searchable.rb' - 'app/models/concerns/protected_ref.rb' - 'app/models/concerns/protected_ref_access.rb' @@ -102,6 +102,7 @@ Style/RedundantSelf: - 'app/models/gpg_key.rb' - 'app/models/group.rb' - 'app/models/group_group_link.rb' + - 'app/models/hooks/web_hook_log.rb' - 'app/models/identity.rb' - 'app/models/integration.rb' - 'app/models/integrations/base_chat_notification.rb' @@ -112,6 +113,7 @@ Style/RedundantSelf: - 'app/models/integrations/emails_on_push.rb' - 'app/models/integrations/jira.rb' - 'app/models/integrations/pipelines_email.rb' + - 'app/models/integrations/slack.rb' - 'app/models/integrations/zentao.rb' - 'app/models/internal_id.rb' - 'app/models/issue.rb' @@ -125,11 +127,10 @@ Style/RedundantSelf: - 'app/models/member.rb' - 'app/models/members/project_member.rb' - 'app/models/merge_request.rb' + - 'app/models/merge_request/cleanup_schedule.rb' - 'app/models/merge_request/metrics.rb' - - 'app/models/merge_request_assignee.rb' - 'app/models/merge_request_diff.rb' - 'app/models/merge_request_diff_commit.rb' - - 'app/models/merge_request_reviewer.rb' - 'app/models/namespaces/traversal/linear.rb' - 'app/models/note.rb' - 'app/models/packages/dependency.rb' @@ -179,10 +180,11 @@ Style/RedundantSelf: - 'app/uploaders/gitlab_uploader.rb' - 'app/uploaders/object_storage.rb' - 'app/workers/background_migration/single_database_worker.rb' + - 'app/workers/build_hooks_worker.rb' - 'app/workers/concerns/application_worker.rb' - 'app/workers/concerns/limited_capacity/worker.rb' - 'app/workers/concerns/project_start_import.rb' - - 'app/workers/concerns/waitable_worker.rb' + - 'app/workers/concerns/reenqueuer.rb' - 'app/workers/database/batched_background_migration/single_database_worker.rb' - 'app/workers/group_import_worker.rb' - 'app/workers/project_export_worker.rb' @@ -193,6 +195,7 @@ Style/RedundantSelf: - 'db/post_migrate/20210329102724_add_new_trail_plans.rb' - 'db/post_migrate/20211029102822_add_open_source_plan.rb' - 'ee/app/graphql/resolvers/geo/registries_resolver.rb' + - 'ee/app/models/approval_merge_request_rule.rb' - 'ee/app/models/approval_project_rule.rb' - 'ee/app/models/concerns/approval_rule_like.rb' - 'ee/app/models/concerns/custom_model_naming.rb' @@ -216,9 +219,12 @@ Style/RedundantSelf: - 'ee/app/models/ee/description_version.rb' - 'ee/app/models/ee/environment.rb' - 'ee/app/models/ee/epic.rb' + - 'ee/app/models/ee/group.rb' - 'ee/app/models/ee/group_member.rb' - 'ee/app/models/ee/issue.rb' - 'ee/app/models/ee/iteration.rb' + - 'ee/app/models/ee/member.rb' + - 'ee/app/models/ee/merge_request.rb' - 'ee/app/models/ee/namespace.rb' - 'ee/app/models/ee/packages/package_file.rb' - 'ee/app/models/ee/project.rb' @@ -247,13 +253,17 @@ Style/RedundantSelf: - 'ee/lib/ee/gitlab/auth/ldap/sync/groups.rb' - 'ee/lib/ee/gitlab/auth/ldap/sync/proxy.rb' - 'ee/lib/ee/gitlab/auth/ldap/sync/users.rb' + - 'ee/lib/ee/gitlab/background_migration/backfill_project_statistics_container_repository_size.rb' + - 'ee/lib/ee/gitlab/background_migration/delete_invalid_epic_issues.rb' - 'ee/lib/ee/gitlab/background_migration/fix_incorrect_max_seats_used.rb' - 'ee/lib/ee/gitlab/background_migration/populate_uuids_for_security_findings.rb' + - 'ee/lib/ee/gitlab/database.rb' - 'ee/lib/ee/gitlab/tracking.rb' - 'ee/lib/ee/legacy_model.rb' - 'ee/lib/ee/model.rb' - 'ee/lib/elastic/instance_proxy_util.rb' - 'ee/lib/elastic/latest/application_class_proxy.rb' + - 'ee/lib/elastic/latest/commit_config.rb' - 'ee/lib/elastic/latest/issue_config.rb' - 'ee/lib/elastic/latest/merge_request_config.rb' - 'ee/lib/elastic/latest/note_config.rb' @@ -275,9 +285,9 @@ Style/RedundantSelf: - 'ee/lib/gitlab/geo/oauth/logout_state.rb' - 'ee/lib/gitlab/geo/replicator.rb' - 'ee/lib/gitlab/template/custom_template.rb' + - 'ee/lib/system_check/app/search_check.rb' - 'ee/spec/helpers/ee/feature_flags_helper_spec.rb' - 'ee/spec/helpers/ee/graph_helper_spec.rb' - - 'ee/spec/models/geo/deleted_project_spec.rb' - 'lib/api/entities/wiki_attachment.rb' - 'lib/api/helpers.rb' - 'lib/api/helpers/packages_helpers.rb' @@ -328,6 +338,7 @@ Style/RedundantSelf: - 'lib/gitlab/database/load_balancing/service_discovery.rb' - 'lib/gitlab/database/loose_foreign_keys.rb' - 'lib/gitlab/database/migration_helpers/restrict_gitlab_schema.rb' + - 'lib/gitlab/database/migrations/background_migration_helpers.rb' - 'lib/gitlab/database/partitioning_migration_helpers/table_management_helpers.rb' - 'lib/gitlab/database/query_analyzers/base.rb' - 'lib/gitlab/database/query_analyzers/prevent_cross_database_modification.rb' @@ -339,6 +350,7 @@ Style/RedundantSelf: - 'lib/gitlab/diff/file.rb' - 'lib/gitlab/diff/rendered/notebook/diff_file.rb' - 'lib/gitlab/email/smtp_config.rb' + - 'lib/gitlab/error_tracking/logger.rb' - 'lib/gitlab/feature_categories.rb' - 'lib/gitlab/git.rb' - 'lib/gitlab/git/blob.rb' @@ -347,6 +359,7 @@ Style/RedundantSelf: - 'lib/gitlab/git/tree.rb' - 'lib/gitlab/git_access.rb' - 'lib/gitlab/github_import.rb' + - 'lib/gitlab/graphql/deprecations_base.rb' - 'lib/gitlab/graphql/known_operations.rb' - 'lib/gitlab/graphql/lazy.rb' - 'lib/gitlab/graphql/representation/submodule_tree_entry.rb' @@ -399,10 +412,10 @@ Style/RedundantSelf: - 'lib/system_check/rake_task/rake_task_helpers.rb' - 'lib/uploaded_file.rb' - 'qa/lib/gitlab/page/main/sign_up.rb' - - 'qa/qa/git/repository.rb' - 'qa/qa/page/validatable.rb' - 'qa/qa/resource/base.rb' - 'qa/qa/resource/events/project.rb' + - 'qa/qa/resource/personal_access_token.rb' - 'qa/qa/resource/protected_branch.rb' - 'qa/qa/resource/reusable.rb' - 'qa/qa/resource/user_gpg.rb' @@ -416,6 +429,8 @@ Style/RedundantSelf: - 'spec/helpers/graph_helper_spec.rb' - 'spec/helpers/ide_helper_spec.rb' - 'spec/helpers/submodule_helper_spec.rb' + - 'spec/lib/gitlab/background_task_spec.rb' - 'spec/lib/gitlab/database/load_balancing_spec.rb' + - 'spec/models/integration_spec.rb' - 'spec/support/before_all_adapter.rb' - 'spec/support/cycle_analytics_helpers/test_generation.rb' -- GitLab