From e8ce8c53032cd838517c8673180787dbb950a0d1 Mon Sep 17 00:00:00 2001 From: Siddharth Asthana Date: Wed, 3 Aug 2022 17:53:46 +0530 Subject: [PATCH] RuboCop: Enable previously disabled Rails/RedundantForeignKey Changelog: other --- .rubocop_todo/rails/redundant_foreign_key.yml | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/.rubocop_todo/rails/redundant_foreign_key.yml b/.rubocop_todo/rails/redundant_foreign_key.yml index 7e394849670d34..22af6131b3356e 100644 --- a/.rubocop_todo/rails/redundant_foreign_key.yml +++ b/.rubocop_todo/rails/redundant_foreign_key.yml @@ -1,9 +1,7 @@ --- # Cop supports --auto-correct. Rails/RedundantForeignKey: - # Offense count: 90 - # Temporarily disabled due to too many offenses - Enabled: false + Details: grace period Exclude: - 'app/models/alert_management/metric_image.rb' - 'app/models/ci/build.rb' @@ -23,9 +21,11 @@ Rails/RedundantForeignKey: - 'app/models/commit_signatures/x509_commit_signature.rb' - 'app/models/concerns/analytics/cycle_analytics/stage.rb' - 'app/models/concerns/commit_signature.rb' + - 'app/models/concerns/integrations/base_data_fields.rb' - 'app/models/group.rb' - 'app/models/group_group_link.rb' - - 'app/models/integrations/zentao_tracker_data.rb' + - 'app/models/incident_management/timeline_event.rb' + - 'app/models/issue.rb' - 'app/models/member.rb' - 'app/models/merge_request.rb' - 'app/models/merge_request/metrics.rb' @@ -35,9 +35,13 @@ Rails/RedundantForeignKey: - 'app/models/project.rb' - 'app/models/resource_state_event.rb' - 'app/models/review.rb' + - 'app/models/time_tracking/timelog_category.rb' - 'app/models/user.rb' + - 'app/models/users/phone_number_validation.rb' + - 'app/models/work_item.rb' - 'app/models/x509_certificate.rb' - 'ee/app/models/allowed_email_domain.rb' + - 'ee/app/models/audit_events/streaming/header.rb' - 'ee/app/models/boards/epic_board.rb' - 'ee/app/models/boards/epic_list_user_preference.rb' - 'ee/app/models/ci/sources/project.rb' -- GitLab