From 6a8ee74c7dff0b847315e4842d63c2de0a951e16 Mon Sep 17 00:00:00 2001 From: Peter Leitzen Date: Thu, 30 Jun 2022 15:39:39 +0200 Subject: [PATCH] RuboCop: Enable RSpec/RepeatedExampleGroup{Body,Description} cops In the past, they were automatically disabled by RuboCop due to too many offenses. Enabling them potentially improves the runtime of some specs so it's worth enabling now. --- .../rspec/repeated_example_group_body.yml | 7 ++----- .../repeated_example_group_description.yml | 18 +++++++++--------- 2 files changed, 11 insertions(+), 14 deletions(-) diff --git a/.rubocop_todo/rspec/repeated_example_group_body.yml b/.rubocop_todo/rspec/repeated_example_group_body.yml index e006396d0d6454..6fdeb9a209413d 100644 --- a/.rubocop_todo/rspec/repeated_example_group_body.yml +++ b/.rubocop_todo/rspec/repeated_example_group_body.yml @@ -1,8 +1,5 @@ --- RSpec/RepeatedExampleGroupBody: - # Offense count: 143 - # Temporarily disabled due to too many offenses - Enabled: false Exclude: - 'ee/spec/controllers/ee/groups_controller_spec.rb' - 'ee/spec/lib/banzai/filter/references/vulnerability_reference_filters_spec.rb' @@ -18,7 +15,6 @@ RSpec/RepeatedExampleGroupBody: - 'ee/spec/requests/api/graphql/mutations/compliance_management/frameworks/update_spec.rb' - 'ee/spec/requests/groups/security/credentials_controller_spec.rb' - 'ee/spec/services/app_sec/dast/profiles/create_associations_service_spec.rb' - - 'ee/spec/services/groups/sync_service_spec.rb' - 'spec/controllers/groups/registry/repositories_controller_spec.rb' - 'spec/controllers/projects/blob_controller_spec.rb' - 'spec/controllers/projects/graphs_controller_spec.rb' @@ -30,6 +26,7 @@ RSpec/RepeatedExampleGroupBody: - 'spec/features/security/project/private_access_spec.rb' - 'spec/finders/packages/nuget/package_finder_spec.rb' - 'spec/helpers/gitlab_routing_helper_spec.rb' + - 'spec/helpers/groups_helper_spec.rb' - 'spec/lib/api/entities/application_setting_spec.rb' - 'spec/lib/banzai/filter/references/commit_range_reference_filter_spec.rb' - 'spec/lib/banzai/filter/references/commit_reference_filter_spec.rb' @@ -38,9 +35,9 @@ RSpec/RepeatedExampleGroupBody: - 'spec/lib/gitlab/ci/config/entry/release_spec.rb' - 'spec/lib/gitlab/ci/pipeline/seed/build_spec.rb' - 'spec/lib/gitlab/ci/yaml_processor_spec.rb' + - 'spec/lib/gitlab/database/migrations/batched_background_migration_helpers_spec.rb' - 'spec/lib/gitlab/empty_search_results_spec.rb' - 'spec/lib/gitlab/import_export/project/sample/relation_factory_spec.rb' - - 'spec/lib/gitlab/import_export/project/tree_restorer_spec.rb' - 'spec/lib/gitlab/lfs/client_spec.rb' - 'spec/lib/gitlab/pagination/keyset/simple_order_builder_spec.rb' - 'spec/lib/gitlab/sanitizers/exif_spec.rb' diff --git a/.rubocop_todo/rspec/repeated_example_group_description.yml b/.rubocop_todo/rspec/repeated_example_group_description.yml index 562f5602d58182..b5c4ac090ae419 100644 --- a/.rubocop_todo/rspec/repeated_example_group_description.yml +++ b/.rubocop_todo/rspec/repeated_example_group_description.yml @@ -1,10 +1,8 @@ --- RSpec/RepeatedExampleGroupDescription: - # Offense count: 263 - # Temporarily disabled due to too many offenses - Enabled: false Exclude: - 'ee/spec/finders/merge_trains_finder_spec.rb' + - 'ee/spec/finders/security/vulnerability_reads_finder_spec.rb' - 'ee/spec/graphql/resolvers/vulnerabilities_grade_resolver_spec.rb' - 'ee/spec/graphql/resolvers/vulnerability_severities_count_resolver_spec.rb' - 'ee/spec/helpers/ee/auth_helper_spec.rb' @@ -24,16 +22,15 @@ RSpec/RepeatedExampleGroupDescription: - 'ee/spec/models/software_license_spec.rb' - 'ee/spec/policies/app_sec/fuzzing/coverage/corpus_policy_spec.rb' - 'ee/spec/policies/group_policy_spec.rb' - - 'ee/spec/policies/project_policy_spec.rb' - 'ee/spec/requests/api/graphql/iteration_spec.rb' - 'ee/spec/requests/api/graphql/mutations/iterations/create_spec.rb' - - 'ee/spec/requests/api/graphql/vulnerabilities/sort_spec.rb' - 'ee/spec/requests/groups/security/credentials_controller_spec.rb' + - 'ee/spec/requests/groups/settings/reporting_controller_spec.rb' - 'ee/spec/services/app_sec/dast/profiles/create_associations_service_spec.rb' - 'ee/spec/services/app_sec/dast/site_validations/find_or_create_service_spec.rb' - 'ee/spec/services/audit_event_service_spec.rb' - - 'ee/spec/services/groups/sync_service_spec.rb' - 'ee/spec/services/todo_service_spec.rb' + - 'ee/spec/support/shared_examples/models/concerns/verifiable_replicator_shared_examples.rb' - 'ee/spec/support/shared_examples/services/scoped_label_shared_examples.rb' - 'ee/spec/views/layouts/nav/sidebar/_project.html.haml_spec.rb' - 'spec/controllers/profiles/notifications_controller_spec.rb' @@ -44,6 +41,7 @@ RSpec/RepeatedExampleGroupDescription: - 'spec/features/merge_request/user_sees_merge_widget_spec.rb' - 'spec/features/projects/jobs_spec.rb' - 'spec/features/projects/new_project_spec.rb' + - 'spec/features/projects/pipelines/legacy_pipeline_spec.rb' - 'spec/features/security/project/private_access_spec.rb' - 'spec/finders/ci/pipelines_for_merge_request_finder_spec.rb' - 'spec/frontend/fixtures/runner.rb' @@ -52,7 +50,6 @@ RSpec/RepeatedExampleGroupDescription: - 'spec/helpers/dropdowns_helper_spec.rb' - 'spec/helpers/gitlab_routing_helper_spec.rb' - 'spec/helpers/namespaces_helper_spec.rb' - - 'spec/initializers/omniauth_spec.rb' - 'spec/lib/banzai/pipeline/gfm_pipeline_spec.rb' - 'spec/lib/gitlab/alert_management/payload/base_spec.rb' - 'spec/lib/gitlab/auth/atlassian/auth_hash_spec.rb' @@ -69,14 +66,15 @@ RSpec/RepeatedExampleGroupDescription: - 'spec/lib/gitlab/ci/pipeline/seed/build_spec.rb' - 'spec/lib/gitlab/ci/yaml_processor_spec.rb' - 'spec/lib/gitlab/data_builder/push_spec.rb' + - 'spec/lib/gitlab/database/migrations/batched_background_migration_helpers_spec.rb' - 'spec/lib/gitlab/database_importers/common_metrics/importer_spec.rb' - 'spec/lib/gitlab/git/diff_spec.rb' - 'spec/lib/gitlab/git/push_spec.rb' - 'spec/lib/gitlab/git/repository_spec.rb' - 'spec/lib/gitlab/import_export/project/sample/relation_factory_spec.rb' - - 'spec/lib/gitlab/import_export/project/tree_restorer_spec.rb' - 'spec/lib/gitlab/kubernetes/rollout_status_spec.rb' - 'spec/lib/gitlab/metrics/dashboard/validator/errors_spec.rb' + - 'spec/lib/gitlab/redis/multi_store_spec.rb' - 'spec/lib/gitlab/sanitizers/exif_spec.rb' - 'spec/lib/gitlab/template/finders/global_template_finder_spec.rb' - 'spec/lib/gitlab/usage_data_spec.rb' @@ -93,8 +91,10 @@ RSpec/RepeatedExampleGroupDescription: - 'spec/models/project_spec.rb' - 'spec/models/ssh_host_key_spec.rb' - 'spec/requests/api/files_spec.rb' + - 'spec/requests/api/graphql/ci/runners_spec.rb' - 'spec/requests/api/graphql/project/release_spec.rb' - 'spec/requests/api/group_clusters_spec.rb' + - 'spec/requests/api/internal/base_spec.rb' - 'spec/requests/api/merge_requests_spec.rb' - 'spec/requests/api/notification_settings_spec.rb' - 'spec/requests/api/project_clusters_spec.rb' @@ -105,10 +105,10 @@ RSpec/RepeatedExampleGroupDescription: - 'spec/services/import/github_service_spec.rb' - 'spec/services/merge_requests/refresh_service_spec.rb' - 'spec/services/metrics/dashboard/gitlab_alert_embed_service_spec.rb' - - 'spec/services/resource_access_tokens/create_service_spec.rb' - 'spec/services/verify_pages_domain_service_spec.rb' - 'spec/support/cycle_analytics_helpers/test_generation.rb' - 'spec/support/shared_examples/models/application_setting_shared_examples.rb' + - 'spec/support/shared_examples/models/concerns/limitable_shared_examples.rb' - 'spec/support/shared_examples/requests/api/composer_packages_shared_examples.rb' - 'spec/support/shared_examples/serializers/diff_file_entity_shared_examples.rb' - 'spec/support/shared_examples/services/container_registry_auth_service_shared_examples.rb' -- GitLab