From f5ace9c15f79530bab3136f54a8d1dc7e3d26544 Mon Sep 17 00:00:00 2001 From: Kai Armstrong Date: Wed, 18 May 2022 09:13:14 -0500 Subject: [PATCH] Remove count ipynb metrics from aggregate --- config/metrics/aggregates/code_review.yml | 6 ------ .../gitlab/usage_data_counters/code_review_events_spec.rb | 2 +- 2 files changed, 1 insertion(+), 7 deletions(-) diff --git a/config/metrics/aggregates/code_review.yml b/config/metrics/aggregates/code_review.yml index a25222b8d6bbf2..f6ed93c650e5a7 100644 --- a/config/metrics/aggregates/code_review.yml +++ b/config/metrics/aggregates/code_review.yml @@ -78,9 +78,6 @@ - 'i_code_review_user_create_note_in_ipynb_diff' - 'i_code_review_user_create_note_in_ipynb_diff_mr' - 'i_code_review_user_create_note_in_ipynb_diff_commit' - - 'i_code_review_create_note_in_ipynb_diff' - - 'i_code_review_create_note_in_ipynb_diff_mr' - - 'i_code_review_create_note_in_ipynb_diff_commit' - name: code_review_category_monthly_active_users operator: OR source: redis @@ -149,9 +146,6 @@ - 'i_code_review_user_create_note_in_ipynb_diff' - 'i_code_review_user_create_note_in_ipynb_diff_mr' - 'i_code_review_user_create_note_in_ipynb_diff_commit' - - 'i_code_review_create_note_in_ipynb_diff' - - 'i_code_review_create_note_in_ipynb_diff_mr' - - 'i_code_review_create_note_in_ipynb_diff_commit' - name: code_review_extension_category_monthly_active_users operator: OR source: redis diff --git a/spec/lib/gitlab/usage_data_counters/code_review_events_spec.rb b/spec/lib/gitlab/usage_data_counters/code_review_events_spec.rb index c4a84445a01032..0d45c4a4352e3d 100644 --- a/spec/lib/gitlab/usage_data_counters/code_review_events_spec.rb +++ b/spec/lib/gitlab/usage_data_counters/code_review_events_spec.rb @@ -15,7 +15,7 @@ code_review_events = Gitlab::UsageDataCounters::HLLRedisCounter.events_for_category("code_review") - exceptions = %w[i_code_review_mr_diffs i_code_review_mr_single_file_diffs i_code_review_total_suggestions_applied i_code_review_total_suggestions_added] + exceptions = %w[i_code_review_mr_diffs i_code_review_mr_single_file_diffs i_code_review_total_suggestions_applied i_code_review_total_suggestions_added i_code_review_create_note_in_ipynb_diff i_code_review_create_note_in_ipynb_diff_mr i_code_review_create_note_in_ipynb_diff_commit] code_review_aggregated_events += exceptions expect(code_review_events - code_review_aggregated_events).to be_empty -- GitLab