From 786f677271e0fa88d140cd79cbcc3ccd976ec1b3 Mon Sep 17 00:00:00 2001 From: Anshul Riyal Date: Mon, 9 May 2022 02:03:25 +0530 Subject: [PATCH] Move Style/HashAsLastArrayItem into separate TODO file Changelog: other --- .rubocop_todo.yml | 7 --- .../style/hash_as_last_array_item.yml | 62 +++++++++++++++++++ 2 files changed, 62 insertions(+), 7 deletions(-) create mode 100644 .rubocop_todo/style/hash_as_last_array_item.yml diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index fab7693f46608f..9706b9e6d20cd1 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -59,10 +59,3 @@ Style/CaseLikeIf: # SupportedStyles: compact, expanded Style/EmptyMethod: Enabled: false - -# Offense count: 59 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle. -# SupportedStyles: braces, no_braces -Style/HashAsLastArrayItem: - Enabled: false diff --git a/.rubocop_todo/style/hash_as_last_array_item.yml b/.rubocop_todo/style/hash_as_last_array_item.yml new file mode 100644 index 00000000000000..eec2e77eafd21b --- /dev/null +++ b/.rubocop_todo/style/hash_as_last_array_item.yml @@ -0,0 +1,62 @@ +--- +# Cop supports --auto-correct. +Style/HashAsLastArrayItem: + # Offense count: 79 + # Temporarily disabled due to too many offenses + Enabled: false + Exclude: + - 'app/controllers/admin/application_settings_controller.rb' + - 'app/controllers/admin/groups_controller.rb' + - 'app/controllers/admin/users_controller.rb' + - 'app/controllers/boards/issues_controller.rb' + - 'app/controllers/clusters/clusters_controller.rb' + - 'app/controllers/concerns/issuable_actions.rb' + - 'app/controllers/concerns/issuable_collections.rb' + - 'app/controllers/profiles_controller.rb' + - 'app/controllers/projects/feature_flags_controller.rb' + - 'app/controllers/projects/merge_requests/application_controller.rb' + - 'app/controllers/projects/performance_monitoring/dashboards_controller.rb' + - 'app/controllers/projects/protected_branches_controller.rb' + - 'app/controllers/projects/settings/ci_cd_controller.rb' + - 'app/controllers/projects/settings/operations_controller.rb' + - 'app/controllers/projects_controller.rb' + - 'app/graphql/resolvers/clusters/agents_resolver.rb' + - 'app/graphql/resolvers/concerns/issue_resolver_arguments.rb' + - 'app/graphql/types/boards/board_issuable_input_base_type.rb' + - 'app/graphql/types/boards/board_issue_input_base_type.rb' + - 'app/helpers/learn_gitlab_helper.rb' + - 'app/helpers/namespaces_helper.rb' + - 'app/models/customer_relations/contact.rb' + - 'app/models/customer_relations/organization.rb' + - 'app/models/deploy_key.rb' + - 'app/models/issue.rb' + - 'app/models/merge_request.rb' + - 'app/models/milestone.rb' + - 'app/models/preloaders/labels_preloader.rb' + - 'app/models/user.rb' + - 'app/serializers/deployment_serializer.rb' + - 'app/services/ci/delete_objects_service.rb' + - 'ee/app/controllers/ee/admin/groups_controller.rb' + - 'ee/app/controllers/ee/admin/users_controller.rb' + - 'ee/app/controllers/groups/epics_controller.rb' + - 'ee/app/graphql/ee/resolvers/base_issues_resolver.rb' + - 'ee/app/graphql/types/epics/negated_epic_filter_input_type.rb' + - 'ee/app/models/ee/merge_request.rb' + - 'ee/app/models/ee/vulnerability.rb' + - 'ee/app/models/vulnerabilities/read.rb' + - 'ee/app/serializers/dashboard_environments_serializer.rb' + - 'ee/spec/finders/projects/integrations/jira/by_ids_finder_spec.rb' + - 'ee/spec/lib/ee/gitlab/ci/config/entry/needs_spec.rb' + - 'ee/spec/lib/gitlab/geo/log_cursor/events/container_repository_updated_event_spec.rb' + - 'ee/spec/lib/gitlab/geo/log_cursor/events/design_repository_updated_event_spec.rb' + - 'ee/spec/models/ee/ci/job_artifact_spec.rb' + - 'lib/api/entities/project.rb' + - 'lib/gitlab/analytics/cycle_analytics/request_params.rb' + - 'lib/gitlab/database/migration_helpers.rb' + - 'spec/lib/gitlab/database/migration_helpers/v2_spec.rb' + - 'spec/migrations/20210914095310_cleanup_orphan_project_access_tokens_spec.rb' + - 'spec/requests/rack_attack_global_spec.rb' + - 'spec/services/git/branch_hooks_service_spec.rb' + - 'spec/services/metrics/dashboard/panel_preview_service_spec.rb' + - 'spec/support/helpers/rack_attack_spec_helpers.rb' + - 'spec/workers/merge_worker_spec.rb' -- GitLab