From 79366a54a333956dbb716c3b1a0437f5d81ba244 Mon Sep 17 00:00:00 2001 From: Anshul Riyal Date: Mon, 9 May 2022 01:21:12 +0530 Subject: [PATCH] Move Rails/NegateInclude into separate TODO file Changelog: other --- .rubocop_todo.yml | 5 --- .rubocop_todo/rails/negate_include.yml | 58 ++++++++++++++++++++++++++ 2 files changed, 58 insertions(+), 5 deletions(-) create mode 100644 .rubocop_todo/rails/negate_include.yml diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index 64ee60d7eb82a3..6487dbb6f597d5 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -55,11 +55,6 @@ Rails/MailerName: Exclude: - 'app/mailers/notify.rb' -# Offense count: 51 -# Cop supports --auto-correct. -Rails/NegateInclude: - Enabled: false - # Offense count: 44 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle. diff --git a/.rubocop_todo/rails/negate_include.yml b/.rubocop_todo/rails/negate_include.yml new file mode 100644 index 00000000000000..7bf78b82b604c6 --- /dev/null +++ b/.rubocop_todo/rails/negate_include.yml @@ -0,0 +1,58 @@ +--- +# Cop supports --auto-correct. +Rails/NegateInclude: + # Offense count: 65 + # Temporarily disabled due to too many offenses + Enabled: false + Exclude: + - 'app/finders/projects_finder.rb' + - 'app/helpers/application_settings_helper.rb' + - 'app/helpers/projects_helper.rb' + - 'app/helpers/tree_helper.rb' + - 'app/models/concerns/timebox.rb' + - 'app/models/integrations/chat_message/pipeline_message.rb' + - 'app/models/label.rb' + - 'app/models/merge_request.rb' + - 'app/services/todo_service.rb' + - 'config/application.rb' + - 'config/initializers/1_settings.rb' + - 'danger/roulette/Dangerfile' + - 'ee/app/finders/security/pipeline_vulnerabilities_finder.rb' + - 'ee/app/models/ee/epic.rb' + - 'ee/app/models/ee/vulnerability.rb' + - 'ee/app/services/epic_issues/create_service.rb' + - 'ee/app/services/security/ingestion/tasks/ingest_remediations.rb' + - 'ee/app/services/security/security_orchestration_policies/validate_policy_service.rb' + - 'lib/api/maven_packages.rb' + - 'lib/generators/gitlab/usage_metric_generator.rb' + - 'lib/gitlab/background_migration/legacy_upload_mover.rb' + - 'lib/gitlab/ci/build/rules/rule/clause/exists.rb' + - 'lib/gitlab/ci/parsers/coverage/sax_document.rb' + - 'lib/gitlab/ci/queue/metrics.rb' + - 'lib/gitlab/database/each_database.rb' + - 'lib/gitlab/email/handler/create_issue_handler.rb' + - 'lib/gitlab/email/handler/service_desk_handler.rb' + - 'lib/gitlab/graphql/queries.rb' + - 'lib/gitlab/import_export/attributes_permitter.rb' + - 'lib/gitlab/search_results.rb' + - 'lib/gitlab/task_helpers.rb' + - 'lib/gitlab/url_blocker.rb' + - 'lib/gitlab_edition.rb' + - 'qa/qa/runtime/ip_address.rb' + - 'qa/qa/support/run.rb' + - 'qa/qa/tools/delete_test_users.rb' + - 'qa/qa/vendor/jenkins/page/configure_job.rb' + - 'qa/qa/vendor/jenkins/page/last_job_console.rb' + - 'rubocop/cop/gitlab/feature_available_usage.rb' + - 'rubocop/cop/graphql/id_type.rb' + - 'rubocop/cop/migration/add_reference.rb' + - 'rubocop/cop/rspec/factory_bot/inline_association.rb' + - 'scripts/lib/gitlab.rb' + - 'scripts/static-analysis' + - 'spec/lib/container_registry/blob_spec.rb' + - 'spec/lib/container_registry/client_spec.rb' + - 'spec/lib/gitlab/metrics/dashboard/stages/metric_endpoint_inserter_spec.rb' + - 'spec/lib/gitlab/metrics/subscribers/active_record_spec.rb' + - 'spec/support/matchers/pushed_frontend_feature_flags_matcher.rb' + - 'spec/support/shared_contexts/markdown_golden_master_shared_examples.rb' + - 'spec/uploaders/object_storage_spec.rb' -- GitLab